From: David Hildenbrand via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-fsdevel@vger.kernel.org
Cc: linux-aio@kvack.org, linux-nfs@vger.kernel.org,
cluster-devel@redhat.com, linux-ntfs-dev@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-block@vger.kernel.org, linux-mm@kvack.org,
linux-mtd@lists.infradead.org, ocfs2-devel@oss.oracle.com,
linux-ext4@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH v2 01/19] secretmem: Remove isolate_page
Date: Thu, 9 Jun 2022 14:46:11 +0200 [thread overview]
Message-ID: <c204c627-ec6b-cd8c-412d-57c8f55c61fa@redhat.com> (raw)
In-Reply-To: <20220608150249.3033815-2-willy@infradead.org>
On 08.06.22 17:02, Matthew Wilcox (Oracle) wrote:
> The isolate_page operation is never called for filesystems, only
> for device drivers which call SetPageMovable.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> mm/secretmem.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/mm/secretmem.c b/mm/secretmem.c
> index 206ed6b40c1d..1c7f1775b56e 100644
> --- a/mm/secretmem.c
> +++ b/mm/secretmem.c
> @@ -133,11 +133,6 @@ static const struct file_operations secretmem_fops = {
> .mmap = secretmem_mmap,
> };
>
> -static bool secretmem_isolate_page(struct page *page, isolate_mode_t mode)
> -{
> - return false;
> -}
> -
> static int secretmem_migratepage(struct address_space *mapping,
> struct page *newpage, struct page *page,
> enum migrate_mode mode)
> @@ -155,7 +150,6 @@ const struct address_space_operations secretmem_aops = {
> .dirty_folio = noop_dirty_folio,
> .free_folio = secretmem_free_folio,
> .migratepage = secretmem_migratepage,
> - .isolate_page = secretmem_isolate_page,
> };
>
> static int secretmem_setattr(struct user_namespace *mnt_userns,
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
next prev parent reply other threads:[~2022-06-09 12:46 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 15:02 [Ocfs2-devel] [PATCH v2 00/19] Convert aops->migratepage to aops->migrate_folio Matthew Wilcox (Oracle) via Ocfs2-devel
2022-06-08 15:02 ` [Ocfs2-devel] [PATCH v2 01/19] secretmem: Remove isolate_page Matthew Wilcox (Oracle) via Ocfs2-devel
2022-06-09 12:46 ` David Hildenbrand via Ocfs2-devel [this message]
2022-06-08 15:02 ` [Ocfs2-devel] [PATCH v2 02/19] mm: Convert all PageMovable users to movable_operations Matthew Wilcox (Oracle) via Ocfs2-devel
2022-06-09 10:23 ` David Hildenbrand via Ocfs2-devel
2022-06-08 15:02 ` [Ocfs2-devel] [PATCH v2 03/19] fs: Add aops->migrate_folio Matthew Wilcox (Oracle) via Ocfs2-devel
2022-06-09 12:50 ` David Hildenbrand via Ocfs2-devel
2022-06-09 14:35 ` Matthew Wilcox via Ocfs2-devel
2022-06-10 10:17 ` David Hildenbrand via Ocfs2-devel
2022-06-08 15:02 ` [Ocfs2-devel] [PATCH v2 04/19] mm/migrate: Convert fallback_migrate_page() to fallback_migrate_folio() Matthew Wilcox (Oracle) via Ocfs2-devel
2022-06-08 15:02 ` [Ocfs2-devel] [PATCH v2 05/19] mm/migrate: Convert writeout() to take a folio Matthew Wilcox (Oracle) via Ocfs2-devel
2022-06-08 15:02 ` [Ocfs2-devel] [PATCH v2 06/19] mm/migrate: Convert buffer_migrate_page() to buffer_migrate_folio() Matthew Wilcox (Oracle) via Ocfs2-devel
2022-06-08 15:02 ` [Ocfs2-devel] [PATCH v2 07/19] mm/migrate: Convert expected_page_refs() to folio_expected_refs() Matthew Wilcox (Oracle) via Ocfs2-devel
[not found] ` <6e7599d1-8a5f-bf16-383c-febd753bd051@google.com>
2022-07-08 3:29 ` Matthew Wilcox via Ocfs2-devel
2022-06-08 15:02 ` [Ocfs2-devel] [PATCH v2 08/19] btrfs: Convert btree_migratepage to migrate_folio Matthew Wilcox (Oracle) via Ocfs2-devel
2022-06-09 16:25 ` David Sterba via Ocfs2-devel
2022-06-08 15:02 ` [Ocfs2-devel] [PATCH v2 09/19] nfs: Convert " Matthew Wilcox (Oracle) via Ocfs2-devel
2022-06-08 15:02 ` [Ocfs2-devel] [PATCH v2 10/19] mm/migrate: Convert migrate_page() to migrate_folio() Matthew Wilcox (Oracle) via Ocfs2-devel
2022-06-09 16:26 ` David Sterba via Ocfs2-devel
2022-06-08 15:02 ` [Ocfs2-devel] [PATCH v2 11/19] mm/migrate: Add filemap_migrate_folio() Matthew Wilcox (Oracle) via Ocfs2-devel
2022-06-08 15:22 ` Darrick J. Wong via Ocfs2-devel
2022-06-08 15:02 ` [Ocfs2-devel] [PATCH v2 12/19] btrfs: Convert btrfs_migratepage to migrate_folio Matthew Wilcox (Oracle) via Ocfs2-devel
2022-06-09 16:33 ` David Sterba via Ocfs2-devel
2022-06-09 17:40 ` Matthew Wilcox via Ocfs2-devel
2022-06-09 23:05 ` David Sterba via Ocfs2-devel
2022-06-08 15:02 ` [Ocfs2-devel] [PATCH v2 13/19] ubifs: Convert to filemap_migrate_folio() Matthew Wilcox (Oracle) via Ocfs2-devel
2022-06-08 15:02 ` [Ocfs2-devel] [PATCH v2 14/19] f2fs: " Matthew Wilcox (Oracle) via Ocfs2-devel
2022-06-15 8:11 ` [Ocfs2-devel] [f2fs-dev] " Chao Yu via Ocfs2-devel
2022-06-08 15:02 ` [Ocfs2-devel] [PATCH v2 15/19] aio: Convert to migrate_folio Matthew Wilcox (Oracle) via Ocfs2-devel
2022-06-08 15:02 ` [Ocfs2-devel] [PATCH v2 16/19] hugetlb: " Matthew Wilcox (Oracle) via Ocfs2-devel
2022-06-08 15:02 ` [Ocfs2-devel] [PATCH v2 17/19] secretmem: " Matthew Wilcox (Oracle) via Ocfs2-devel
2022-06-08 15:02 ` [Ocfs2-devel] [PATCH v2 18/19] fs: Remove aops->migratepage() Matthew Wilcox (Oracle) via Ocfs2-devel
2022-06-08 15:02 ` [Ocfs2-devel] [PATCH v2 19/19] mm/folio-compat: Remove migration compatibility functions Matthew Wilcox (Oracle) via Ocfs2-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c204c627-ec6b-cd8c-412d-57c8f55c61fa@redhat.com \
--to=ocfs2-devel@oss.oracle.com \
--cc=cluster-devel@redhat.com \
--cc=david@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=linux-xfs@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).