From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
mark@fasheh.com, akpm <akpm@linux-foundation.org>
Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: remove unused function
Date: Wed, 14 Apr 2021 19:44:40 +0800 [thread overview]
Message-ID: <d5e3ba19-abac-891d-9e88-6d3a0cef931b@linux.alibaba.com> (raw)
In-Reply-To: <1618382761-5784-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On 4/14/21 2:46 PM, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> fs/ocfs2/dlm/dlmrecovery.c:129:20: warning: unused function
> 'dlm_reset_recovery' [-Wunused-function].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Seems after commit ded2cf71419b ("ocfs2: dlm: fix recovery hung"),
dlm_reset_recovery() no longer has any user.
Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/ocfs2/dlm/dlmrecovery.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
> index 4b566e8..afc5173 100644
> --- a/fs/ocfs2/dlm/dlmrecovery.c
> +++ b/fs/ocfs2/dlm/dlmrecovery.c
> @@ -126,13 +126,6 @@ static inline void __dlm_reset_recovery(struct dlm_ctxt *dlm)
> dlm_set_reco_master(dlm, O2NM_INVALID_NODE_NUM);
> }
>
> -static inline void dlm_reset_recovery(struct dlm_ctxt *dlm)
> -{
> - spin_lock(&dlm->spinlock);
> - __dlm_reset_recovery(dlm);
> - spin_unlock(&dlm->spinlock);
> -}
> -
> /* Worker function used during recovery. */
> void dlm_dispatch_work(struct work_struct *work)
> {
>
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
next prev parent reply other threads:[~2021-04-14 11:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 6:46 [Ocfs2-devel] [PATCH] ocfs2/dlm: remove unused function Jiapeng Chong
2021-04-14 11:44 ` Joseph Qi [this message]
2021-04-14 15:22 ` Wengang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5e3ba19-abac-891d-9e88-6d3a0cef931b@linux.alibaba.com \
--to=joseph.qi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).