From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5392366092415312359==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: arch/x86/kernel/cpu/sgx/virt.c:295:36: sparse: sparse: cast removes address space '__user' of expression Date: Sun, 05 Dec 2021 08:50:47 +0800 Message-ID: <202112050804.fLXTUZhm-lkp@intel.com> List-Id: --===============5392366092415312359== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: bbef3c7a63d2a4cb0f3f839db9e767f168c5e348 commit: d155030b1e7c0e448aab22a803f7a71ea2e117d7 x86/sgx: Add helpers to ex= pose ECREATE and EINIT to KVM date: 8 months ago config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/202112= 05/202112050804.fLXTUZhm-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.4-dirty # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi= t/commit/?id=3Dd155030b1e7c0e448aab22a803f7a71ea2e117d7 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/gi= t/torvalds/linux.git git fetch --no-tags linus master git checkout d155030b1e7c0e448aab22a803f7a71ea2e117d7 # save the config file to linux build tree mkdir build_dir make W=3D1 C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=3D= build_dir ARCH=3Dx86_64 SHELL=3D/bin/bash arch/x86/hyperv/ arch/x86/kernel/= cpu/sgx/ drivers/hv/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in = assignment (different base types) @@ expected int [assigned] ret @@ = got restricted vm_fault_t @@ arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: expected int [assigned= ] ret arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: got restricted vm_faul= t_t arch/x86/kernel/cpu/sgx/virt.c:60:20: sparse: sparse: restricted vm_faul= t_t degrades to integer arch/x86/kernel/cpu/sgx/virt.c:95:35: sparse: sparse: symbol 'sgx_vepc_v= m_ops' was not declared. Should it be static? >> arch/x86/kernel/cpu/sgx/virt.c:295:36: sparse: sparse: cast removes addr= ess space '__user' of expression arch/x86/kernel/cpu/sgx/virt.c:326:24: sparse: sparse: cast removes addr= ess space '__user' of expression arch/x86/kernel/cpu/sgx/virt.c:326:43: sparse: sparse: cast removes addr= ess space '__user' of expression arch/x86/kernel/cpu/sgx/virt.c:326:58: sparse: sparse: cast removes addr= ess space '__user' of expression vim +/__user +295 arch/x86/kernel/cpu/sgx/virt.c 260 = 261 /** 262 * sgx_virt_ecreate() - Run ECREATE on behalf of guest 263 * @pageinfo: Pointer to PAGEINFO structure 264 * @secs: Userspace pointer to SECS page 265 * @trapnr: trap number injected to guest in case of ECREATE error 266 * 267 * Run ECREATE on behalf of guest after KVM traps ECREATE for the pu= rpose 268 * of enforcing policies of guest's enclaves, and return the trap nu= mber 269 * which should be injected to guest in case of any ECREATE error. 270 * 271 * Return: 272 * - 0: ECREATE was successful. 273 * - <0: on error. 274 */ 275 int sgx_virt_ecreate(struct sgx_pageinfo *pageinfo, void __user *sec= s, 276 int *trapnr) 277 { 278 int ret; 279 = 280 /* 281 * @secs is an untrusted, userspace-provided address. It comes from 282 * KVM and is assumed to be a valid pointer which points somewhere = in 283 * userspace. This can fault and call SGX or other fault handlers = when 284 * userspace mapping @secs doesn't exist. 285 * 286 * Add a WARN() to make sure @secs is already valid userspace point= er 287 * from caller (KVM), who should already have handled invalid point= er 288 * case (for instance, made by malicious guest). All other checks, 289 * such as alignment of @secs, are deferred to ENCLS itself. 290 */ 291 if (WARN_ON_ONCE(!access_ok(secs, PAGE_SIZE))) 292 return -EINVAL; 293 = 294 __uaccess_begin(); > 295 ret =3D __ecreate(pageinfo, (void *)secs); 296 __uaccess_end(); 297 = 298 if (encls_faulted(ret)) { 299 *trapnr =3D ENCLS_TRAPNR(ret); 300 return -EFAULT; 301 } 302 = 303 /* ECREATE doesn't return an error code, it faults or succeeds. */ 304 WARN_ON_ONCE(ret); 305 return 0; 306 } 307 EXPORT_SYMBOL_GPL(sgx_virt_ecreate); 308 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============5392366092415312359==--