Re: [PATCH v2 6/9] cpu/SMT: Allow enabling partial SMT states via sysfs

[kernel test robot <lkp@intel.com>]

Hi Laurent,

kernel test robot noticed the following build errors:

[auto build test ERROR on powerpc/next]
[also build test ERROR on powerpc/fixes tip/x86/core v6.4]
[cannot apply to tip/smp/core linus/master next-20230628]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Laurent-Dufour/cpu-SMT-Move-SMT-prototypes-into-cpu_smt-h/20230628-181323
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link:    https://lore.kernel.org/r/20230628100558.43482-7-ldufour%40linux.ibm.com
patch subject: [PATCH v2 6/9] cpu/SMT: Allow enabling partial SMT states via sysfs
config: arm-randconfig-r025-20230628 (https://download.01.org/0day-ci/archive/20230628/202306282340.Ihqm0fLA-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce: (https://download.01.org/0day-ci/archive/20230628/202306282340.Ihqm0fLA-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306282340.Ihqm0fLA-lkp@intel.com/

All errors (new ones prefixed by >>):

>> kernel/cpu.c:2606:29: error: use of undeclared identifier 'cpu_smt_max_threads'; did you mean 'sysctl_max_threads'?
    2606 |             cpu_smt_num_threads != cpu_smt_max_threads)
         |                                    ^~~~~~~~~~~~~~~~~~~
         |                                    sysctl_max_threads
   include/linux/compiler.h:56:47: note: expanded from macro 'if'
      56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
         |                                               ^
   include/linux/compiler.h:58:52: note: expanded from macro '__trace_if_var'
      58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
         |                                                    ^
   include/linux/sysctl.h:294:5: note: 'sysctl_max_threads' declared here
     294 | int sysctl_max_threads(struct ctl_table *table, int write, void *buffer,
         |     ^
>> kernel/cpu.c:2606:29: error: use of undeclared identifier 'cpu_smt_max_threads'; did you mean 'sysctl_max_threads'?
    2606 |             cpu_smt_num_threads != cpu_smt_max_threads)
         |                                    ^~~~~~~~~~~~~~~~~~~
         |                                    sysctl_max_threads
   include/linux/compiler.h:56:47: note: expanded from macro 'if'
      56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
         |                                               ^
   include/linux/compiler.h:58:61: note: expanded from macro '__trace_if_var'
      58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
         |                                                             ^
   include/linux/sysctl.h:294:5: note: 'sysctl_max_threads' declared here
     294 | int sysctl_max_threads(struct ctl_table *table, int write, void *buffer,
         |     ^
>> kernel/cpu.c:2606:29: error: use of undeclared identifier 'cpu_smt_max_threads'; did you mean 'sysctl_max_threads'?
    2606 |             cpu_smt_num_threads != cpu_smt_max_threads)
         |                                    ^~~~~~~~~~~~~~~~~~~
         |                                    sysctl_max_threads
   include/linux/compiler.h:56:47: note: expanded from macro 'if'
      56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
         |                                               ^
   include/linux/compiler.h:58:86: note: expanded from macro '__trace_if_var'
      58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
         |                                                                                      ^
   include/linux/compiler.h:69:3: note: expanded from macro '__trace_if_value'
      69 |         (cond) ?                                        \
         |          ^
   include/linux/sysctl.h:294:5: note: 'sysctl_max_threads' declared here
     294 | int sysctl_max_threads(struct ctl_table *table, int write, void *buffer,
         |     ^
   3 errors generated.


vim +2606 kernel/cpu.c

  2594	
  2595	static ssize_t control_show(struct device *dev,
  2596				    struct device_attribute *attr, char *buf)
  2597	{
  2598		const char *state = smt_states[cpu_smt_control];
  2599	
  2600		/*
  2601		 * If SMT is enabled but not all threads are enabled then show the
  2602		 * number of threads. If all threads are enabled show "on". Otherwise
  2603		 * show the state name.
  2604		 */
  2605		if (cpu_smt_control == CPU_SMT_ENABLED &&
> 2606		    cpu_smt_num_threads != cpu_smt_max_threads)
  2607			return sysfs_emit(buf, "%d\n", cpu_smt_num_threads);
  2608	
  2609		return snprintf(buf, PAGE_SIZE - 2, "%s\n", state);
  2610	}
  2611	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki