oe-kbuild-all.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev,
	Linux Memory Management List <linux-mm@kvack.org>,
	Steve French <stfrench@microsoft.com>
Subject: [linux-next:master 10809/11214] fs/smb/server/smb2pdu.c:4149: warning: Excess function parameter 'infoclass_size' description in 'buffer_check_err'
Date: Tue, 22 Aug 2023 01:43:35 +0800	[thread overview]
Message-ID: <202308220116.C2UzYhrZ-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   47d9bb711707d15b19fad18c8e2b4b027a264a3a
commit: 6b26a13565d05a90d3b84267359750ab6c4c6d5a [10809/11214] ksmbd: add support for read compound
config: riscv-allmodconfig (https://download.01.org/0day-ci/archive/20230822/202308220116.C2UzYhrZ-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230822/202308220116.C2UzYhrZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308220116.C2UzYhrZ-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/smb/server/smb2pdu.c:4149: warning: Excess function parameter 'infoclass_size' description in 'buffer_check_err'


vim +4149 fs/smb/server/smb2pdu.c

e2f34481b24db2 fs/cifsd/smb2pdu.c      Namjae Jeon 2021-03-16  4136  
e2f34481b24db2 fs/cifsd/smb2pdu.c      Namjae Jeon 2021-03-16  4137  /**
e2f34481b24db2 fs/cifsd/smb2pdu.c      Namjae Jeon 2021-03-16  4138   * buffer_check_err() - helper function to check buffer errors
e2f34481b24db2 fs/cifsd/smb2pdu.c      Namjae Jeon 2021-03-16  4139   * @reqOutputBufferLength:	max buffer length expected in command response
e2f34481b24db2 fs/cifsd/smb2pdu.c      Namjae Jeon 2021-03-16  4140   * @rsp:		query info response buffer contains output buffer length
e230d013378489 fs/ksmbd/smb2pdu.c      Yang Li     2021-12-21  4141   * @rsp_org:		base response buffer pointer in case of chained response
e2f34481b24db2 fs/cifsd/smb2pdu.c      Namjae Jeon 2021-03-16  4142   * @infoclass_size:	query info class response buffer size
e2f34481b24db2 fs/cifsd/smb2pdu.c      Namjae Jeon 2021-03-16  4143   *
e2f34481b24db2 fs/cifsd/smb2pdu.c      Namjae Jeon 2021-03-16  4144   * Return:	0 on success, otherwise error
e2f34481b24db2 fs/cifsd/smb2pdu.c      Namjae Jeon 2021-03-16  4145   */
e2f34481b24db2 fs/cifsd/smb2pdu.c      Namjae Jeon 2021-03-16  4146  static int buffer_check_err(int reqOutputBufferLength,
cb4517201b8acd fs/ksmbd/smb2pdu.c      Namjae Jeon 2021-11-03  4147  			    struct smb2_query_info_rsp *rsp,
6b26a13565d05a fs/smb/server/smb2pdu.c Namjae Jeon 2023-08-11  4148  			    void *rsp_org)
e2f34481b24db2 fs/cifsd/smb2pdu.c      Namjae Jeon 2021-03-16 @4149  {
e2f34481b24db2 fs/cifsd/smb2pdu.c      Namjae Jeon 2021-03-16  4150  	if (reqOutputBufferLength < le32_to_cpu(rsp->OutputBufferLength)) {
bde1694aecdb53 fs/cifsd/smb2pdu.c      Namjae Jeon 2021-06-28  4151  		pr_err("Invalid Buffer Size Requested\n");
e2f34481b24db2 fs/cifsd/smb2pdu.c      Namjae Jeon 2021-03-16  4152  		rsp->hdr.Status = STATUS_INFO_LENGTH_MISMATCH;
cb4517201b8acd fs/ksmbd/smb2pdu.c      Namjae Jeon 2021-11-03  4153  		*(__be32 *)rsp_org = cpu_to_be32(sizeof(struct smb2_hdr));
e2f34481b24db2 fs/cifsd/smb2pdu.c      Namjae Jeon 2021-03-16  4154  		return -EINVAL;
e2f34481b24db2 fs/cifsd/smb2pdu.c      Namjae Jeon 2021-03-16  4155  	}
e2f34481b24db2 fs/cifsd/smb2pdu.c      Namjae Jeon 2021-03-16  4156  	return 0;
e2f34481b24db2 fs/cifsd/smb2pdu.c      Namjae Jeon 2021-03-16  4157  }
e2f34481b24db2 fs/cifsd/smb2pdu.c      Namjae Jeon 2021-03-16  4158  

:::::: The code at line 4149 was first introduced by commit
:::::: e2f34481b24db2fd634b5edb0a5bd0e4d38cc6e9 cifsd: add server-side procedures for SMB3

:::::: TO: Namjae Jeon <namjae.jeon@samsung.com>
:::::: CC: Steve French <stfrench@microsoft.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2023-08-21 17:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202308220116.C2UzYhrZ-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=linkinjeon@kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=stfrench@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).