From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72EF7273F6 for ; Thu, 12 Oct 2023 13:01:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WmTL1D1q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697115667; x=1728651667; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HlI9nRmiOWzTgfw2KPSLAj7uKfHlFCqpVjECnsGmXrU=; b=WmTL1D1q46Wo4vn3dQANzJImjjuDEI+zsPV6byTSvZvsGwNScN1M01ib IxkKrcpMh5aQrtCoL3Xr5hMZsQPXlqE19sgGfS5yshJqQJeyCuOVPptSA ICVEl3sPR6x5uJJYXc5dW9v+hTjjYTByf1EJdq5KKif9PgZsnM9NCyUBH mltjA/vBb+GT2YQ453DxjULSU6j+0sJ7xUEkjwLEtFDBQCuMzWdjAnvrA zPqWKFlFob3dK2WykwnQA7YZYFQKT3cH2pBhXJt6DOa0NWLxrm0/kSZG+ 21uXK2fpParlIwiurobO0EaalUxKj3O4sHoJSAzrAXLxd6zwRYdcYRNP+ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10861"; a="369977415" X-IronPort-AV: E=Sophos;i="6.03,219,1694761200"; d="scan'208";a="369977415" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2023 06:01:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10861"; a="704150482" X-IronPort-AV: E=Sophos;i="6.03,219,1694761200"; d="scan'208";a="704150482" Received: from lkp-server02.sh.intel.com (HELO f64821696465) ([10.239.97.151]) by orsmga003.jf.intel.com with ESMTP; 12 Oct 2023 06:01:02 -0700 Received: from kbuild by f64821696465 with local (Exim 4.96) (envelope-from ) id 1qqvJE-0003SR-0c; Thu, 12 Oct 2023 13:01:00 +0000 Date: Thu, 12 Oct 2023 21:00:03 +0800 From: kernel test robot To: Werner Sembach , Pavel Machek , Lee Jones Cc: oe-kbuild-all@lists.linux.dev, Werner Sembach , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH] leds: rgb: Implement per-key keyboard backlight for several TUXEDO devices Message-ID: <202310122012.C2mSREZ7-lkp@intel.com> References: <20231011190017.1230898-1-wse@tuxedocomputers.com> Precedence: bulk X-Mailing-List: oe-kbuild-all@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231011190017.1230898-1-wse@tuxedocomputers.com> Hi Werner, kernel test robot noticed the following build warnings: [auto build test WARNING on lee-leds/for-leds-next] [also build test WARNING on linus/master v6.6-rc5 next-20231012] [cannot apply to pavel-leds/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Werner-Sembach/leds-rgb-Implement-per-key-keyboard-backlight-for-several-TUXEDO-devices/20231012-030206 base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next patch link: https://lore.kernel.org/r/20231011190017.1230898-1-wse%40tuxedocomputers.com patch subject: [PATCH] leds: rgb: Implement per-key keyboard backlight for several TUXEDO devices config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20231012/202310122012.C2mSREZ7-lkp@intel.com/config) compiler: sparc64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231012/202310122012.C2mSREZ7-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202310122012.C2mSREZ7-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/leds/rgb/leds-tuxedo-ite8291.c:44: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Set color for specified [row, column] in row based data structure drivers/leds/rgb/leds-tuxedo-ite8291.c:79: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Just a generic helper function to reduce boilerplate code drivers/leds/rgb/leds-tuxedo-ite8291.c:96: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Update brightness of the whole keyboard. Only used for initialization as this doesn't allow per drivers/leds/rgb/leds-tuxedo-ite8291.c:116: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Update color of a singular row from row_data. This is the smallest unit this device allows to drivers/leds/rgb/leds-tuxedo-ite8291.c:138: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Write color and brightness to the whole keyboard from row data. Note that per key brightness is vim +44 drivers/leds/rgb/leds-tuxedo-ite8291.c 42 43 /** > 44 * Set color for specified [row, column] in row based data structure 45 * 46 * @param row_data Data structure to fill 47 * @param row Row number 0 - 5 48 * @param column Column number 0 - 20 49 * @param red Red brightness 0x00 - 0xff 50 * @param green Green brightness 0x00 - 0xff 51 * @param blue Blue brightness 0x00 - 0xff 52 * 53 * @returns 0 on success, otherwise error 54 */ 55 static int leds_tuxedo_ite8291_set_row_data(row_data_t row_data, int row, int column, 56 u8 red, u8 green, u8 blue) 57 { 58 int column_index_red, column_index_green, column_index_blue; 59 60 if (row < 0 || row >= LEDS_TUXEDO_ITE8291_ROWS || 61 column < 0 || column >= LEDS_TUXEDO_ITE8291_COLUMNS) 62 return -EINVAL; 63 64 column_index_red = 65 LEDS_TUXEDO_ITE8291_ROW_DATA_PADDING + (2 * LEDS_TUXEDO_ITE8291_COLUMNS) + column; 66 column_index_green = 67 LEDS_TUXEDO_ITE8291_ROW_DATA_PADDING + (1 * LEDS_TUXEDO_ITE8291_COLUMNS) + column; 68 column_index_blue = 69 LEDS_TUXEDO_ITE8291_ROW_DATA_PADDING + (0 * LEDS_TUXEDO_ITE8291_COLUMNS) + column; 70 71 row_data[row][column_index_red] = red; 72 row_data[row][column_index_green] = green; 73 row_data[row][column_index_blue] = blue; 74 75 return 0; 76 } 77 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki