From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A9927E6 for ; Thu, 9 Mar 2023 06:09:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4996BC433D2; Thu, 9 Mar 2023 06:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678342184; bh=5xaZPSrXO3U+lnq1ejULQspngVs5//pV+SuM6vGjaFE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LrcBPL3Mk6HmCfgRzPaHNq2HQ6p3Bz5ey0FyJo+jpb9KviuL08qJcagTF4AtdQ5Wo y+cCqUOrozOYIA/jPNLNsYDmDltlUFFHkH0qEasfY/A4kBN+83ry3hRnnbpd5sRGZr 88jguB2E8ndyl9UqtDuyRSD4WaAOOkgzRqU/1YIWNrzvwCxSKK1CWu30awQhjTjzqP T3JEqwL4znnPzb41rBdFFm3p27lE9uu9mkFLUY1ZtbjoBlouq2uZye7s8z/e5zA6eT L5I0ZJGarkn2RrPe1CFwH5QOlfl1lXDVRr3H5S/IYvQ2BYmCtshKx5+vM9DSo1Tm+5 9f/72Vd1Ag+Ng== Message-ID: <6180156d-109c-2f41-69ee-0a854dc3772e@kernel.org> Date: Thu, 9 Mar 2023 07:09:38 +0100 Precedence: bulk X-Mailing-List: oe-kbuild-all@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v13 2/2] clk: clk-loongson2: add clock controller driver support Content-Language: en-US To: zhuyinbo , kernel test robot , Michael Turquette , Stephen Boyd , Rob Herring , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, Jianmin Lv , Liu Peibao , wanghongliang@loongson.cn, loongson-kernel@lists.loongnix.cn References: <20230307115022.12846-2-zhuyinbo@loongson.cn> <202303082037.QPfBP64A-lkp@intel.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 09/03/2023 04:18, zhuyinbo wrote: > > 在 2023/3/9 上午10:58, zhuyinbo 写道: >> >> 在 2023/3/8 下午8:16, kernel test robot 写道: >>> Hi Yinbo, >>> >>> I love your patch! Yet something to improve: >>> >>> [auto build test ERROR on clk/clk-next] >>> [also build test ERROR on robh/for-next linus/master v6.3-rc1 >>> next-20230308] >>> [If your patch is applied to the wrong git tree, kindly drop us a note. >>> And when submitting patch, we suggest to use '--base' as documented in >>> https://git-scm.com/docs/git-format-patch#_base_tree_information] >>> >>> url: >>> https://github.com/intel-lab-lkp/linux/commits/Yinbo-Zhu/clk-clk-loongson2-add-clock-controller-driver-support/20230307-195252 >>> base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git >>> clk-next >>> patch link: >>> https://lore.kernel.org/r/20230307115022.12846-2-zhuyinbo%40loongson.cn >>> patch subject: [PATCH v13 2/2] clk: clk-loongson2: add clock >>> controller driver support >>> config: mips-allyesconfig >>> (https://download.01.org/0day-ci/archive/20230308/202303082037.QPfBP64A-lkp@intel.com/config) >>> compiler: mips-linux-gcc (GCC) 12.1.0 >>> reproduce (this is a W=1 build): >>>          wget >>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross >>> -O ~/bin/make.cross >>>          chmod +x ~/bin/make.cross >>>          # >>> https://github.com/intel-lab-lkp/linux/commit/391d6fc63ac65f5456e4755c9dd85232a6296285 >>>          git remote add linux-review >>> https://github.com/intel-lab-lkp/linux >>>          git fetch --no-tags linux-review >>> Yinbo-Zhu/clk-clk-loongson2-add-clock-controller-driver-support/20230307-195252 >>>          git checkout 391d6fc63ac65f5456e4755c9dd85232a6296285 >>>          # save the config file >>>          mkdir build_dir && cp config build_dir/.config >>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 >>> make.cross W=1 O=build_dir ARCH=mips olddefconfig >>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 >>> make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/ >>> >>> If you fix the issue, kindly add following tag where applicable >>> | Reported-by: kernel test robot >>> | Link: >>> https://lore.kernel.org/oe-kbuild-all/202303082037.QPfBP64A-lkp@intel.com/ >>> >>> All errors (new ones prefixed by >>): >>> >>>     drivers/clk/clk-loongson2.c: In function 'loongson2_calc_pll_rate': >>>>> drivers/clk/clk-loongson2.c:79:15: error: implicit declaration of >>>>> function 'readq'; did you mean 'readl'? >>>>> [-Werror=implicit-function-declaration] >>>        79 |         val = readq(loongson2_pll_base + offset); >>>           |               ^~~~~ >>>           |               readl >>>     cc1: some warnings being treated as errors >> >> The CONFIG_64BIT not enabled in your config file, I will add a depend >> on "CONFIG_64BIT" in my clock driver to fix this compile error. > My clock is for LoongArch platform, The LOONGARCH had select > "CONFIG_64BIT", I will add a depend on "LOONGARCH" in my clock driver to > fix this compile error. No. Fix your code instead. Best regards, Krzysztof