oe-kbuild.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* fs/hugetlbfs/inode.c:381:38: warning: Parameter 'page' can be declared as pointer to const [constParameter]
@ 2022-11-18 21:44 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-11-18 21:44 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp

:::::: 
:::::: Manual check reason: "low confidence static check warning: fs/hugetlbfs/inode.c:381:38: warning: Parameter 'page' can be declared as pointer to const [constParameter]"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Mike Kravetz <mike.kravetz@oracle.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
CC: Miaohe Lin <linmiaohe@huawei.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   950a9f564aeade8f7b263bb8e9646c4c13ffd424
commit: 378397ccb8e5a695a42e819df545ccd28641b683 hugetlb: create hugetlb_unmap_file_folio to unmap single file folio
date:   7 weeks ago
:::::: branch date: 2 hours ago
:::::: commit date: 7 weeks ago
compiler: mips64-linux-gcc (GCC) 12.1.0
reproduce (cppcheck warning):
        # apt-get install cppcheck
        git checkout 378397ccb8e5a695a42e819df545ccd28641b683
        cppcheck --quiet --enable=style,performance,portability --template=gcc FILE

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> fs/hugetlbfs/inode.c:381:38: warning: Parameter 'page' can be declared as pointer to const [constParameter]
       unsigned long addr, struct page *page)
                                        ^

vim +/page +381 fs/hugetlbfs/inode.c

^1da177e4c3f41 Linus Torvalds 2005-04-16  373  
378397ccb8e5a6 Mike Kravetz   2022-09-14  374  /*
378397ccb8e5a6 Mike Kravetz   2022-09-14  375   * Called with i_mmap_rwsem held for inode based vma maps.  This makes
378397ccb8e5a6 Mike Kravetz   2022-09-14  376   * sure vma (and vm_mm) will not go away.  We also hold the hugetlb fault
378397ccb8e5a6 Mike Kravetz   2022-09-14  377   * mutex for the page in the mapping.  So, we can not race with page being
378397ccb8e5a6 Mike Kravetz   2022-09-14  378   * faulted into the vma.
378397ccb8e5a6 Mike Kravetz   2022-09-14  379   */
378397ccb8e5a6 Mike Kravetz   2022-09-14  380  static bool hugetlb_vma_maps_page(struct vm_area_struct *vma,
378397ccb8e5a6 Mike Kravetz   2022-09-14 @381  				unsigned long addr, struct page *page)
378397ccb8e5a6 Mike Kravetz   2022-09-14  382  {
378397ccb8e5a6 Mike Kravetz   2022-09-14  383  	pte_t *ptep, pte;
378397ccb8e5a6 Mike Kravetz   2022-09-14  384  
378397ccb8e5a6 Mike Kravetz   2022-09-14  385  	ptep = huge_pte_offset(vma->vm_mm, addr,
378397ccb8e5a6 Mike Kravetz   2022-09-14  386  			huge_page_size(hstate_vma(vma)));
378397ccb8e5a6 Mike Kravetz   2022-09-14  387  
378397ccb8e5a6 Mike Kravetz   2022-09-14  388  	if (!ptep)
378397ccb8e5a6 Mike Kravetz   2022-09-14  389  		return false;
378397ccb8e5a6 Mike Kravetz   2022-09-14  390  
378397ccb8e5a6 Mike Kravetz   2022-09-14  391  	pte = huge_ptep_get(ptep);
378397ccb8e5a6 Mike Kravetz   2022-09-14  392  	if (huge_pte_none(pte) || !pte_present(pte))
378397ccb8e5a6 Mike Kravetz   2022-09-14  393  		return false;
378397ccb8e5a6 Mike Kravetz   2022-09-14  394  
378397ccb8e5a6 Mike Kravetz   2022-09-14  395  	if (pte_page(pte) == page)
378397ccb8e5a6 Mike Kravetz   2022-09-14  396  		return true;
378397ccb8e5a6 Mike Kravetz   2022-09-14  397  
378397ccb8e5a6 Mike Kravetz   2022-09-14  398  	return false;
378397ccb8e5a6 Mike Kravetz   2022-09-14  399  }
378397ccb8e5a6 Mike Kravetz   2022-09-14  400  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-11-18 21:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-18 21:44 fs/hugetlbfs/inode.c:381:38: warning: Parameter 'page' can be declared as pointer to const [constParameter] kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).