From: Mark Greer <mgreer@animalcreek.com>
To: linux-nfc@lists.01.org
Subject: Re: [PATCH] [neard][RFC] test: Convert Python2 scripts to Python3
Date: Sun, 28 Nov 2021 21:15:36 -0700 [thread overview]
Message-ID: <20211129041536.GA830560@animalcreek.com> (raw)
In-Reply-To: <65c7b6ca-c1f6-6557-1b54-f8f666e3a5bf@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 7003 bytes --]
On Mon, Aug 09, 2021 at 12:35:07PM +0200, Krzysztof Kozlowski wrote:
> On 08/08/2021 04:20, Mark Greer wrote:
> > Python2 is deprecated so convert the neard test scripts, which are
> > Python2, to Python3.
> >
> > Signed-off-by: Mark Greer <mgreer@animalcreek.com>
> > ---
> > This is a first pass at converting the python scripts to Python3.
> > Not a lot of testing yet. It appears that the 'gobject' is not
> > available anymore so I have to look into how to rework the code that
> > uses it.
> >
> > I would appreciate any testing that you are willing to provide.
> >
> > Also available at:
> > https://github.com/linux-nfc/neard/tree/mag/python3-ize
> >
> > se/test/test-channel | 18 +++++------
> > se/test/test-seel | 38 +++++++++++-----------
> > test/bt-handover | 8 ++---
> > test/handover-agent | 34 +++++++++----------
> > test/monitor-near | 8 ++---
> > test/ndef-agent | 20 ++++++------
> > test/neard-ui.py | 70 ++++++++++++++++++++--------------------
> > test/neardutils.py | 14 ++++----
> > test/phdc-simple-manager | 50 ++++++++++++++--------------
> > test/test-adapter | 16 ++++-----
> > test/test-device | 34 +++++++++----------
> > test/test-tag | 10 +++---
> > 12 files changed, 160 insertions(+), 160 deletions(-)
> >
>
> Few tests:
> ------------
> $ sudo python3 ./test/test-adapter poll nfc0 on
> Traceback (most recent call last):
> File "./test/test-adapter", line 92, in <module>
> adapter.StartPollLoop(mode)
> File "/usr/lib/python3/dist-packages/dbus/proxies.py", line 72, in
> __call__
> return self._proxy_method(*args, **keywords)
> File "/usr/lib/python3/dist-packages/dbus/proxies.py", line 141, in
> __call__
> return self._connection.call_blocking(self._named_service,
> File "/usr/lib/python3/dist-packages/dbus/connection.py", line 652, in
> call_blocking
> reply_message = self.send_message_with_reply_and_block(
> dbus.exceptions.DBusException: org.neard.Error.Failed: No such device
>
> During handling of the above exception, another exception occurred:
>
> Traceback (most recent call last):
> File "./test/test-adapter", line 94, in <module>
> print("%s: %s" % (error._dbus_error_name, error.message))
> AttributeError: 'DBusException' object has no attribute 'message'
> ------------
This looks like you may not have installed the necessary dbus support
(e.g., src/org.neard.conf). After building neard, you can install this
with:
$ sudo make install
If that isn't it, I'll need more info about your environment because I
don't get those errors. To make sure we're on the same page, these steps
should get you going (this example on an amd64 running Ubuntu 20.04):
$ ./bootstrap-configure
$ make
$ sudo make install
<now insert your nfc hardware (a pn533 in this case)>
$ test/test-adapter list # no need for sudo
[ /org/neard/nfc0 ]
Protocols = [ Felica MIFARE Jewel ISO-DEP NFC-DEP ]
Mode = Idle
Polling = false
Powered = false
$ test/test-adapter powered nfc0 on
$ test/test-adapter list
[ /org/neard/nfc0 ]
Protocols = [ Felica MIFARE Jewel ISO-DEP NFC-DEP ]
Mode = Idle
Polling = false
Powered = true
$ test/test-adapter poll nfc0 on Initiator
$ test/test-adapter list
[ /org/neard/nfc0 ]
Protocols = [ Felica MIFARE Jewel ISO-DEP NFC-DEP ]
Mode = Idle
Polling = true
Powered = true
<now more a tag within range>
$ test/test-adapter list
[ /org/neard/nfc0 ]
Protocols = [ Felica MIFARE Jewel ISO-DEP NFC-DEP ]
Mode = Initiator
Polling = false
Powered = true
$ test/test-tag list
[ /org/neard/nfc0/tag0 ]
Protocol = MIFARE
ReadOnly = false
Type = Type 2
Adapter = /org/neard/nfc0
$ test/test-tag write /org/neard/nfc0/tag0 Text UTF-8 en-US "Hello World"
$ test/test-tag dump
[ /org/neard/nfc0/tag0 ]
[ /org/neard/nfc0/tag0/record1 ]
Representation = Hello World
Type = Text
Language = en-US
Encoding = UTF-8
<move tag out of range>
$ test/test-tag dump
$ test/test-tag list
$ test/test-adapter list
[ /org/neard/nfc0 ]
Protocols = [ Felica MIFARE Jewel ISO-DEP NFC-DEP ]
Mode = Idle
Polling = false
Powered = true
<you have to poll again to read/write again and it should be called nfc1>
> Others:
> ------------
> sudo python3 ./test/test-device
> File "./test/test-device", line 76
> usage()
> ^
> TabError: inconsistent use of tabs and spaces in indentation
> ------------
> sudo python3 ./test/phdc-simple-manager
> File "./test/phdc-simple-manager", line 60
> print('Init PhdcPeerManager thread')
> ^
> TabError: inconsistent use of tabs and spaces in indentation
> ------------
Not a py3-specific issue but I will fix this and other formatting issues.
> > diff --git a/test/neard-ui.py b/test/neard-ui.py
> > index cf4bb13c5155..91f8e6bbaa6a 100755
> > --- a/test/neard-ui.py
> > +++ b/test/neard-ui.py
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/env python
> > +#!/usr/bin/env python3
> >
> > import pdb
> > import sys
> > @@ -18,12 +18,12 @@ import neardutils
> > class Neard:
> >
> > def interface_Added(self, path, interface):
> > - print (" New interface added: %s") % path
> > + print((" New interface added: %s") % path)
>
>
> Instead:
> print(" New interface added: %s" % path)
Will fix all of these.
> > @@ -42,7 +42,7 @@ class Neard:
> > dbus_interface="org.freedesktop.DBus.ObjectManager",
> > signal_name="InterfacesRemoved")
> > except:
> > - print ("Can't connect to org.freedesktop.DBus.ObjectManager");
> > + print(("Can't connect to org.freedesktop.DBus.ObjectManager"));
>
> Double ((
Will fix all of these.
> > @@ -57,26 +57,26 @@ def quotechars( chars ):
> > class PhdcPeerManager:
> > def __init__(self, agent_fd):
> > #Grab the agent ....
> > - print 'Init PhdcPeerManager thread'
> > + print('Init PhdcPeerManager thread')
> > self.r_fd = agent_fd.take()
> > - print 'Agent fd:', str(self.r_fd)
> > + print('Agent fd:', str(self.r_fd))
> >
> > def run( self):
> > - print 'Run PhdcPeerManager thread: ', str(self.r_fd)
> > + print('Run PhdcPeerManager thread: ', str(self.r_fd))
> > self.sock = socket.fromfd(self.r_fd, AF_NFC, socket.SOCK_STREAM)
> > try:
> > while True:
> > miu = self.sock.getsockopt(SOL_NFC, NFC_LLCP_MIUX)
> > - print 'MIU=', miu
> > + print('MIU=', miu)
>
> Mixed up indentation but I guess the issue was here before.
Looks like an artifact of tabs vs. spaces. I'll fix that and other
formatting issues.
> Best regards,
> Krzysztof
Thanks for the review.
Mark
--
next prev parent reply other threads:[~2021-11-29 4:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-08 2:20 [PATCH] [neard][RFC] test: Convert Python2 scripts to Python3 Mark Greer
2021-08-08 2:22 ` Mark Greer
2021-08-09 10:35 ` Krzysztof Kozlowski
2021-08-20 15:33 ` Mark Greer
2021-11-29 4:15 ` Mark Greer [this message]
2021-12-01 8:53 ` Krzysztof Kozlowski
2021-12-06 17:17 ` Mark Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211129041536.GA830560@animalcreek.com \
--to=mgreer@animalcreek.com \
--cc=linux-nfc@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).