From: Shakeel Butt <shakeelb@google.com>
To: lkp@lists.01.org
Subject: Re: [PATCH 2/3] mm: page_counter: rearrange struct page_counter fields
Date: Sun, 21 Aug 2022 21:55:28 -0700 [thread overview]
Message-ID: <CALvZod4r5_vcL4ZcSpR_DdLc_2sppnPTv1DXmFchCULWLu3Riw@mail.gmail.com> (raw)
In-Reply-To: <CACSApvYU5gfbDv9dyaypu1oOPB58eT1inX9EX6gV5b2q3+qr6Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]
On Sun, Aug 21, 2022 at 5:24 PM Soheil Hassas Yeganeh <soheil@google.com> wrote:
>
> On Sun, Aug 21, 2022 at 8:18 PM Shakeel Butt <shakeelb@google.com> wrote:
> >
> > With memcg v2 enabled, memcg->memory.usage is a very hot member for
> > the workloads doing memcg charging on multiple CPUs concurrently.
> > Particularly the network intensive workloads. In addition, there is a
> > false cache sharing between memory.usage and memory.high on the charge
> > path. This patch moves the usage into a separate cacheline and move all
> > the read most fields into separate cacheline.
> >
> > To evaluate the impact of this optimization, on a 72 CPUs machine, we
> > ran the following workload in a three level of cgroup hierarchy with top
> > level having min and low setup appropriately. More specifically
> > memory.min equal to size of netperf binary and memory.low double of
> > that.
> >
> > $ netserver -6
> > # 36 instances of netperf with following params
> > $ netperf -6 -H ::1 -l 60 -t TCP_SENDFILE -- -m 10K
> >
> > Results (average throughput of netperf):
> > Without (6.0-rc1) 10482.7 Mbps
> > With patch 12413.7 Mbps (18.4% improvement)
> >
> > With the patch, the throughput improved by 18.4%.
>
> Shakeel, for my understanding: is this on top of the gains from the
> previous patch?
>
No, this is independent of the previous patch. The cover letter has
the numbers for all three optimizations applied together.
next prev parent reply other threads:[~2022-08-22 4:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 0:17 [PATCH 0/3] memcg: optimizatize charge codepath Shakeel Butt
2022-08-22 0:17 ` [PATCH 1/3] mm: page_counter: remove unneeded atomic ops for low/min Shakeel Butt
2022-08-22 0:20 ` Soheil Hassas Yeganeh
2022-08-22 2:39 ` Feng Tang
2022-08-22 9:55 ` Michal Hocko
2022-08-22 10:18 ` Michal Hocko
2022-08-22 14:55 ` Shakeel Butt
2022-08-22 15:20 ` Michal Hocko
2022-08-22 16:06 ` Shakeel Butt
2022-08-23 9:42 ` Michal Hocko
2022-08-22 18:23 ` Roman Gushchin
2022-08-22 0:17 ` [PATCH 2/3] mm: page_counter: rearrange struct page_counter fields Shakeel Butt
2022-08-22 0:24 ` Soheil Hassas Yeganeh
2022-08-22 4:55 ` Shakeel Butt [this message]
2022-08-22 13:06 ` Soheil Hassas Yeganeh
2022-08-22 2:10 ` Feng Tang
2022-08-22 4:59 ` Shakeel Butt
2022-08-22 10:23 ` Michal Hocko
2022-08-22 15:06 ` Shakeel Butt
2022-08-22 15:15 ` Michal Hocko
2022-08-22 16:04 ` Shakeel Butt
2022-08-22 18:27 ` Roman Gushchin
2022-08-22 0:17 ` [PATCH 3/3] memcg: increase MEMCG_CHARGE_BATCH to 64 Shakeel Butt
2022-08-22 0:24 ` Soheil Hassas Yeganeh
2022-08-22 2:30 ` Feng Tang
2022-08-22 10:47 ` Michal Hocko
2022-08-22 15:09 ` Shakeel Butt
2022-08-22 15:22 ` Michal Hocko
2022-08-22 16:07 ` Shakeel Butt
2022-08-22 18:37 ` Roman Gushchin
2022-08-22 19:34 ` Michal Hocko
2022-08-23 2:22 ` Roman Gushchin
2022-08-23 4:49 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALvZod4r5_vcL4ZcSpR_DdLc_2sppnPTv1DXmFchCULWLu3Riw@mail.gmail.com \
--to=shakeelb@google.com \
--cc=lkp@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).