From: Yury Norov <yury.norov@gmail.com>
To: lkp@lists.01.org
Subject: Re: [oliver.sang@intel.com: [cpumask] b9a7ecc71f: WARNING:at_include/linux/cpumask.h:#__is_kernel_percpu_address]
Date: Sat, 01 Oct 2022 10:16:36 -0700 [thread overview]
Message-ID: <Yzh19JhBMzkMr4+L@yury-laptop> (raw)
In-Reply-To: <CAHk-=wiK5wyj58x3uvt+otsO9=79N13OO6Nf57DFVYO=QX==ig@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]
On Sat, Oct 01, 2022 at 09:20:53AM -0700, Linus Torvalds wrote:
> On Fri, Sep 30, 2022 at 6:51 PM Yury Norov <yury.norov@gmail.com> wrote:
> >
> > The commit b9a7ecc71fe582e ("cpumask: fix checking valid cpu range")
> > fixes broken cpumask_check(), which for now doesn't warn user when it
> > should. After the fix, I observed many false-positive warnings which
> > were addressed in the following patches.
>
> Are all the false positives fixed?
I build-tested on x86_64 and arm64. All fixed except for those
generated by cpumask_next_wrap(). And I'm not even sure they
are false positives.
This is what I'm working on right now. Hope moving it in next
merge window.
> I suspect that to avoid any automation noise, you should just rebase
> so that the fixes come first. Otherwise we'll end up wasting a lot of
> time on the noise.
>
> This is not that different from introducing new buil;d-time warnings:
> the things they point out need to be fixed before the warning can be
> integrated, or it causes bisection problems.
OK, I'll reorder the patches. Thanks for your help.
next prev parent reply other threads:[~2022-10-01 17:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 1:49 [oliver.sang@intel.com: [cpumask] b9a7ecc71f: WARNING:at_include/linux/cpumask.h:#__is_kernel_percpu_address] Yury Norov
2022-10-01 16:20 ` Linus Torvalds
2022-10-01 17:16 ` Yury Norov [this message]
2022-10-11 17:09 ` Andrew Jones
2022-10-11 17:16 ` Yury Norov
2022-10-11 17:21 ` Andrew Jones
2022-10-11 17:23 ` Yury Norov
2022-10-11 18:04 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yzh19JhBMzkMr4+L@yury-laptop \
--to=yury.norov@gmail.com \
--cc=lkp@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).