From: Christophe Ronco <c.ronco@kerlink.fr>
To: ofono@ofono.org
Subject: Re: [PATCH v5 1/4] Detect SARA R4 QMI device
Date: Wed, 12 May 2021 09:55:33 +0200 [thread overview]
Message-ID: <19a38925-618a-906b-6578-17b98122958c@kerlink.fr> (raw)
In-Reply-To: <20210512074053.6718-2-jupiter.hce@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2570 bytes --]
Hello,
I didn't go through the whole patch but I think you mixed 4 spaces with
tab.
The same problem exist in your 4 patches.
Best Regards,
Christophe
On 5/12/21 9:40 AM, Bing Jupiter wrote:
> ---
> plugins/udevng.c | 42 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/plugins/udevng.c b/plugins/udevng.c
> index 34ac1cc0..46bf5532 100644
> --- a/plugins/udevng.c
> +++ b/plugins/udevng.c
> @@ -1194,6 +1194,46 @@ static gboolean setup_ublox(struct modem_info *modem)
> return TRUE;
> }
>
> +static gboolean setup_ubloxqmi(struct modem_info *modem) {
> + const char *qmi = NULL, *net = NULL, *gps = NULL, *aux = NULL;
> + GSList *list;
> +
> + DBG("%s", modem->syspath);
> +
> + for (list = modem->devices; list; list = g_slist_next(list)) {
> + struct device_info *info = list->data;
> +
> + DBG("%s %s %s %s %s", info->devnode, info->interface,
> + info->number, info->label, info->subsystem);
> +
> + if (g_strcmp0(info->interface, "255/255/255") == 0 &&
> + g_strcmp0(info->number, "03") == 0) {
> + if (g_strcmp0(info->subsystem, "net") == 0)
> + net = info->devnode;
> + else if (g_strcmp0(info->subsystem, "usbmisc") == 0)
> + qmi = info->devnode;
> + }
> + }
> +
> + DBG("qmi=%s net=%s", qmi, net);
> +
> + if (qmi == NULL || net == NULL)
> + return FALSE;
> +
> + DBG("qmi=%s net=%s", qmi, net);
> +
> + ofono_modem_set_string(modem->modem, "Device", qmi);
> + ofono_modem_set_string(modem->modem, "NetworkInterface", net);
> + ofono_modem_set_string(modem->modem, "Quirk", "SARAR4");
Here
> +
> +
> + DBG("gps=%s aux=%s", gps, aux);
> +
> + ofono_modem_set_driver(modem->modem, "gobi");
> +
> + return TRUE;
> +}
> +
> static gboolean setup_gemalto(struct modem_info* modem)
> {
> const char *app = NULL, *gps = NULL, *mdm = NULL,
> @@ -1441,6 +1481,7 @@ static struct {
> { "quectel", setup_quectel },
> { "quectelqmi", setup_quectelqmi},
> { "ublox", setup_ublox },
> + { "ubloxqmi", setup_ubloxqmi },
Here
> { "gemalto", setup_gemalto },
> { "xmm7xxx", setup_xmm7xxx },
> { "mbim", setup_mbim },
> @@ -1850,6 +1891,7 @@ static struct {
> { "ublox", "cdc_ncm", "1546", "110a" },
> { "ublox", "rndis_host", "1546", "1146" },
> { "ublox", "cdc_acm", "1546", "1146" },
> + { "ubloxqmi", "qmi_wwan", "05c6", "90b2" },
Here
> { "gemalto", "option", "1e2d", "0053" },
> { "gemalto", "cdc_wdm", "1e2d", "0053" },
> { "gemalto", "qmi_wwan", "1e2d", "0053" },
next prev parent reply other threads:[~2021-05-12 7:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 7:40 [PATCH v5 0/4] Bing Jupiter
2021-05-12 7:40 ` [PATCH v5 1/4] Detect SARA R4 QMI device Bing Jupiter
2021-05-12 7:55 ` Christophe Ronco [this message]
2021-05-12 9:17 ` Jonas Bonn
2021-05-12 7:40 ` [PATCH v5 2/4] " Bing Jupiter
2021-05-12 9:18 ` Jonas Bonn
2021-05-12 7:40 ` [PATCH v5 3/4] " Bing Jupiter
2021-05-12 9:23 ` Jonas Bonn
2021-05-12 7:40 ` [PATCH v5 4/4] " Bing Jupiter
2021-05-12 9:27 ` Jonas Bonn
2021-08-19 5:56 ` Jupiter
2021-05-12 9:17 ` [PATCH v5 0/4] Jonas Bonn
2021-05-14 17:00 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19a38925-618a-906b-6578-17b98122958c@kerlink.fr \
--to=c.ronco@kerlink.fr \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).