From: Sergey Matyukevich <geomatsi@gmail.com>
To: ofono@ofono.org
Subject: [PATCH v3 0/3] sim: validate IMS private identity
Date: Sat, 16 Jan 2021 22:21:04 +0300 [thread overview]
Message-ID: <20210116192107.18568-1-geomatsi@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
Hello Denis and all,
These patches add UTF8 validation for IMS private identity. Without
this check ofono may crash on dbus assert when SIM properties are
reported via org.ofono.SimManager interface.
Regards,
Sergey
v2 -> v3
- support both null-terminated and non-null terminated TLV values
- move validation helper into simutil.c
- add unit tests
Sergey Matyukevich (3):
simutil: add validate_utf8_tlv
sim: validate IMS private identity
unit: add validate_utf8_tlv tests
src/sim.c | 3 ++-
src/simutil.c | 14 ++++++++++++++
src/simutil.h | 1 +
unit/test-simutil.c | 22 ++++++++++++++++++++++
4 files changed, 39 insertions(+), 1 deletion(-)
next reply other threads:[~2021-01-16 19:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-16 19:21 Sergey Matyukevich [this message]
2021-01-16 19:21 ` [PATCH v3 1/3] simutil: add validate_utf8_tlv Sergey Matyukevich
2021-01-19 16:04 ` Denis Kenzior
2021-01-16 19:21 ` [PATCH v3 2/3] sim: validate IMS private identity Sergey Matyukevich
2021-01-19 16:05 ` Denis Kenzior
2021-01-16 19:21 ` [PATCH v3 3/3] unit: add validate_utf8_tlv tests Sergey Matyukevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210116192107.18568-1-geomatsi@gmail.com \
--to=geomatsi@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).