From: Jupiter <jupiter.hce@gmail.com>
To: ofono@ofono.org
Subject: [PATCH v3 0/4] SARA R4 patches
Date: Mon, 22 Feb 2021 20:08:55 +1100 [thread overview]
Message-ID: <20210222090859.2883-1-jupiter.hce@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1747 bytes --]
From: jupiter <jupiter.hce@gmail.com>
Hi Jonas,
Is any reason you need to add ofono_modem_set_string(modem->modem, "Quirk", "SARAR4"); to static gboolean setup_sim7x00 rather than directly in static gboolean setup_ubloxqmi(struct modem_info *modem) ?
Your patch:
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -1366,6 +1366,11 @@ static gboolean setup_sim7x00(struct modem_info
*modem)
ofono_modem_set_string(modem->modem, "Audio", audio);
}
+ if ((g_strcmp0(modem->vendor, "0xffff") == 0) &&
+ (g_strcmp0(modem->model, "0xffff") == 0)) {
+ ofono_modem_set_string(modem->modem, "Quirk", "SARAR4");
+ }
+
My patch:
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -1194,6 +1194,45 @@ static gboolean setup_ublox(struct modem_info *modem)
return TRUE;
}
+static gboolean setup_ubloxqmi(struct modem_info *modem) {
..........
+ ofono_modem_set_string(modem->modem, "Device", qmi);
+ ofono_modem_set_string(modem->modem, "NetworkInterface", net);
+ ofono_modem_set_string(modem->modem, "Quirk", "SARAR4");
+ ofono_modem_set_driver(modem->modem, "gobi");
+
+ return TRUE;
+}
Thanks.
- jupiter
jupiter (4):
Change 1: SARA R4 QMI support
Change 2: Add SARA R4 vendor ID
Change 3: Check SARA R4 vendor ID, need to make it conditional on the
actions being attach and detach
Change 4: Add SARA R4 vendor and enable vendor in gprs create
drivers/atmodem/vendor.h | 1 +
drivers/qmimodem/gprs.c | 15 +++++++++++++++
plugins/gobi.c | 11 ++++++++++-
plugins/udevng.c | 41 ++++++++++++++++++++++++++++++++++++++++
4 files changed, 67 insertions(+), 1 deletion(-)
--
2.17.1
next reply other threads:[~2021-02-22 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 9:08 Jupiter [this message]
2021-02-22 9:08 ` [PATCH v3 1/4] Change 1: SARA R4 QMI support Jupiter
2021-02-22 9:08 ` [PATCH v3 2/4] Change 2: Add SARA R4 vendor ID Jupiter
2021-02-22 9:08 ` [PATCH v3 3/4] Change 3: Check SARA R4 vendor ID, need to make it conditional on the actions being attach and detach Jupiter
2021-02-22 9:08 ` [PATCH v3 4/4] Change 4: Add SARA R4 vendor and enable vendor in gprs create Jupiter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222090859.2883-1-jupiter.hce@gmail.com \
--to=jupiter.hce@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).