From: Steve Schrock <steve.schrock@getcruise.com>
To: ofono@lists.linux.dev
Cc: Steve Schrock <steve.schrock@getcruise.com>
Subject: [PATCH 1/8] qmi unit: Link to dl
Date: Fri, 19 Apr 2024 16:44:51 +0000 [thread overview]
Message-ID: <20240419164458.36078-1-steve.schrock@getcruise.com> (raw)
One of my VMs was getting a linker error when building
test-qmimodem-qmi in maintainer mode:
undefined reference to `dladdr'
Add -ldl to fix this.
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 9a6f82c39552..a4880036eaf5 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -932,7 +932,7 @@ unit_objects += $(unit_test_mbim_OBJECTS)
unit_test_qmimodem_qmi_SOURCES = unit/test-qmimodem-qmi.c src/common.c \
src/util.c src/log.c \
drivers/qmimodem/qmi.c
-unit_test_qmimodem_qmi_LDADD = @GLIB_LIBS@ $(ell_ldadd)
+unit_test_qmimodem_qmi_LDADD = @GLIB_LIBS@ $(ell_ldadd) -ldl
unit_objects += $(unit_test_qmimodem_qmi_OBJECTS)
unit/test-provision.db: unit/test-provision.json
--
2.40.1
--
*Confidentiality Note:* We care about protecting our proprietary
information, confidential material, and trade secrets. This message may
contain some or all of those things. Cruise will suffer material harm if
anyone other than the intended recipient disseminates or takes any action
based on this message. If you have received this message (including any
attachments) in error, please delete it immediately and notify the sender
promptly.
next reply other threads:[~2024-04-19 16:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 16:44 Steve Schrock [this message]
2024-04-19 16:44 ` [PATCH 2/8] qmi: Eliminate atomic ref counting Steve Schrock
2024-04-19 16:44 ` [PATCH 3/8] qmi: Create a better client service abstraction Steve Schrock
2024-04-19 16:44 ` [PATCH 4/8] qmi: Eliminate unnecessary casting to unsigned int Steve Schrock
2024-04-19 16:44 ` [PATCH 5/8] qmi: Prevent clients from unregistering for others Steve Schrock
2024-04-19 16:44 ` [PATCH 6/8] qmi unit: Validate creation of services of the same type Steve Schrock
2024-04-19 16:44 ` [PATCH 7/8] qmi unit: Validate destroyed services do not notify Steve Schrock
2024-04-19 16:44 ` [PATCH 8/8] qmi unit: Validate notifications are independent Steve Schrock
2024-04-19 16:52 ` [PATCH 1/8] qmi unit: Link to dl Marcel Holtmann
2024-04-19 18:32 ` [EXT] " Steve Schrock
2024-04-22 16:32 ` patchwork-bot+ofono
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240419164458.36078-1-steve.schrock@getcruise.com \
--to=steve.schrock@getcruise.com \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).