Re: [RFC PATCH 1/2] gemalto: add netmon driver

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

Hi Sergey,

On 1/10/21 1:44 PM, Sergey Matyukevich wrote:
> Implement network monitoring driver for gemalto modems that
> are able to provide serving cell information and basic
> measurements using AT+CQS and AT^SMONI commands.
> ---
>   Makefile.am                         |   3 +-
>   drivers/gemaltomodem/gemaltomodem.c |   2 +
>   drivers/gemaltomodem/gemaltomodem.h |   3 +
>   drivers/gemaltomodem/netmon.c       | 609 ++++++++++++++++++++++++++++
>   4 files changed, 616 insertions(+), 1 deletion(-)
>   create mode 100644 drivers/gemaltomodem/netmon.c
> 

<snip>

> +static int gemalto_netmon_probe(struct ofono_netmon *netmon,
> +					unsigned int vendor, void *user)
> +{
> +	GAtChat *chat = user;
> +	struct netmon_driver_data *nmd;
> +
> +	DBG("gemalto netmon probe");
> +
> +	nmd = g_try_new0(struct netmon_driver_data, 1);
> +	if (nmd == NULL)
> +		return -ENOMEM;

Feel free to use g_new0.  We have given up using g_try_new0 since these errors 
don't really occur on Linux.

> +
> +	nmd->chat = g_at_chat_clone(chat);
> +
> +	ofono_netmon_set_data(netmon, nmd);
> +
> +	g_idle_add(gemalto_delayed_register, netmon);
> +
> +	return 0;
> +}

Other than this, LGTM.

Regards,
-Denis