From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============0943282729677953345=="
MIME-Version: 1.0
From: Jonas Bonn <jonas@norrbonn.se>
Subject: Re: [PATCH v2 4/4] Make SARA R4 vendor ID conditional being attach
 and detach
Date: Wed, 24 Feb 2021 09:50:02 +0100
Message-ID: <4c9a50c7-3007-d9f1-2ee0-679e899cedbf@norrbonn.se>
In-Reply-To: <20210224083924.3480-5-jupiter.hce@gmail.com>
List-Id: <ofono.ofono.org>
To: ofono@ofono.org

--===============0943282729677953345==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Hi,

On 24/02/2021 09:39, Bing Jupiter wrote:
> ---
>   drivers/qmimodem/gprs.c | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
> =

> diff --git a/drivers/qmimodem/gprs.c b/drivers/qmimodem/gprs.c
> index 896a9e4c..90203dd3 100644
> --- a/drivers/qmimodem/gprs.c
> +++ b/drivers/qmimodem/gprs.c
> @@ -26,6 +26,7 @@
>   #include <ofono/log.h>
>   #include <ofono/modem.h>
>   #include <ofono/gprs.h>
> +#include <drivers/atmodem/vendor.h>
>   =

>   #include "qmi.h"
>   #include "nas.h"
> @@ -35,6 +36,7 @@
>   #include "qmimodem.h"
>   =

>   struct gprs_data {
> +	unsigned int vendor;
>   	struct qmi_device *dev;
>   	struct qmi_service *nas;
>   	struct qmi_service *wds;
> @@ -284,6 +286,18 @@ static void qmi_set_attached(struct ofono_gprs *gprs=
, int attached,
>   =

>   	DBG("attached %d", attached);
>   =

> +	if (data->vendor =3D=3D OFONO_VENDOR_UBLOX_SARA_R4) {
> +	/* This assumes neither 'attach' nor 'detach' are
> +	 * necessary... if 'attach' is required, then you'll
> +	 * need to make this section conditional on the action
> +	 * being 'detach'
> +	 */

Assuming you've tested this, you'll know whether 'attach' is required or =

not.  As such, fix accordingly and remove the above comment.

/Jonas


> +		DBG("Debug vendor =3D OFONO_VENDOR_UBLOX_SARA_R4");
> +		CALLBACK_WITH_SUCCESS(cb, cbd->data);
> +		g_free(cbd);
> +		return;
> +	}
> +
>   	if (attached)
>   		action =3D QMI_NAS_ATTACH_ACTION_ATTACH;
>   	else
> @@ -406,6 +420,7 @@ static int qmi_gprs_probe(struct ofono_gprs *gprs,
>   	DBG("");
>   =

>   	data =3D g_new0(struct gprs_data, 1);
> +	data->vendor =3D vendor;
>   =

>   	ofono_gprs_set_data(gprs, data);
>   =

>=20
--===============0943282729677953345==--