All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michal Wajdeczko" <michal.wajdeczko@intel.com>
To: intel-gfx@lists.freedesktop.org,
	Sagar Arun Kamble <sagar.a.kamble@intel.com>
Subject: Re: [PATCH 00/14] GuC code restructuring and fixes
Date: Tue, 19 Sep 2017 22:15:25 +0200	[thread overview]
Message-ID: <op.y6tw7z0sxaggs7@mwajdecz-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <1505842071-12787-1-git-send-email-sagar.a.kamble@intel.com>

On Tue, 19 Sep 2017 19:27:37 +0200, Sagar Arun Kamble  
<sagar.a.kamble@intel.com> wrote:

> This series is based on reviews from  
> https://patchwork.freedesktop.org/series/30502/.
>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Michał Winiarski <michal.winiarski@intel.com>
>
> Sagar Arun Kamble (14):
>   drm/i915/guc: Pass intel_guc struct as parameter to
>     intel_guc_wopcm_size
>   drm/i915: Create intel_uc_init_mmio to initialize MMIO interface prior
>     to uc init
>   drm/i915/guc: Create intel_guc_init_early
>   drm/i915: Create intel_guc.h, intel_huc.h and intel_uc_common.h
>   drm/i915/guc: Move GuC specific functionality from intel_uc.c to
>     intel_guc.c
>   drm/i915: Create uc runtime and system suspend/resume helpers
>   drm/i915/guc: Update prototype/name of GuC suspend/resume fns and move
>     to intel_guc.c
>   drm/i915/guc: Update GuC ggtt.invalidate/interrupts/communication
>     across RPM suspend/resume
>   drm/i915/guc: Update suspend functionality in intel_uc_suspend path
>   drm/i915/guc: Reuse GuC suspend functionality in reset path
>   drm/i915/guc: Fix GuC cleanup in unload path
>   drm/i915/guc: Remove i915_guc_log_unregister
>   drm/i915/guc: Enable default/critical logging in GuC by default from
>     GuC v9
>   drm/i915: Reorganize HuC authentication
>

Refactoring whole guc code in one series can be very long task.
By adding more and more fixes here you're preventing merge of the
most important patch.

Michal

>  drivers/gpu/drm/i915/Makefile              |   1 +
>  drivers/gpu/drm/i915/i915_drv.c            |  28 +++-
>  drivers/gpu/drm/i915/i915_gem.c            |   9 +-
>  drivers/gpu/drm/i915/i915_guc_submission.c |  54 +------
>  drivers/gpu/drm/i915/intel_guc.c           | 246  
> +++++++++++++++++++++++++++++
>  drivers/gpu/drm/i915/intel_guc.h           | 185 ++++++++++++++++++++++
>  drivers/gpu/drm/i915/intel_guc_fwif.h      |   4 +-
>  drivers/gpu/drm/i915/intel_guc_loader.c    |   3 +-
>  drivers/gpu/drm/i915/intel_guc_log.c       |  25 ++-
>  drivers/gpu/drm/i915/intel_huc.c           |  22 +--
>  drivers/gpu/drm/i915/intel_huc.h           |  41 +++++
>  drivers/gpu/drm/i915/intel_uc.c            | 165 ++++++-------------
>  drivers/gpu/drm/i915/intel_uc.h            | 205  
> ++----------------------
>  drivers/gpu/drm/i915/intel_uc_common.h     |  67 ++++++++
>  14 files changed, 653 insertions(+), 402 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/intel_guc.c
>  create mode 100644 drivers/gpu/drm/i915/intel_guc.h
>  create mode 100644 drivers/gpu/drm/i915/intel_huc.h
>  create mode 100644 drivers/gpu/drm/i915/intel_uc_common.h
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-09-19 20:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-19 17:27 [PATCH 00/14] GuC code restructuring and fixes Sagar Arun Kamble
2017-09-19 17:27 ` [PATCH 01/14] drm/i915/guc: Pass intel_guc struct as parameter to intel_guc_wopcm_size Sagar Arun Kamble
2017-09-19 20:17   ` Michal Wajdeczko
2017-09-20 11:13     ` Kamble, Sagar A
2017-09-19 17:27 ` [PATCH 02/14] drm/i915: Create intel_uc_init_mmio to initialize MMIO interface prior to uc init Sagar Arun Kamble
2017-09-19 20:28   ` Michal Wajdeczko
2017-09-20 10:45     ` Kamble, Sagar A
2017-09-19 17:27 ` [PATCH 03/14] drm/i915/guc: Create intel_guc_init_early Sagar Arun Kamble
2017-09-19 17:27 ` [PATCH 04/14] drm/i915: Create intel_guc.h, intel_huc.h and intel_uc_common.h Sagar Arun Kamble
2017-09-19 17:27 ` [PATCH 05/14] drm/i915/guc: Move GuC specific functionality from intel_uc.c to intel_guc.c Sagar Arun Kamble
2017-09-19 17:27 ` [PATCH 06/14] drm/i915: Create uc runtime and system suspend/resume helpers Sagar Arun Kamble
2017-09-19 17:27 ` [PATCH 07/14] drm/i915/guc: Update prototype/name of GuC suspend/resume fns and move to intel_guc.c Sagar Arun Kamble
2017-09-19 17:27 ` [PATCH 08/14] drm/i915/guc: Update GuC ggtt.invalidate/interrupts/communication across RPM suspend/resume Sagar Arun Kamble
2017-09-19 17:27 ` [PATCH 09/14] drm/i915/guc: Update suspend functionality in intel_uc_suspend path Sagar Arun Kamble
2017-09-19 17:27 ` [PATCH 10/14] drm/i915/guc: Reuse GuC suspend functionality in reset path Sagar Arun Kamble
2017-09-19 17:27 ` [PATCH 11/14] drm/i915/guc: Fix GuC cleanup in unload path Sagar Arun Kamble
2017-09-19 17:27 ` [PATCH 12/14] drm/i915/guc: Remove i915_guc_log_unregister Sagar Arun Kamble
2017-09-19 17:27 ` [PATCH 13/14] drm/i915/guc: Enable default/critical logging in GuC by default from GuC v9 Sagar Arun Kamble
2017-09-19 17:27 ` [PATCH 14/14] drm/i915: Reorganize HuC authentication Sagar Arun Kamble
2017-09-19 20:15 ` Michal Wajdeczko [this message]
2017-09-20 10:42   ` [PATCH 00/14] GuC code restructuring and fixes Kamble, Sagar A
2017-09-19 20:26 ` ✓ Fi.CI.BAT: success for GuC code restructuring and fixes (rev3) Patchwork
2017-09-20  0:11 ` ✗ Fi.CI.IGT: warning " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.y6tw7z0sxaggs7@mwajdecz-mobl1.ger.corp.intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=sagar.a.kamble@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.