Re: [PATCH 2/7] drm/i915/uc: HuC firmware can't be supported without GuC

From: "Michal Wajdeczko" <michal.wajdeczko@intel.com>
To: "Kumar Valsan, Prathap" <prathap.kumar.valsan@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/7] drm/i915/uc: HuC firmware can't be supported without GuC
Date: Wed, 07 Aug 2019 22:12:26 +0200	[thread overview]
Message-ID: <op.z55420b2xaggs7@mwajdecz-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20190807202129.GD3842@intel.com>

On Wed, 07 Aug 2019 22:21:29 +0200, Kumar Valsan, Prathap  
<prathap.kumar.valsan@intel.com> wrote:

> On Wed, Aug 07, 2019 at 05:00:29PM +0000, Michal Wajdeczko wrote:
>> There is no point in selecting HuC firmware if GuC is unsupported
>> or it was already disabled, as we need GuC to authenticate HuC.
>>
>
> We are calling  intel_uc_init() irrespctive of  
> intel_uc_fetch_firmwares() is
> successful. Is this ok?

No need to change this, as intel_guc_init (and intel_huc_init)
will call intel_uc_fw_init() which will with -ENOEXEC if firmware
is not available (aka fetched)

Michal

>
> Thanks,
> Prathap
>> While around, make uc_fw_init_early work without direct access
>> to whole i915, pass only needed platform/rev info.
>>
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx