From: Billy Tsai <billy_tsai@aspeedtech.com>
To: "Winiarska, Iwona" <iwona.winiarska@intel.com>,
"zweiss@equinix.com" <zweiss@equinix.com>
Cc: "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"Hansen, Dave" <dave.hansen@intel.com>,
"robh@kernel.org" <robh@kernel.org>,
"jae.hyun.yoo@linux.intel.com" <jae.hyun.yoo@linux.intel.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"bp@alien8.de" <bp@alien8.de>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"Luck, Tony" <tony.luck@intel.com>,
"andrew@aj.id.au" <andrew@aj.id.au>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"olof@lixom.net" <olof@lixom.net>
Subject: Re: [PATCH v4 02/13] dt-bindings: Add bindings for peci-aspeed
Date: Wed, 8 Dec 2021 02:23:16 +0000 [thread overview]
Message-ID: <1398354F-F251-4CEA-8E92-7C442287F6BC@aspeedtech.com> (raw)
In-Reply-To: <0a82b85608ea13424c601a4a6364652d2a411675.camel@intel.com>
Hi Iwona,
On 2021/12/8, 2:30 AM, "Winiarska, Iwona" <iwona.winiarska@intel.com> wrote:
On Thu, 2021-12-02 at 02:31 +0000, Billy Tsai wrote:
> > Hi Zev,
> >
> > On 2021/12/2, 9:55 AM, "Zev Weiss" <zweiss@equinix.com> wrote:
> >
> > On Wed, Dec 01, 2021 at 02:38:04AM PST, Billy Tsai wrote:
> > > >Hi,
> > > >
> > > >On 2021/11/23, 10:10 PM, "openbmc on behalf of Iwona Winiarska"
> > <openbmc-bounces+billy_tsai=aspeedtech.com@lists.ozlabs.org on behalf of
> > iwona.winiarska@intel.com> wrote:
> > > >
> > > > Add device tree bindings for the peci-aspeed controller driver.
> > > >
> > > > > + aspeed,clock-divider:
> > > > > + description:
> > > > > + This value determines PECI controller internal clock
> > dividing
> > > > > + rate. The divider will be calculated as 2 raised to
> > the power of
> > > > > + the given value.
> > > > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > > > + minimum: 0
> > > > > + maximum: 7
> > > > > + default: 0
> > > > > +
> > > > > + aspeed,msg-timing:
> > > > > + description:
> > > > > + Message timing negotiation period. This value will
> > determine the period
> > > > > + of message timing negotiation to be issued by PECI
> > controller. The unit
> > > > > + of the programmed value is four times of PECI clock
> > period.
> > > > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > > > + minimum: 0
> > > > > + maximum: 255
> > > > > + default: 1
> > > > > +
> > > > > + aspeed,addr-timing:
> > > > > + description:
> > > > > + Address timing negotiation period. This value will
> > determine the period
> > > > > + of address timing negotiation to be issued by PECI
> > controller. The unit
> > > > > + of the programmed value is four times of PECI clock
> > period.
> > > > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > > > + minimum: 0
> > > > > + maximum: 255
> > > > > + default: 1
> > > >I suggest deleting these three properties and replacing them with the
> > following
> > > >
> > > >aspeed,peci-bit-time:
> > > > description:
> > > > The bit time driven by PECI controller. The unit of the
> > value is Hz.
> > > > minimum: 2000
> > > > maximum: 1000000
> > > >
> > > >And the driver should use this property to caculate the appropriate
> > clock-divider,
> > > >msg-timing and addr-timing, instead of exposing hardware registers to
> > dts.
> > > >
> >
> > > Or perhaps just 'bus-frequency' a la i2c-aspeed, gpio-aspeed-sgpio,
> > etc?
> >
> > It's a good ideal for the consistency.
> If we want to go with passing frequency - I would prefer to go with "clock-
> frequency" and use clock framework for exposing it to peci-aspeed (as I
> mentioned in reply to patch 05).
> What do you think?
Good.
It looks that "clock-frequency" is more common usage.
Thanks
Best Regards,
Billy Tsai
next prev parent reply other threads:[~2021-12-08 2:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 14:06 [PATCH v4 00/13] Introduce PECI subsystem Iwona Winiarska
2021-11-23 14:06 ` [PATCH v4 01/13] dt-bindings: Add generic bindings for PECI Iwona Winiarska
2021-11-23 14:06 ` [PATCH v4 02/13] dt-bindings: Add bindings for peci-aspeed Iwona Winiarska
2021-12-01 10:38 ` Billy Tsai
2021-12-02 1:54 ` Zev Weiss
2021-12-02 2:31 ` Billy Tsai
2021-12-07 18:15 ` Winiarska, Iwona
2021-12-08 2:23 ` Billy Tsai [this message]
2021-11-23 14:06 ` [PATCH v4 03/13] ARM: dts: aspeed: Add PECI controller nodes Iwona Winiarska
2021-11-23 14:06 ` [PATCH v4 04/13] peci: Add core infrastructure Iwona Winiarska
2021-11-23 14:06 ` [PATCH v4 05/13] peci: Add peci-aspeed controller driver Iwona Winiarska
2021-12-06 5:27 ` Billy Tsai
2021-12-07 18:09 ` Winiarska, Iwona
2021-11-23 14:06 ` [PATCH v4 06/13] peci: Add device detection Iwona Winiarska
2021-11-23 14:07 ` [PATCH v4 07/13] peci: Add sysfs interface for PECI bus Iwona Winiarska
2021-11-23 14:07 ` [PATCH v4 08/13] peci: Add support for PECI device drivers Iwona Winiarska
2021-11-23 14:07 ` [PATCH v4 09/13] peci: Add peci-cpu driver Iwona Winiarska
2021-11-23 14:07 ` [PATCH v4 10/13] hwmon: peci: Add cputemp driver Iwona Winiarska
2021-11-23 15:51 ` Guenter Roeck
2021-11-23 14:07 ` [PATCH v4 11/13] hwmon: peci: Add dimmtemp driver Iwona Winiarska
2021-11-23 14:07 ` [PATCH v4 12/13] docs: hwmon: Document PECI drivers Iwona Winiarska
2021-11-23 15:57 ` Guenter Roeck
2021-11-23 14:07 ` [PATCH v4 13/13] docs: Add PECI documentation Iwona Winiarska
2021-12-14 13:52 ` [PATCH v4 00/13] Introduce PECI subsystem Tomer Maimon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398354F-F251-4CEA-8E92-7C442287F6BC@aspeedtech.com \
--to=billy_tsai@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=iwona.winiarska@intel.com \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=olof@lixom.net \
--cc=openbmc@lists.ozlabs.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=tony.luck@intel.com \
--cc=zweiss@equinix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).