From: Klaus Heinrich Kiwi <klaus@linux.vnet.ibm.com>
To: Joel Stanley <joel@jms.id.au>
Cc: "Andrew Jeffery" <andrew@aj.id.au>,
"OpenBMC Maillist" <openbmc@lists.ozlabs.org>,
"Cédric Le Goater" <clg@kaod.org>
Subject: Re: [PATCH u-boot v2019.04-aspeed-openbmc v2 00/10] Use HACE to accelerate sha512
Date: Fri, 23 Apr 2021 09:47:24 -0300 [thread overview]
Message-ID: <193fec89-1935-e1f5-dd1b-2a5ad5f6db9c@linux.vnet.ibm.com> (raw)
In-Reply-To: <CACPK8XeqHysaOVxPLDUSB89MpSGg25x_S3LhAy3h71GVj0kT6g@mail.gmail.com>
>>
>> Looks like you forgot to include 'clk: aspeed: Add HACE yclk to ast2600'
>
> That patch was already applied to the u-boot tree.
>
> I've since applied this series to the top of v2019.04-aspeed-openbmc.
Yeah I missed that you merged some of the patches
>> It fails pretty instantly even in Qemu without it.
>>
>>
>> Additionally, looks like the spl binary size grew significantly to 59696
>> bytes (around 10KB larger than before). The final SPL size when added to
>> the Device-tree blob with the 4096bits public key is 65058 bytes, which
>> is just a tad over the maximum limit we have of 65024 bytes.
>
> That's a surprise. Were you able to work out where the size increase came from?
>
> Here's the size I see with HEAD:
>
> 44a8c618c1215e0faac0f335f0afd56ed4240e76 49986
>
> I'm using arm-linux-gnueabi-gcc (Debian 10.2.1-6) 10.2.1 20210110.
Looks like I was also missing some of the patches #ifdef'ing out the
sha512/sha256 implementations when hw sha was available.
I was able to test the tree '44a8c618c1 configs: ast2600: Use non-a1 config for openbmc spl emmc'
both on Qemu and hardware and it works fine, thanks!
-Klaus
--
Klaus Heinrich Kiwi <klaus@linux.vnet.ibm.com>
prev parent reply other threads:[~2021-04-23 12:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 6:46 [PATCH u-boot v2019.04-aspeed-openbmc v2 00/10] Use HACE to accelerate sha512 Joel Stanley
2021-04-20 6:46 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 01/10] configs/ast2600: Make early malloc pool larger Joel Stanley
2021-04-20 8:53 ` Cédric Le Goater
2021-04-21 1:43 ` Joel Stanley
2021-04-20 6:46 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 02/10] crypto: Add driver for Aspeed HACE Joel Stanley
2021-04-20 6:46 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 03/10] ast2600: Enable HACE probing in SPL Joel Stanley
2021-04-20 6:46 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 04/10] ast2600: Add HACE to device tree Joel Stanley
2021-04-20 6:46 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 05/10] ast2600: spl: Remove SECBOOT BL2 kconfig option Joel Stanley
2021-04-20 6:46 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 06/10] ast2600: spl: Add ASPEED_LOADERS option Joel Stanley
2021-04-20 6:46 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 07/10] ast2600: spl: Support common boot loader features Joel Stanley
2021-04-20 6:46 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 08/10] config: ast2600: Configure common MMC SPL loader Joel Stanley
2021-04-20 6:46 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 09/10] configs: ast2600: Enable FIT SHA512 support Joel Stanley
2021-04-20 6:46 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 10/10] config: ast2600: Disable SPL raw image support Joel Stanley
[not found] ` <OF2C524D29.DA2BBB20-ON002586BD.00695579-002586BD.006F66D8@notes.na.collabserv.com>
2021-04-21 2:02 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 00/10] Use HACE to accelerate sha512 Joel Stanley
2021-04-22 20:46 ` Klaus Heinrich Kiwi
2021-04-23 0:32 ` Joel Stanley
2021-04-23 12:47 ` Klaus Heinrich Kiwi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=193fec89-1935-e1f5-dd1b-2a5ad5f6db9c@linux.vnet.ibm.com \
--to=klaus@linux.vnet.ibm.com \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).