From: Brad Bishop <bradleyb@fuzziesquirrel.com>
To: OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: [Maintainers] Call for maintenance
Date: Thu, 12 Jul 2018 13:52:13 -0400 [thread overview]
Message-ID: <1F65CF12-B31E-409C-BD72-D1CF3D0CFBFC@fuzziesquirrel.com> (raw)
I wanted to highlight a recent sdbusplus patch:
https://gerrit.openbmc-project.xyz/#/c/10566/
The nutshell is proper error handling of errors from libsystemd's
sd_bus_call has been added and sdbusplus::bus::call may now throw
SdBusError.
This note is an open call to all maintainers to scrub your applications
for use of sdbusplus::bus::call and handle SdBusError as appropriate.
I want to point out that catching SdBusError in your wrapper function
around sdbusplus::bus::call and simply eating it (or logging it, tracing
it, etc) is not really “handling” this new exception. Nor is wrapping
your entire program in a try block “handling” it either. Instead,
traverse the stack until you find the code with the logic that knows
whether or not the error is anticipated or not, and handle it there.
For example:
https://gerrit.openbmc-project.xyz/#/c/11423/3/src/propertywatchimpl.hpp
thx - brad
next reply other threads:[~2018-07-12 17:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 17:52 Brad Bishop [this message]
2018-07-31 14:19 ` [Maintainers] Call for maintenance Tom Joseph
2018-08-01 2:13 ` Lei YU
2018-08-01 19:31 ` Vernon Mauery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1F65CF12-B31E-409C-BD72-D1CF3D0CFBFC@fuzziesquirrel.com \
--to=bradleyb@fuzziesquirrel.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).