From: Joel Stanley <joel@jms.id.au>
To: openbmc@lists.ozlabs.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Eddie James <eajames@linux.vnet.ibm.com>
Subject: [PATCH 3/5] fsi: sbefifo: Fix sparse warnings
Date: Mon, 18 Jun 2018 13:13:33 +0930 [thread overview]
Message-ID: <20180618034335.9732-4-joel@jms.id.au> (raw)
In-Reply-To: <20180618034335.9732-1-joel@jms.id.au>
fsi-sbefifo.c:547:58: warning: incorrect type in argument 2 (different base types)
fsi-sbefifo.c:547:58: expected restricted __be32 [usertype] *word
fsi-sbefifo.c:547:58: got unsigned int *<noident>
fsi-sbefifo.c:635:16: warning: incorrect type in assignment (different base types)
fsi-sbefifo.c:635:16: expected unsigned int [unsigned] <noident>
fsi-sbefifo.c:635:16: got restricted __be32 [usertype] <noident>
fsi-sbefifo.c:636:16: warning: incorrect type in assignment (different base types)
fsi-sbefifo.c:636:16: expected unsigned int [unsigned] <noident>
fsi-sbefifo.c:636:16: got restricted __be32 [usertype] <noident>
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
drivers/fsi/fsi-sbefifo.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
index e6882a2b1709..4f076fd2939c 100644
--- a/drivers/fsi/fsi-sbefifo.c
+++ b/drivers/fsi/fsi-sbefifo.c
@@ -519,9 +519,10 @@ static int sbefifo_send_command(struct sbefifo *sbefifo,
static int sbefifo_read_response(struct sbefifo *sbefifo, struct iov_iter *response)
{
struct device *dev = &sbefifo->fsi_dev->dev;
- u32 data, status, eot_set;
+ u32 status, eot_set;
unsigned long timeout;
bool overflow = false;
+ __be32 data;
size_t len;
int rc;
@@ -619,7 +620,7 @@ static void sbefifo_collect_async_ffdc(struct sbefifo *sbefifo)
struct kvec ffdc_iov;
__be32 *ffdc;
size_t ffdc_sz;
- u32 cmd[2];
+ __be32 cmd[2];
int rc;
sbefifo->async_ffdc = false;
--
2.17.1
next prev parent reply other threads:[~2018-06-18 3:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 3:43 [PATCH 0/5] FSI warning fixes Joel Stanley
2018-06-18 3:43 ` [PATCH 1/5] fsi-occ: Fix size_t printf Joel Stanley
2018-06-18 4:30 ` Benjamin Herrenschmidt
2018-06-18 3:43 ` [PATCH 2/5] hwmon (occ): Fix printf warning Joel Stanley
2018-06-18 3:43 ` Joel Stanley [this message]
2018-06-18 3:43 ` [PATCH 4/5] fsi: master-hub: Fix sparse warnings Joel Stanley
2018-06-18 3:43 ` [PATCH 5/5] fsi: core: " Joel Stanley
2018-06-18 4:32 ` [PATCH 0/5] FSI warning fixes Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618034335.9732-4-joel@jms.id.au \
--to=joel@jms.id.au \
--cc=benh@kernel.crashing.org \
--cc=eajames@linux.vnet.ibm.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).