From: Rob Herring <robh@kernel.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: openbmc@lists.ozlabs.org, linux-aspeed@lists.ozlabs.org,
devicetree@vger.kernel.org, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [PATCH 1/2] dt-bindings: fsi: Add optional chip-id to CFAMs
Date: Tue, 3 Jul 2018 13:30:17 -0600 [thread overview]
Message-ID: <20180703193017.GA23230@rob-hp-laptop> (raw)
In-Reply-To: <20180622043756.21158-1-benh@kernel.crashing.org>
On Fri, Jun 22, 2018 at 02:37:55PM +1000, Benjamin Herrenschmidt wrote:
> This represents a physical chip in the system and allows
> a stable numbering scheme to be passed to udev for userspace
> to recognize which chip is which.
I'm sure you're aware, stable numbers is generally not something the
kernel guarantees...
In the cases where we do have them, we've used aliases.
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> Documentation/devicetree/bindings/fsi/fsi.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/fsi/fsi.txt b/Documentation/devicetree/bindings/fsi/fsi.txt
> index ab516c673a4b..afb4eccab131 100644
> --- a/Documentation/devicetree/bindings/fsi/fsi.txt
> +++ b/Documentation/devicetree/bindings/fsi/fsi.txt
> @@ -83,6 +83,10 @@ addresses and sizes in the slave address space:
> #address-cells = <1>;
> #size-cells = <1>;
>
> +Optionally, a slave can provide a global unique chip ID which is used to
> +identify the physical location of the chip in a system specific way
> +
> + chip-id = <0>;
>
> FSI engines (devices)
> ---------------------
> @@ -125,6 +129,7 @@ device tree if no extra platform information is required.
> reg = <0 0>;
> #address-cells = <1>;
> #size-cells = <1>;
> + chip-id = <0>;
>
> /* FSI engine at 0xc00, using a single page. In this example,
> * it's an I2C master controller, so subnodes describe the
> --
> 2.17.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-07-03 19:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 4:37 [PATCH 1/2] dt-bindings: fsi: Add optional chip-id to CFAMs Benjamin Herrenschmidt
2018-06-22 4:37 ` [PATCH 2/2] fsi: Add support for device-tree provided chip IDs Benjamin Herrenschmidt
2018-07-03 19:30 ` Rob Herring [this message]
2018-07-04 1:06 ` [PATCH 1/2] dt-bindings: fsi: Add optional chip-id to CFAMs Benjamin Herrenschmidt
2018-07-05 18:49 ` Rob Herring
2018-07-06 1:48 ` Benjamin Herrenschmidt
2018-07-12 2:07 ` Benjamin Herrenschmidt
2018-07-16 14:13 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703193017.GA23230@rob-hp-laptop \
--to=robh@kernel.org \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).