Re: [PATCH linux-next v5 08/13] drivers/mfd: Add PECI client mfd driver

[Lee Jones <lee.jones@linaro.org>]

On Mon, 18 Jun 2018, Jae Hyun Yoo wrote:
> On 6/17/2018 10:59 PM, Lee Jones wrote:
> > On Thu, 14 Jun 2018, Jae Hyun Yoo wrote:
> > 
> > > Thanks for the review. Please see my inline answers.
> > > 
> > > On 6/12/2018 11:30 PM, Lee Jones wrote:
> > > > On Fri, 01 Jun 2018, Jae Hyun Yoo wrote:
> > > > 
> > > > > This commit adds PECI client mfd driver.
> > > > > 
> > > > > Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> > > > > Cc: Andrew Jeffery <andrew@aj.id.au>
> > > > > Cc: James Feist <james.feist@linux.intel.com>
> > > > > Cc: Jason M Biils <jason.m.bills@linux.intel.com>
> > > > > Cc: Joel Stanley <joel@jms.id.au>
> > > > > Cc: Vernon Mauery <vernon.mauery@linux.intel.com>
> > > > > ---
> > > > >    drivers/mfd/Kconfig             |  11 ++
> > > > >    drivers/mfd/Makefile            |   1 +
> > > > >    drivers/mfd/peci-client.c       | 205 ++++++++++++++++++++++++++++++++
> > > > >    include/linux/mfd/peci-client.h |  60 ++++++++++
> > > > >    4 files changed, 277 insertions(+)
> > > > >    create mode 100644 drivers/mfd/peci-client.c
> > > > >    create mode 100644 include/linux/mfd/peci-client.h
> 
> > [...]
> > 
> > > > > +static struct peci_driver peci_client_driver = {
> > > > 
> > > > I'm pretty sure this will be NAKED by the platform Maintainer.
> > > 
> > > Does it have problems? Can you please give me a hint?
> > 
> > New bus types are usually only added for well defined, heavily used
> > buses which AFAIK all have their own subsystems.  Why can't you use
> > one of the existing bus types?  Platform is the most frequently used.
> > 
> 
> I implemented this PECI drivers as a simple platform drivers in V1 but
> I had to change it to follow other maintainers' suggestions. I believe
> driver core maintainers are reviewing the PECI subsystem implementation
> code in this patch set as well.

I don't see this discussion.  How is it progressing?

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog