From: Patrick Williams <patrick@stwcx.xyz>
To: Brad Bishop <bradleyb@fuzziesquirrel.com>
Cc: Vijay Khemka <vijaykhemka@fb.com>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Re: 2 patch dependency
Date: Mon, 18 Nov 2019 18:35:09 -0600 [thread overview]
Message-ID: <20191119003509.GA80304@patrickw3-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <E782C583-DBB7-4589-BFE6-EC69E2343424@fuzziesquirrel.com>
[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]
On Tue, Nov 05, 2019 at 09:27:21AM -0500, Brad Bishop wrote:
>
>
> > On Nov 1, 2019, at 3:18 PM, Vijay Khemka <vijaykhemka@fb.com> wrote:
> >
> > We have issue of merging 2 commit which are dependent to each other. I am not sure how are we going address this.
>
> I’m working on this today:
>
> https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/26910
Do we have any sort of topic-based multi-repo testing? If not, is there
any interest in developing it?
I implemented this on another project:
* Whenever Jenkins was triggered by Gerrit, it looked at the
GERRIT_TOPIC variable to determine if the change belonged to a
topic.
* If the commit was in a topic, Jenkins queried Gerrit for all open
changes that belonged to the same topic. Using `repo`, Jenkins
would extract all of these changes into a working directory and
`bitbake` to kick off a build.
This was useful both commits that spanned metas and for commits that
involved both code and recipe changes. This was really useful for
changes that added a new dependency so you didn't have to add a
free-standing recipe update with a "trust me, the code is coming that is
going to need this dependency" kind of comment.
I know we're not using `repo` right now and so there is some work
involved in making this span the OpenBMC code repositories, but a simple
first step would be to get this working across the meta subtrees. Would
this help changes like Vijay's so we don't need to involve a cross-meta
maintainer?
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-11-19 0:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 19:18 2 patch dependency Vijay Khemka
2019-11-05 14:27 ` Brad Bishop
2019-11-19 0:35 ` Patrick Williams [this message]
2019-11-19 15:45 ` Andrew Geissler
2019-11-19 16:54 ` Patrick Williams
2019-11-19 21:16 ` Andrew Geissler
2019-11-22 15:44 ` Brad Bishop
2019-11-22 17:36 ` Patrick Williams
2019-11-22 18:41 ` Brad Bishop
2019-11-22 20:52 ` Patrick Williams
2019-11-22 15:47 ` Brad Bishop
2019-11-22 15:52 ` Brad Bishop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119003509.GA80304@patrickw3-mbp.dhcp.thefacebook.com \
--to=patrick@stwcx.xyz \
--cc=bradleyb@fuzziesquirrel.com \
--cc=openbmc@lists.ozlabs.org \
--cc=vijaykhemka@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).