From: Patrick Williams <patrick@stwcx.xyz>
To: OpenBMC List <openbmc@lists.ozlabs.org>
Subject: xyz.openbmc_project.Sensor.Value units
Date: Mon, 21 Sep 2020 12:33:26 -0500 [thread overview]
Message-ID: <20200921173326.GK6152@heinlein> (raw)
[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]
Hello,
Currently all xyz.openbmc_project.Sensor.Value's have metric units.
There is a proposed commit [1] to add a non-metric unit. Are there any
opinions on this subject?
In this case the proposal is to add an "airflow" unit, in CFMs (cubit
feet per minute). An equivalent metric unit would be L/s (liters per
second). CFM tends to be the standard unit to measure airflow from a
fan, but L/s is used for liquid cooling.
Options:
* Allow CFM for airflow.
- CFM is the "industry standard" measurement for fans.
* Require Sensors.Value to use L/s instead.
- All units will continue to be metric. Any external interface
which is expecting a non-metric unit can do the conversion at
that point.
- We won't have duplicate Units defined for similar concepts
(air vs liquid flow in this case).
Thus, it seems like there are two underlying questions to resolve:
* Do we require only metric unit or do we allow non-metric?
* Do we allow duplicate unit definitions for the same concept (ex. flow)?
1. https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/36573
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next reply other threads:[~2020-09-21 17:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 17:33 Patrick Williams [this message]
2020-09-21 17:33 ` xyz.openbmc_project.Sensor.Value units Patrick Williams
2020-09-30 5:22 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921173326.GK6152@heinlein \
--to=patrick@stwcx.xyz \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).