From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1EEAC4741F for ; Thu, 5 Nov 2020 16:49:41 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 307C22073A for ; Thu, 5 Nov 2020 16:49:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 307C22073A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fuzziesquirrel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CRqHh4MPYzDqn4 for ; Fri, 6 Nov 2020 03:49:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=fuzziesquirrel.com (client-ip=173.167.31.197; helo=bajor.fuzziesquirrel.com; envelope-from=bradleyb@fuzziesquirrel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=fuzziesquirrel.com Received: from bajor.fuzziesquirrel.com (mail.fuzziesquirrel.com [173.167.31.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CRqGC6XnBzDr5X for ; Fri, 6 Nov 2020 03:48:18 +1100 (AEDT) X-Virus-Scanned: amavisd-new at fuzziesquirrel.com Date: Thu, 5 Nov 2020 11:48:12 -0500 From: Brad Bishop To: Deepak Kodihalli Subject: Re: Using bios-settings-mgr for setting hypervisor network attributes Message-ID: <20201105164812.ylk4wlkjnczykwpy@thinkpad.fuzziesquirrel.com> References: <20200916172045.GD6152@heinlein> <20200917153601.GH6152@heinlein> <08d2b666-91cf-d60a-1f2b-028e6ca6eaa5@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <08d2b666-91cf-d60a-1f2b-028e6ca6eaa5@linux.vnet.ibm.com> X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: openbmc@lists.ozlabs.org, Ed Tanous , Ratan Gupta Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Tue, Sep 22, 2020 at 05:38:32PM +0530, Deepak Kodihalli wrote: >To add to this, from a PLDM perspective, we plan to send up the >hypervisor network config properties to the host as BIOS attributes. Would we need to hide these from a future redfish bios settings schema implementation? >There isn't a PLDM network config schema. The PLDM daemon talks to the >new bios-settings-mgr app to find BIOS properties that have been >updated out of band. The Redfish schema we plan to use here is >EthernetInterface though, and not the Redfish BIOS schema. All this is >causing a need for some conversion layers. > >My initial thought was bmcweb can update the BIOS backend store that's >implemented by the bios-settings-mgr, but it looks like Patrick and Ed >have concerns with that approach. I think I agree their reasoning, but >at the same time I don't think there should be special code in the >PLDM daemon (timers/special knowledge about a set of BIOS >attributes/special BIOS attribute which indicates other BIOS >attributes have been updated/etc) for this, and this should be >processed like any other BIOS attribute that the PLDM daemon deals >with. This implies these attributes should also make it to the store >that bios-settings-mgr owns (that likely means an additional D-Bus >hop). So, another option (proposal 4) could be an intermediate app >that accumulates (for eg by means of watching the 'Enabled' property >that's in the Object.Enable interface; the hypervisor settings object >would have to additionally implement this interface) the hypervisor >network config property updates, and then provides these as key-value >pairs to the bios-settings-mgr app. I get the feeling this option 4 might have been overlooked because it was buried in this long thread. Anyone care to weigh in on this as an option?