From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Sasha Levin <sashal@kernel.org>, Felipe Balbi <balbi@kernel.org>,
Ryan Chen <ryan_chen@aspeedtech.com>,
kernel test robot <lkp@intel.com>,
linux-aspeed@lists.ozlabs.org,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Andrew Jeffery <andrew@aj.id.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-usb@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Tao Ren <taoren@fb.com>,
rentao.bupt@gmail.com, Thomas Tai <thomas.tai@oracle.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] usb: gadget: aspeed: set port_dev dma mask
Date: Fri, 26 Mar 2021 13:05:26 +0100 [thread overview]
Message-ID: <20210326120526.GA14169@lst.de> (raw)
In-Reply-To: <10920f34-289c-feac-79b6-71bff2aea67d@arm.com>
On Fri, Mar 26, 2021 at 12:03:03PM +0000, Robin Murphy wrote:
> This might happen to work out, but is far from correct. Just wait until you
> try it on a platform where the USB controller is behind an IOMMU...
>
> It looks like something is more fundamentally wrong here - the device
> passed to DMA API calls must be the actual hardware device performing the
> DMA, which in USB-land I believe means the controller's sysdev.
The shiny new usb_intf_get_dma_device API provides the device to use.
next prev parent reply other threads:[~2021-03-29 0:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 7:02 [PATCH] usb: gadget: aspeed: set port_dev dma mask rentao.bupt
2021-03-26 12:03 ` Robin Murphy
2021-03-26 12:05 ` Christoph Hellwig [this message]
2021-03-27 22:17 ` Tao Ren
2021-03-29 6:17 ` Christoph Hellwig
2021-03-31 3:47 ` Tao Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210326120526.GA14169@lst.de \
--to=hch@lst.de \
--cc=andrew@aj.id.au \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=masahiroy@kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=rentao.bupt@gmail.com \
--cc=robin.murphy@arm.com \
--cc=ryan_chen@aspeedtech.com \
--cc=sashal@kernel.org \
--cc=taoren@fb.com \
--cc=thomas.tai@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).