From: Rob Herring <robh@kernel.org>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: - <devicetree@vger.kernel.org>,
linux-aspeed@lists.ozlabs.org, Andrew Jeffery <andrew@aj.id.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Lubomir Rintel <lkundrak@v3.sk>,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] dt-bindings: serial: 8250: update for aspeed,sirq-active-high
Date: Tue, 30 Mar 2021 17:39:02 -0500 [thread overview]
Message-ID: <20210330223902.GA837825@robh.at.kernel.org> (raw)
In-Reply-To: <20210330002338.335-3-zev@bewilderbeest.net>
On Mon, Mar 29, 2021 at 07:23:37PM -0500, Zev Weiss wrote:
> Update DT bindings documentation for the new incarnation of the
> aspeed,sirq-polarity-sense property.
Why?
This isn't a compatible change.
>
> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
> ---
> Documentation/devicetree/bindings/serial/8250.yaml | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/8250.yaml b/Documentation/devicetree/bindings/serial/8250.yaml
> index f54cae9ff7b2..0bbb7121f720 100644
> --- a/Documentation/devicetree/bindings/serial/8250.yaml
> +++ b/Documentation/devicetree/bindings/serial/8250.yaml
> @@ -13,7 +13,7 @@ allOf:
> - $ref: /schemas/serial.yaml#
> - if:
> required:
> - - aspeed,sirq-polarity-sense
> + - aspeed,sirq-active-high
> then:
> properties:
> compatible:
> @@ -181,13 +181,11 @@ properties:
> rng-gpios: true
> dcd-gpios: true
>
> - aspeed,sirq-polarity-sense:
> - $ref: /schemas/types.yaml#/definitions/phandle-array
> + aspeed,sirq-active-high:
> + type: boolean
> description: |
> - Phandle to aspeed,ast2500-scu compatible syscon alongside register
> - offset and bit number to identify how the SIRQ polarity should be
> - configured. One possible data source is the LPC/eSPI mode bit. Only
> - applicable to aspeed,ast2500-vuart.
> + Set to indicate that the SIRQ polarity is active-high (default
> + is active-low). Only applicable to aspeed,ast2500-vuart.
>
> required:
> - reg
> @@ -227,7 +225,7 @@ examples:
> interrupts = <8>;
> clocks = <&syscon ASPEED_CLK_APB>;
> no-loopback-test;
> - aspeed,sirq-polarity-sense = <&syscon 0x70 25>;
> + aspeed,sirq-active-high;
> };
>
> ...
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-03-30 22:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 0:23 [PATCH 0/3] simplify Aspeed VUART SIRQ polarity DT config, add e3c246d4i BMC dts Zev Weiss
2021-03-30 0:23 ` [PATCH 1/3] drivers/tty/serial/8250: simplify Aspeed VUART SIRQ polarity DT config Zev Weiss
2021-03-30 0:23 ` [PATCH 2/3] dt-bindings: serial: 8250: update for aspeed, sirq-active-high Zev Weiss
2021-03-30 22:39 ` Rob Herring [this message]
2021-03-30 23:04 ` [PATCH 2/3] dt-bindings: serial: 8250: update for aspeed,sirq-active-high Zev Weiss
2021-04-01 0:56 ` [PATCH v2 0/3] simplify Aspeed VUART SIRQ polarity DT config Zev Weiss
2021-04-01 0:57 ` [PATCH v2 1/3] dt-bindings: serial: 8250: deprecate aspeed, sirq-polarity-sense Zev Weiss
2021-04-01 3:53 ` Joel Stanley
2021-04-01 0:57 ` [PATCH v2 2/3] drivers/tty/serial/8250: add DT property for aspeed vuart sirq polarity Zev Weiss
2021-04-01 4:15 ` Joel Stanley
2021-04-01 5:18 ` Zev Weiss
2021-04-01 5:34 ` Andrew Jeffery
2021-04-01 7:36 ` Zev Weiss
2021-04-01 0:57 ` [PATCH v2 3/3] dt-bindings: serial: 8250: add aspeed, sirq-active-high Zev Weiss
2021-04-01 4:04 ` Andrew Jeffery
2021-04-01 4:57 ` [PATCH v2 3/3] dt-bindings: serial: 8250: add aspeed,sirq-active-high Zev Weiss
2021-04-01 14:56 ` [PATCH v2 3/3] dt-bindings: serial: 8250: add aspeed, sirq-active-high Rob Herring
2021-03-30 23:26 ` [PATCH 2/3] dt-bindings: serial: 8250: update for " Joel Stanley
2021-03-30 0:23 ` [PATCH 3/3] ARM: dts: aspeed: add ASRock E3C246D4I BMC Zev Weiss
2021-03-31 7:41 ` Joel Stanley
2021-03-31 7:43 ` Joel Stanley
2021-03-31 7:50 ` Joel Stanley
2021-04-01 2:51 ` [PATCH] " Zev Weiss
2021-04-01 3:51 ` Joel Stanley
2021-04-01 4:09 ` Zev Weiss
2021-04-01 0:04 ` [PATCH 3/3] " Andrew Jeffery
2021-04-01 0:26 ` Zev Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330223902.GA837825@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=openbmc@lists.ozlabs.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).