openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "William A. Kennington III" <wak@google.com>
To: openbmc@lists.ozlabs.org
Cc: "William A. Kennington III" <wak@google.com>
Subject: [PATCH linux dev-5.10] net: npcm: Remove superfluous logging
Date: Wed, 31 Mar 2021 15:38:15 -0700	[thread overview]
Message-ID: <20210331223815.2994650-1-wak@google.com> (raw)

Any queries of the ethernet interface will enter the settings functions.
This causes dmesg to fill up with unnecessary log entries every time the
phy information is queried.

Signed-off-by: William A. Kennington III <wak@google.com>
---
 drivers/net/ethernet/nuvoton/npcm7xx_emc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/nuvoton/npcm7xx_emc.c b/drivers/net/ethernet/nuvoton/npcm7xx_emc.c
index 3e9b8b68fc55..28aaee3e80ff 100644
--- a/drivers/net/ethernet/nuvoton/npcm7xx_emc.c
+++ b/drivers/net/ethernet/nuvoton/npcm7xx_emc.c
@@ -1773,7 +1773,6 @@ static int npcm7xx_get_settings(struct net_device *netdev,
 	if (!phydev)
 		return -ENODEV;
 
-	dev_info(&ether->pdev->dev, "\n\nnpcm7xx_get_settings\n");
 	phy_ethtool_ksettings_get(phydev, cmd);
 
 	return 0;
@@ -1789,7 +1788,6 @@ static int npcm7xx_set_settings(struct net_device *netdev,
 	if (!phydev)
 		return -ENODEV;
 
-	dev_info(&ether->pdev->dev, "\n\nnpcm7xx_set_settings\n");
 	ret =  phy_ethtool_ksettings_set(phydev, cmd);
 
 	return ret;
-- 
2.31.0.291.g576ba9dcdaf-goog


             reply	other threads:[~2021-03-31 22:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31 22:38 William A. Kennington III [this message]
2021-03-31 22:56 ` [PATCH linux dev-5.10] net: npcm: Remove superfluous logging Joel Stanley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210331223815.2994650-1-wak@google.com \
    --to=wak@google.com \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).