From: Andrew Jeffery <andrew@aj.id.au>
To: joel@jms.id.au
Cc: openbmc@lists.ozlabs.org
Subject: [PATCH linux dev-5.10 v2 1/7] ipmi: kcs_bmc_aspeed: Fix less than zero comparison of a unsigned int
Date: Wed, 23 Jun 2021 13:08:48 +0930 [thread overview]
Message-ID: <20210623033854.587464-2-andrew@aj.id.au> (raw)
In-Reply-To: <20210623033854.587464-1-andrew@aj.id.au>
From: Colin Ian King <colin.king@canonical.com>
The comparisons of the unsigned int hw_type to less than zero always
false because it is unsigned. Fix this by using an int for the
assignment and less than zero check.
Addresses-Coverity: ("Unsigned compared against 0")
Fixes: 9d2df9a0ad80 ("ipmi: kcs_bmc_aspeed: Implement KCS SerIRQ configuration")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Message-Id: <20210616162913.15259-1-colin.king@canonical.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
---
drivers/char/ipmi/kcs_bmc_aspeed.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c
index 9753ed0a5be6..b555286016b1 100644
--- a/drivers/char/ipmi/kcs_bmc_aspeed.c
+++ b/drivers/char/ipmi/kcs_bmc_aspeed.c
@@ -301,13 +301,15 @@ static inline int aspeed_kcs_map_serirq_type(u32 dt_type)
static int aspeed_kcs_config_upstream_irq(struct aspeed_kcs_bmc *priv, u32 id, u32 dt_type)
{
unsigned int mask, val, hw_type;
+ int ret;
if (id > 15)
return -EINVAL;
- hw_type = aspeed_kcs_map_serirq_type(dt_type);
- if (hw_type < 0)
- return hw_type;
+ ret = aspeed_kcs_map_serirq_type(dt_type);
+ if (ret < 0)
+ return ret;
+ hw_type = ret;
priv->upstream_irq.mode = aspeed_kcs_irq_serirq;
priv->upstream_irq.id = id;
--
2.30.2
next prev parent reply other threads:[~2021-06-23 3:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 3:38 [PATCH linux dev-5.10 v2 0/7] Rework use of KCS devices for P10 platforms Andrew Jeffery
2021-06-23 3:38 ` Andrew Jeffery [this message]
2021-06-23 3:38 ` [PATCH linux dev-5.10 v2 2/7] ipmi: kcs_bmc: Add a "raw" character device interface Andrew Jeffery
2021-06-23 3:38 ` [PATCH linux dev-5.10 v2 3/7] ARM: configs: Enable IPMI KCS raw chardev Andrew Jeffery
2021-06-23 3:38 ` [PATCH linux dev-5.10 v2 4/7] ARM: dts: p10bmc: Drop the openbmc, mctp-lpc node Andrew Jeffery
2021-06-23 3:38 ` [PATCH linux dev-5.10 v2 5/7] misc: Remove obsolete mctp-lpc chardev Andrew Jeffery
2021-06-23 3:38 ` [PATCH linux dev-5.10 v2 6/7] ARM: dts: p10bmc: Switch to KCS 3 for MCTP binding Andrew Jeffery
2021-06-23 3:38 ` [PATCH linux dev-5.10 v2 7/7] ARM: dts: p10bmc: Enable KCS channel 2 Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623033854.587464-2-andrew@aj.id.au \
--to=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).