Hi Igor, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on scsi/for-next linus/master balbi-usb/testing/next v5.13-rc7 next-20210625] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Igor-Kononenko/usb-gadget-mass-storage-Improve-the-signature-of-SCSI-handler-function/20210627-061851 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: powerpc-randconfig-r035-20210627 (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/db2ec6f1e52293817f380a4875e01c36a4195c19 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Igor-Kononenko/usb-gadget-mass-storage-Improve-the-signature-of-SCSI-handler-function/20210627-061851 git checkout db2ec6f1e52293817f380a4875e01c36a4195c19 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from include/linux/printk.h:7, from include/linux/kernel.h:17, from include/asm-generic/bug.h:20, from arch/powerpc/include/asm/bug.h:109, from include/linux/bug.h:5, from arch/powerpc/include/asm/mmu.h:147, from arch/powerpc/include/asm/paca.h:18, from arch/powerpc/include/asm/current.h:13, from include/linux/sched.h:12, from include/linux/blkdev.h:5, from drivers/usb/gadget/function/f_mass_storage.c:201: drivers/usb/gadget/function/f_mass_storage.c: In function 'cdr_guess_medium_type': >> include/linux/kern_levels.h:5:18: warning: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'size_t' {aka 'long unsigned int'} [-Wformat=] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' 15 | #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ | ^~~~~~~~ include/linux/printk.h:427:9: note: in expansion of macro 'KERN_DEBUG' 427 | printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~~ drivers/usb/gadget/function/storage_common.h:24:4: note: in expansion of macro 'pr_debug' 24 | func("%s/%s: " fmt, *(lun)->name_pfx, \ | ^~~~ drivers/usb/gadget/function/storage_common.h:30:34: note: in expansion of macro '_LMSG' 30 | #define LDBG(lun, fmt, args...) _LMSG(pr_debug, lun, fmt, ## args) | ^~~~~ drivers/usb/gadget/function/f_mass_storage.c:1964:2: note: in expansion of macro 'LDBG' 1964 | LDBG(curlun, | ^~~~ drivers/usb/gadget/function/f_mass_storage.c:1965:27: note: format string is defined here 1965 | "Disc layout size (%u) exceeds all known media types, assuming BD - ROM !\n", | ~^ | | | unsigned int | %lu In file included from include/linux/printk.h:7, from include/linux/kernel.h:17, from include/asm-generic/bug.h:20, from arch/powerpc/include/asm/bug.h:109, from include/linux/bug.h:5, from arch/powerpc/include/asm/mmu.h:147, from arch/powerpc/include/asm/paca.h:18, from arch/powerpc/include/asm/current.h:13, from include/linux/sched.h:12, from include/linux/blkdev.h:5, from drivers/usb/gadget/function/f_mass_storage.c:201: include/linux/kern_levels.h:5:18: warning: format '%u' expects argument of type 'unsigned int', but argument 3 has type 'size_t' {aka 'long unsigned int'} [-Wformat=] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' 15 | #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ | ^~~~~~~~ include/linux/printk.h:427:9: note: in expansion of macro 'KERN_DEBUG' 427 | printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~~ drivers/usb/gadget/function/storage_common.h:27:4: note: in expansion of macro 'pr_debug' 27 | func("%s: " fmt, (lun)->name, ## args); \ | ^~~~ drivers/usb/gadget/function/storage_common.h:30:34: note: in expansion of macro '_LMSG' 30 | #define LDBG(lun, fmt, args...) _LMSG(pr_debug, lun, fmt, ## args) | ^~~~~ drivers/usb/gadget/function/f_mass_storage.c:1964:2: note: in expansion of macro 'LDBG' 1964 | LDBG(curlun, | ^~~~ drivers/usb/gadget/function/f_mass_storage.c:1965:27: note: format string is defined here 1965 | "Disc layout size (%u) exceeds all known media types, assuming BD - ROM !\n", | ~^ | | | unsigned int | %lu drivers/usb/gadget/function/f_mass_storage.c: At top level: drivers/usb/gadget/function/f_mass_storage.c:311:23: warning: initialized field overwritten [-Woverride-init] 311 | .do_check_command = &check_command_size_in_blocks | ^ drivers/usb/gadget/function/f_mass_storage.c:2231:4: note: in expansion of macro 'CDB_REG_CHECKER_BLK' 2231 | { CDB_REG_CHECKER_BLK(READ_6, 6, CDB_SIZE_FIELD_4, DATA_DIR_TO_HOST, | ^~~~~~~~~~~~~~~~~~~ drivers/usb/gadget/function/f_mass_storage.c:311:23: note: (near initialization for 'cdb_checker_table[6].do_check_command') 311 | .do_check_command = &check_command_size_in_blocks | ^ drivers/usb/gadget/function/f_mass_storage.c:2231:4: note: in expansion of macro 'CDB_REG_CHECKER_BLK' 2231 | { CDB_REG_CHECKER_BLK(READ_6, 6, CDB_SIZE_FIELD_4, DATA_DIR_TO_HOST, | ^~~~~~~~~~~~~~~~~~~ drivers/usb/gadget/function/f_mass_storage.c:311:23: warning: initialized field overwritten [-Woverride-init] 311 | .do_check_command = &check_command_size_in_blocks | ^ drivers/usb/gadget/function/f_mass_storage.c:2233:4: note: in expansion of macro 'CDB_REG_CHECKER_BLK' 2233 | { CDB_REG_CHECKER_BLK(READ_10, 10, CDB_SIZE_FIELD_7, DATA_DIR_TO_HOST, | ^~~~~~~~~~~~~~~~~~~ drivers/usb/gadget/function/f_mass_storage.c:311:23: note: (near initialization for 'cdb_checker_table[7].do_check_command') 311 | .do_check_command = &check_command_size_in_blocks | ^ drivers/usb/gadget/function/f_mass_storage.c:2233:4: note: in expansion of macro 'CDB_REG_CHECKER_BLK' 2233 | { CDB_REG_CHECKER_BLK(READ_10, 10, CDB_SIZE_FIELD_7, DATA_DIR_TO_HOST, | ^~~~~~~~~~~~~~~~~~~ drivers/usb/gadget/function/f_mass_storage.c:311:23: warning: initialized field overwritten [-Woverride-init] 311 | .do_check_command = &check_command_size_in_blocks | ^ drivers/usb/gadget/function/f_mass_storage.c:2235:4: note: in expansion of macro 'CDB_REG_CHECKER_BLK' 2235 | { CDB_REG_CHECKER_BLK(READ_12, 12, CDB_SIZE_FIELD_6, DATA_DIR_TO_HOST, | ^~~~~~~~~~~~~~~~~~~ drivers/usb/gadget/function/f_mass_storage.c:311:23: note: (near initialization for 'cdb_checker_table[8].do_check_command') 311 | .do_check_command = &check_command_size_in_blocks | ^ drivers/usb/gadget/function/f_mass_storage.c:2235:4: note: in expansion of macro 'CDB_REG_CHECKER_BLK' 2235 | { CDB_REG_CHECKER_BLK(READ_12, 12, CDB_SIZE_FIELD_6, DATA_DIR_TO_HOST, | ^~~~~~~~~~~~~~~~~~~ drivers/usb/gadget/function/f_mass_storage.c:311:23: warning: initialized field overwritten [-Woverride-init] 311 | .do_check_command = &check_command_size_in_blocks | ^ drivers/usb/gadget/function/f_mass_storage.c:2259:4: note: in expansion of macro 'CDB_REG_CHECKER_BLK' 2259 | { CDB_REG_CHECKER_BLK(VERIFY, 10, CDB_NO_SIZE_FIELD, DATA_DIR_NONE, -- drivers/usb/gadget/function/f_mass_storage.c: In function 'invalidate_sub': drivers/usb/gadget/function/f_mass_storage.c:1166:16: warning: variable 'rc' set but not used [-Wunused-but-set-variable] 1166 | unsigned long rc; | ^~ In file included from include/linux/kernel.h:17, from include/asm-generic/bug.h:20, from arch/powerpc/include/asm/bug.h:109, from include/linux/bug.h:5, from arch/powerpc/include/asm/mmu.h:147, from arch/powerpc/include/asm/paca.h:18, from arch/powerpc/include/asm/current.h:13, from include/linux/sched.h:12, from include/linux/blkdev.h:5, from drivers/usb/gadget/function/f_mass_storage.c:201: drivers/usb/gadget/function/f_mass_storage.c: In function 'cdr_guess_medium_type': >> include/linux/kern_levels.h:5:18: warning: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'size_t' {aka 'long unsigned int'} [-Wformat=] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/printk.h:140:10: note: in definition of macro 'no_printk' 140 | printk(fmt, ##__VA_ARGS__); \ | ^~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' 15 | #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ | ^~~~~~~~ include/linux/printk.h:430:12: note: in expansion of macro 'KERN_DEBUG' 430 | no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~~ drivers/usb/gadget/function/storage_common.h:24:4: note: in expansion of macro 'pr_debug' 24 | func("%s/%s: " fmt, *(lun)->name_pfx, \ | ^~~~ drivers/usb/gadget/function/storage_common.h:30:34: note: in expansion of macro '_LMSG' 30 | #define LDBG(lun, fmt, args...) _LMSG(pr_debug, lun, fmt, ## args) | ^~~~~ drivers/usb/gadget/function/f_mass_storage.c:1964:2: note: in expansion of macro 'LDBG' 1964 | LDBG(curlun, | ^~~~ drivers/usb/gadget/function/f_mass_storage.c:1965:27: note: format string is defined here 1965 | "Disc layout size (%u) exceeds all known media types, assuming BD - ROM !\n", | ~^ | | | unsigned int | %lu In file included from include/linux/kernel.h:17, from include/asm-generic/bug.h:20, from arch/powerpc/include/asm/bug.h:109, from include/linux/bug.h:5, from arch/powerpc/include/asm/mmu.h:147, from arch/powerpc/include/asm/paca.h:18, from arch/powerpc/include/asm/current.h:13, from include/linux/sched.h:12, from include/linux/blkdev.h:5, from drivers/usb/gadget/function/f_mass_storage.c:201: include/linux/kern_levels.h:5:18: warning: format '%u' expects argument of type 'unsigned int', but argument 3 has type 'size_t' {aka 'long unsigned int'} [-Wformat=] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/printk.h:140:10: note: in definition of macro 'no_printk' 140 | printk(fmt, ##__VA_ARGS__); \ | ^~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' 15 | #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ | ^~~~~~~~ include/linux/printk.h:430:12: note: in expansion of macro 'KERN_DEBUG' 430 | no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~~ drivers/usb/gadget/function/storage_common.h:27:4: note: in expansion of macro 'pr_debug' 27 | func("%s: " fmt, (lun)->name, ## args); \ | ^~~~ drivers/usb/gadget/function/storage_common.h:30:34: note: in expansion of macro '_LMSG' 30 | #define LDBG(lun, fmt, args...) _LMSG(pr_debug, lun, fmt, ## args) | ^~~~~ drivers/usb/gadget/function/f_mass_storage.c:1964:2: note: in expansion of macro 'LDBG' 1964 | LDBG(curlun, | ^~~~ drivers/usb/gadget/function/f_mass_storage.c:1965:27: note: format string is defined here 1965 | "Disc layout size (%u) exceeds all known media types, assuming BD - ROM !\n", | ~^ | | | unsigned int | %lu drivers/usb/gadget/function/f_mass_storage.c: At top level: drivers/usb/gadget/function/f_mass_storage.c:311:23: warning: initialized field overwritten [-Woverride-init] 311 | .do_check_command = &check_command_size_in_blocks | ^ drivers/usb/gadget/function/f_mass_storage.c:2231:4: note: in expansion of macro 'CDB_REG_CHECKER_BLK' 2231 | { CDB_REG_CHECKER_BLK(READ_6, 6, CDB_SIZE_FIELD_4, DATA_DIR_TO_HOST, | ^~~~~~~~~~~~~~~~~~~ drivers/usb/gadget/function/f_mass_storage.c:311:23: note: (near initialization for 'cdb_checker_table[6].do_check_command') 311 | .do_check_command = &check_command_size_in_blocks | ^ drivers/usb/gadget/function/f_mass_storage.c:2231:4: note: in expansion of macro 'CDB_REG_CHECKER_BLK' 2231 | { CDB_REG_CHECKER_BLK(READ_6, 6, CDB_SIZE_FIELD_4, DATA_DIR_TO_HOST, | ^~~~~~~~~~~~~~~~~~~ drivers/usb/gadget/function/f_mass_storage.c:311:23: warning: initialized field overwritten [-Woverride-init] 311 | .do_check_command = &check_command_size_in_blocks | ^ drivers/usb/gadget/function/f_mass_storage.c:2233:4: note: in expansion of macro 'CDB_REG_CHECKER_BLK' 2233 | { CDB_REG_CHECKER_BLK(READ_10, 10, CDB_SIZE_FIELD_7, DATA_DIR_TO_HOST, | ^~~~~~~~~~~~~~~~~~~ drivers/usb/gadget/function/f_mass_storage.c:311:23: note: (near initialization for 'cdb_checker_table[7].do_check_command') 311 | .do_check_command = &check_command_size_in_blocks | ^ drivers/usb/gadget/function/f_mass_storage.c:2233:4: note: in expansion of macro 'CDB_REG_CHECKER_BLK' 2233 | { CDB_REG_CHECKER_BLK(READ_10, 10, CDB_SIZE_FIELD_7, DATA_DIR_TO_HOST, | ^~~~~~~~~~~~~~~~~~~ drivers/usb/gadget/function/f_mass_storage.c:311:23: warning: initialized field overwritten [-Woverride-init] 311 | .do_check_command = &check_command_size_in_blocks | ^ drivers/usb/gadget/function/f_mass_storage.c:2235:4: note: in expansion of macro 'CDB_REG_CHECKER_BLK' 2235 | { CDB_REG_CHECKER_BLK(READ_12, 12, CDB_SIZE_FIELD_6, DATA_DIR_TO_HOST, | ^~~~~~~~~~~~~~~~~~~ drivers/usb/gadget/function/f_mass_storage.c:311:23: note: (near initialization for 'cdb_checker_table[8].do_check_command') 311 | .do_check_command = &check_command_size_in_blocks | ^ drivers/usb/gadget/function/f_mass_storage.c:2235:4: note: in expansion of macro 'CDB_REG_CHECKER_BLK' 2235 | { CDB_REG_CHECKER_BLK(READ_12, 12, CDB_SIZE_FIELD_6, DATA_DIR_TO_HOST, | ^~~~~~~~~~~~~~~~~~~ vim +5 include/linux/kern_levels.h 314ba3520e513a Joe Perches 2012-07-30 4 04d2c8c83d0e3a Joe Perches 2012-07-30 @5 #define KERN_SOH "\001" /* ASCII Start Of Header */ 04d2c8c83d0e3a Joe Perches 2012-07-30 6 #define KERN_SOH_ASCII '\001' 04d2c8c83d0e3a Joe Perches 2012-07-30 7 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org