* [PATCH] pinctrl: aspeed: placate kernel-doc warnings
@ 2021-07-23 3:48 Randy Dunlap
2021-07-23 3:53 ` Andrew Jeffery
2021-08-10 13:30 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2021-07-23 3:48 UTC (permalink / raw)
Cc: kernel test robot, linux-aspeed, Aditya Srivastava,
Andrew Jeffery, openbmc, Randy Dunlap, linux-gpio, Linus Walleij
Eliminate kernel-doc warnings in drivers/pinctrl/aspeed by using
proper kernel-doc notation.
Fixes these kernel-doc warnings:
drivers/pinctrl/aspeed/pinmux-aspeed.c:61: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Query the enabled or disabled state for a mux function's signal on a pin
drivers/pinctrl/aspeed/pinctrl-aspeed.c:135: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Search for the signal expression needed to enable the pin's signal for the
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: Aditya Srivastava <yashsri421@gmail.com>
Cc: Andrew Jeffery <andrew@aj.id.au>
Cc: linux-aspeed@lists.ozlabs.org
Cc: openbmc@lists.ozlabs.org
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
---
drivers/pinctrl/aspeed/pinctrl-aspeed.c | 4 ++--
drivers/pinctrl/aspeed/pinmux-aspeed.c | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
--- linux-next-20210722.orig/drivers/pinctrl/aspeed/pinmux-aspeed.c
+++ linux-next-20210722/drivers/pinctrl/aspeed/pinmux-aspeed.c
@@ -59,7 +59,8 @@ int aspeed_sig_desc_eval(const struct as
}
/**
- * Query the enabled or disabled state for a mux function's signal on a pin
+ * aspeed_sig_expr_eval - Query the enabled or disabled state for a
+ * mux function's signal on a pin
*
* @ctx: The driver context for the pinctrl IP
* @expr: An expression controlling the signal for a mux function on a pin
--- linux-next-20210722.orig/drivers/pinctrl/aspeed/pinctrl-aspeed.c
+++ linux-next-20210722/drivers/pinctrl/aspeed/pinctrl-aspeed.c
@@ -133,8 +133,8 @@ static int aspeed_disable_sig(struct asp
}
/**
- * Search for the signal expression needed to enable the pin's signal for the
- * requested function.
+ * aspeed_find_expr_by_name - Search for the signal expression needed to
+ * enable the pin's signal for the requested function.
*
* @exprs: List of signal expressions (haystack)
* @name: The name of the requested function (needle)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: aspeed: placate kernel-doc warnings
2021-07-23 3:48 [PATCH] pinctrl: aspeed: placate kernel-doc warnings Randy Dunlap
@ 2021-07-23 3:53 ` Andrew Jeffery
2021-08-10 13:30 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Jeffery @ 2021-07-23 3:53 UTC (permalink / raw)
To: Randy Dunlap
Cc: kbuild test robot, linux-aspeed, Aditya Srivastava, openbmc,
linux-gpio, Linus Walleij
On Fri, 23 Jul 2021, at 13:18, Randy Dunlap wrote:
> Eliminate kernel-doc warnings in drivers/pinctrl/aspeed by using
> proper kernel-doc notation.
>
> Fixes these kernel-doc warnings:
>
> drivers/pinctrl/aspeed/pinmux-aspeed.c:61: warning: This comment starts
> with '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
> * Query the enabled or disabled state for a mux function's signal
> on a pin
> drivers/pinctrl/aspeed/pinctrl-aspeed.c:135: warning: This comment
> starts with '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
> * Search for the signal expression needed to enable the pin's
> signal for the
>
Acked-by: Andrew Jeffery <andrew@aj.id.au>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: aspeed: placate kernel-doc warnings
2021-07-23 3:48 [PATCH] pinctrl: aspeed: placate kernel-doc warnings Randy Dunlap
2021-07-23 3:53 ` Andrew Jeffery
@ 2021-08-10 13:30 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2021-08-10 13:30 UTC (permalink / raw)
To: Randy Dunlap
Cc: kernel test robot, linux-aspeed, Aditya Srivastava,
Andrew Jeffery, OpenBMC Maillist, open list:GPIO SUBSYSTEM
On Fri, Jul 23, 2021 at 5:49 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> Eliminate kernel-doc warnings in drivers/pinctrl/aspeed by using
> proper kernel-doc notation.
>
> Fixes these kernel-doc warnings:
>
> drivers/pinctrl/aspeed/pinmux-aspeed.c:61: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Query the enabled or disabled state for a mux function's signal on a pin
> drivers/pinctrl/aspeed/pinctrl-aspeed.c:135: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Search for the signal expression needed to enable the pin's signal for the
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Aditya Srivastava <yashsri421@gmail.com>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: linux-aspeed@lists.ozlabs.org
> Cc: openbmc@lists.ozlabs.org
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-gpio@vger.kernel.org
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-10 13:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-23 3:48 [PATCH] pinctrl: aspeed: placate kernel-doc warnings Randy Dunlap
2021-07-23 3:53 ` Andrew Jeffery
2021-08-10 13:30 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).