* [PATCH] hwmon: (pmbus/ibm-cffps) Fix write bits for LED control
@ 2021-07-28 22:41 Brandon Wyman
2021-07-28 23:14 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Brandon Wyman @ 2021-07-28 22:41 UTC (permalink / raw)
To: Joel Stanley, openbmc, Guenter Roeck, Jean Delvare, linux-hwmon,
linux-kernel, Eddie James
Cc: B. J. Wyman
From: "B. J. Wyman" <bjwyman@gmail.com>
When doing a PMBus write for the LED control on the IBM Common Form
Factor Power Supplies (ibm-cffps), the DAh command requires that bit 7
be low and bit 6 be high in order to indicate that you are truly
attempting to do a write.
Signed-off-by: B. J. Wyman <bjwyman@gmail.com>
---
drivers/hwmon/pmbus/ibm-cffps.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/hwmon/pmbus/ibm-cffps.c b/drivers/hwmon/pmbus/ibm-cffps.c
index 5668d8305b78..df712ce4b164 100644
--- a/drivers/hwmon/pmbus/ibm-cffps.c
+++ b/drivers/hwmon/pmbus/ibm-cffps.c
@@ -50,9 +50,9 @@
#define CFFPS_MFR_VAUX_FAULT BIT(6)
#define CFFPS_MFR_CURRENT_SHARE_WARNING BIT(7)
-#define CFFPS_LED_BLINK BIT(0)
-#define CFFPS_LED_ON BIT(1)
-#define CFFPS_LED_OFF BIT(2)
+#define CFFPS_LED_BLINK (BIT(0) | BIT(6))
+#define CFFPS_LED_ON (BIT(1) | BIT(6))
+#define CFFPS_LED_OFF (BIT(2) | BIT(6))
#define CFFPS_BLINK_RATE_MS 250
enum {
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: (pmbus/ibm-cffps) Fix write bits for LED control
2021-07-28 22:41 [PATCH] hwmon: (pmbus/ibm-cffps) Fix write bits for LED control Brandon Wyman
@ 2021-07-28 23:14 ` Guenter Roeck
2021-08-06 22:35 ` Brandon Wyman
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2021-07-28 23:14 UTC (permalink / raw)
To: Brandon Wyman, Joel Stanley, openbmc, Jean Delvare, linux-hwmon,
linux-kernel, Eddie James
On 7/28/21 3:41 PM, Brandon Wyman wrote:
> From: "B. J. Wyman" <bjwyman@gmail.com>
>
> When doing a PMBus write for the LED control on the IBM Common Form
> Factor Power Supplies (ibm-cffps), the DAh command requires that bit 7
> be low and bit 6 be high in order to indicate that you are truly
> attempting to do a write.
>
> Signed-off-by: B. J. Wyman <bjwyman@gmail.com>
Please be consistent and use "Brandon Wyman".
Guenter
> ---
> drivers/hwmon/pmbus/ibm-cffps.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hwmon/pmbus/ibm-cffps.c b/drivers/hwmon/pmbus/ibm-cffps.c
> index 5668d8305b78..df712ce4b164 100644
> --- a/drivers/hwmon/pmbus/ibm-cffps.c
> +++ b/drivers/hwmon/pmbus/ibm-cffps.c
> @@ -50,9 +50,9 @@
> #define CFFPS_MFR_VAUX_FAULT BIT(6)
> #define CFFPS_MFR_CURRENT_SHARE_WARNING BIT(7)
>
> -#define CFFPS_LED_BLINK BIT(0)
> -#define CFFPS_LED_ON BIT(1)
> -#define CFFPS_LED_OFF BIT(2)
> +#define CFFPS_LED_BLINK (BIT(0) | BIT(6))
> +#define CFFPS_LED_ON (BIT(1) | BIT(6))
> +#define CFFPS_LED_OFF (BIT(2) | BIT(6))
> #define CFFPS_BLINK_RATE_MS 250
>
> enum {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: (pmbus/ibm-cffps) Fix write bits for LED control
2021-07-28 23:14 ` Guenter Roeck
@ 2021-08-06 22:35 ` Brandon Wyman
0 siblings, 0 replies; 3+ messages in thread
From: Brandon Wyman @ 2021-08-06 22:35 UTC (permalink / raw)
To: Guenter Roeck
Cc: linux-hwmon, Jean Delvare, OpenBMC Maillist, Eddie James, linux-kernel
On Wed, Jul 28, 2021 at 6:14 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 7/28/21 3:41 PM, Brandon Wyman wrote:
> > From: "B. J. Wyman" <bjwyman@gmail.com>
> >
> > When doing a PMBus write for the LED control on the IBM Common Form
> > Factor Power Supplies (ibm-cffps), the DAh command requires that bit 7
> > be low and bit 6 be high in order to indicate that you are truly
> > attempting to do a write.
> >
> > Signed-off-by: B. J. Wyman <bjwyman@gmail.com>
>
> Please be consistent and use "Brandon Wyman".
Ack. Curiously, that is the first time someone has pointed out that
inconsistency.
>
> Guenter
>
> > ---
> > drivers/hwmon/pmbus/ibm-cffps.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/hwmon/pmbus/ibm-cffps.c b/drivers/hwmon/pmbus/ibm-cffps.c
> > index 5668d8305b78..df712ce4b164 100644
> > --- a/drivers/hwmon/pmbus/ibm-cffps.c
> > +++ b/drivers/hwmon/pmbus/ibm-cffps.c
> > @@ -50,9 +50,9 @@
> > #define CFFPS_MFR_VAUX_FAULT BIT(6)
> > #define CFFPS_MFR_CURRENT_SHARE_WARNING BIT(7)
> >
> > -#define CFFPS_LED_BLINK BIT(0)
> > -#define CFFPS_LED_ON BIT(1)
> > -#define CFFPS_LED_OFF BIT(2)
> > +#define CFFPS_LED_BLINK (BIT(0) | BIT(6))
> > +#define CFFPS_LED_ON (BIT(1) | BIT(6))
> > +#define CFFPS_LED_OFF (BIT(2) | BIT(6))
> > #define CFFPS_BLINK_RATE_MS 250
> >
> > enum {
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-06 22:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-28 22:41 [PATCH] hwmon: (pmbus/ibm-cffps) Fix write bits for LED control Brandon Wyman
2021-07-28 23:14 ` Guenter Roeck
2021-08-06 22:35 ` Brandon Wyman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).