Re: [PATCH 1/2] soc: aspeed: Add LPC mailbox support

From: kernel test robot <lkp@intel.com>
To: Chia-Wei Wang <chiawei_wang@aspeedtech.com>,
	robh+dt@kernel.org, joel@jms.id.au, andrew@aj.id.au,
	cyrilbur@gmail.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	openbmc@lists.ozlabs.org
Cc: kbuild-all@lists.01.org
Subject: Re: [PATCH 1/2] soc: aspeed: Add LPC mailbox support
Date: Mon, 16 Aug 2021 03:05:15 +0800	[thread overview]
Message-ID: <202108160221.59KN8jgQ-lkp@intel.com> (raw)
In-Reply-To: <20210813054758.13189-2-chiawei_wang@aspeedtech.com>

[-- Attachment #1: Type: text/plain, Size: 2510 bytes --]

Hi Chia-Wei,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on joel-aspeed/for-next]
[also build test WARNING on v5.14-rc5 next-20210813]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Chia-Wei-Wang/aspeed-Add-LPC-mailbox-support/20210813-134908
base:   https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git for-next
config: h8300-randconfig-s031-20210816 (attached as .config)
compiler: h8300-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-348-gf0e6938b-dirty
        # https://github.com/0day-ci/linux/commit/72c5a69dc779f5b4af59eb6d47d0e1086be814af
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Chia-Wei-Wang/aspeed-Add-LPC-mailbox-support/20210813-134908
        git checkout 72c5a69dc779f5b4af59eb6d47d0e1086be814af
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=h8300 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
>> drivers/soc/aspeed/aspeed-lpc-mbox.c:240:27: sparse: sparse: incorrect type in initializer (different base types) @@     expected restricted __poll_t ( *poll )( ... ) @@     got unsigned int ( * )( ... ) @@
   drivers/soc/aspeed/aspeed-lpc-mbox.c:240:27: sparse:     expected restricted __poll_t ( *poll )( ... )
   drivers/soc/aspeed/aspeed-lpc-mbox.c:240:27: sparse:     got unsigned int ( * )( ... )

vim +240 drivers/soc/aspeed/aspeed-lpc-mbox.c

   232	
   233	static const struct file_operations aspeed_mbox_fops = {
   234		.owner		= THIS_MODULE,
   235		.llseek		= no_seek_end_llseek,
   236		.read		= aspeed_mbox_read,
   237		.write		= aspeed_mbox_write,
   238		.open		= aspeed_mbox_open,
   239		.release	= aspeed_mbox_release,
 > 240		.poll		= aspeed_mbox_poll,
   241		.unlocked_ioctl	= aspeed_mbox_ioctl,
   242	};
   243	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36610 bytes --]