From: Guenter Roeck <linux@roeck-us.net>
To: Brandon Wyman <bjwyman@gmail.com>
Cc: linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
openbmc@lists.ozlabs.org, Eddie James <eajames@linux.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (pmbus/ibm-cffps) Do not swap max_power_out
Date: Sat, 28 Aug 2021 08:52:50 -0700 [thread overview]
Message-ID: <20210828155250.GA820265@roeck-us.net> (raw)
In-Reply-To: <20210827230433.3596370-1-bjwyman@gmail.com>
On Fri, Aug 27, 2021 at 11:04:33PM +0000, Brandon Wyman wrote:
> The bytes for max_power_out from the ibm-cffps devices do not need to be
> swapped.
>
> Signed-off-by: Brandon Wyman <bjwyman@gmail.com>
Eddie, can you confirm this ?
Thanks,
Guenter
> ---
> drivers/hwmon/pmbus/ibm-cffps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/pmbus/ibm-cffps.c b/drivers/hwmon/pmbus/ibm-cffps.c
> index df712ce4b164..29b77f192c9e 100644
> --- a/drivers/hwmon/pmbus/ibm-cffps.c
> +++ b/drivers/hwmon/pmbus/ibm-cffps.c
> @@ -171,7 +171,7 @@ static ssize_t ibm_cffps_debugfs_read(struct file *file, char __user *buf,
> cmd = CFFPS_SN_CMD;
> break;
> case CFFPS_DEBUGFS_MAX_POWER_OUT:
> - rc = i2c_smbus_read_word_swapped(psu->client,
> + rc = i2c_smbus_read_word_data(psu->client,
> CFFPS_MAX_POWER_OUT_CMD);
> if (rc < 0)
> return rc;
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-08-28 15:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 23:04 [PATCH] hwmon: (pmbus/ibm-cffps) Do not swap max_power_out Brandon Wyman
2021-08-28 15:52 ` Guenter Roeck [this message]
2021-08-30 13:50 ` Eddie James
2021-08-30 15:34 ` Guenter Roeck
2021-08-30 20:11 ` Eddie James
2021-08-30 21:05 ` Guenter Roeck
2021-08-30 21:07 ` Brandon Wyman
2021-08-30 21:27 ` Guenter Roeck
2021-08-31 20:18 ` Brandon Wyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210828155250.GA820265@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bjwyman@gmail.com \
--cc=eajames@linux.ibm.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).