From: Paul Fertser <firstname.lastname@example.org> To: Chia-Wei Wang <email@example.com> Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, Konstantin Klubnichkin <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH v2 0/3] arm: aspeed: Add UART routing support Date: Wed, 8 Sep 2021 12:42:49 +0300 [thread overview] Message-ID: <20210908094248.GZ23326@home.paul.comp> (raw) In-Reply-To: <firstname.lastname@example.org> Hello, On Thu, Sep 02, 2021 at 10:18:13AM +0800, Chia-Wei Wang wrote: > Add UART routing driver and the device tree nodes. Thank you for working on exposing this functionality in upstreamable way, that's so much better than all the register-level hacks in U-Boot and similar approaches! One (somewhat) related question that I hope you do not mind answering: is there anything special regarding the routing or other configuration that needs to be done for VUART to work with IRQs? The reason I ask is that I have tried hard (and I know several other developers who have too) to use VUART functionality but somehow as soon as Linux was booting on host and starting to use the IRQ-based 16550 driver the communication was halted both ways. Basically, the BMC firmware was enabling VUART in DTS, then setting LPC address to 0x3F8 and LPC IRQ to 4 and reading/writing using the corresponding /dev/ttyS* node. The datasheet is not clearly telling what other actions need to be performed for this to work. Not using VUART and instead routing UART1 lines with exactly the same pinctrl/pinmux worked just fine. One detail is that with VUART the host wasn't seeing new interrupts but when they were simulated by exporting the LPC interrupt pin via /sys/class/gpio and toggling it manually the data was getting through. Does UART1 need some explicit disabling for VUART IRQs to work? It looks like setting LPC address and IRQ number in VUART is enough to override the register part but probably not for the interrupt? -- Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! mailto:email@example.com
next prev parent reply other threads:[~2021-09-08 9:43 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-02 2:18 Chia-Wei Wang 2021-09-02 2:18 ` [PATCH v2 1/3] dt-bindings: aspeed-lpc: Add UART routing compatible string Chia-Wei Wang 2021-09-07 18:46 ` Rob Herring 2021-09-08 5:06 ` ChiaWei Wang 2021-09-02 2:18 ` [PATCH v2 2/3] soc: aspeed: Add LPC UART routing support Chia-Wei Wang 2021-09-02 2:25 ` ChiaWei Wang 2021-09-02 2:18 ` [PATCH v2 2/3] soc: aspeed: Add " Chia-Wei Wang 2021-09-02 2:18 ` [PATCH v2 3/3] ARM: dts: aspeed: Add uart routing to device tree Chia-Wei Wang 2021-09-08 9:42 ` Paul Fertser [this message] 2021-09-08 10:18 ` [PATCH v2 0/3] arm: aspeed: Add UART routing support ChiaWei Wang 2021-09-08 10:52 ` Paul Fertser 2021-09-08 11:27 ` VUART compatibility (was: Re: [PATCH v2 0/3] arm: aspeed: Add UART routing support) Paul Fertser 2021-09-08 13:19 ` [PATCH v2 0/3] arm: aspeed: Add UART routing support Oskar Senft 2021-09-09 6:52 ` [External] " Lei Yu 2021-09-09 8:32 ` ChiaWei Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210908094248.GZ23326@home.paul.comp \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v2 0/3] arm: aspeed: Add UART routing support' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).