* [PATCH v2 0/2] Fix incorrect resolution detected
@ 2021-11-10 8:00 Jammy Huang
2021-11-10 8:00 ` [PATCH v2 1/2] media: aspeed: Add macro for the fields of the mode-detect registers Jammy Huang
2021-11-10 8:00 ` [PATCH v2 2/2] media: aspeed: Fix incorrect resolution detected Jammy Huang
0 siblings, 2 replies; 3+ messages in thread
From: Jammy Huang @ 2021-11-10 8:00 UTC (permalink / raw)
To: eajames, mchehab, joel, andrew, linux-media, openbmc,
linux-arm-kernel, linux-aspeed, linux-kernel
This series fixes incorrect resolution detected once in a while.
Changes in v2:
- Separate the patch into two patches
Jammy Huang (2):
media: aspeed: Add macro for the fields of the mode-detect registers
media: aspeed: Fix incorrect resolution detected
drivers/media/platform/aspeed-video.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 1/2] media: aspeed: Add macro for the fields of the mode-detect registers
2021-11-10 8:00 [PATCH v2 0/2] Fix incorrect resolution detected Jammy Huang
@ 2021-11-10 8:00 ` Jammy Huang
2021-11-10 8:00 ` [PATCH v2 2/2] media: aspeed: Fix incorrect resolution detected Jammy Huang
1 sibling, 0 replies; 3+ messages in thread
From: Jammy Huang @ 2021-11-10 8:00 UTC (permalink / raw)
To: eajames, mchehab, joel, andrew, linux-media, openbmc,
linux-arm-kernel, linux-aspeed, linux-kernel
VE_MODE_DT_HOR_TOLER: the tolerance in detecting for stable horizontal
signal.
VE_MODE_DT_VER_TOLER: the tolerance in detecting for stable vertical
signal.
VE_MODE_DT_HOR_STABLE: the minimum required count in detecting stable
HSYNC signal to set mode detection horizontal signal stable.
VE_MODE_DT_VER_STABLE: the minimum required count in detecting stable
VSYNC signal to set mode detection vertical signal stable.
Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
---
drivers/media/platform/aspeed-video.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c
index 5da52646b298..996afbb87ee9 100644
--- a/drivers/media/platform/aspeed-video.c
+++ b/drivers/media/platform/aspeed-video.c
@@ -196,6 +196,12 @@
#define VE_INTERRUPT_VSYNC_DESC BIT(11)
#define VE_MODE_DETECT 0x30c
+#define VE_MODE_DT_HOR_TOLER GENMASK(31, 28)
+#define VE_MODE_DT_VER_TOLER GENMASK(27, 24)
+#define VE_MODE_DT_HOR_STABLE GENMASK(23, 20)
+#define VE_MODE_DT_VER_STABLE GENMASK(19, 16)
+#define VE_MODE_DT_EDG_THROD GENMASK(15, 8)
+
#define VE_MEM_RESTRICT_START 0x310
#define VE_MEM_RESTRICT_END 0x314
@@ -1199,7 +1205,12 @@ static void aspeed_video_init_regs(struct aspeed_video *video)
aspeed_video_write(video, VE_SCALING_FILTER3, 0x00200000);
/* Set mode detection defaults */
- aspeed_video_write(video, VE_MODE_DETECT, 0x22666500);
+ aspeed_video_write(video, VE_MODE_DETECT,
+ FIELD_PREP(VE_MODE_DT_HOR_TOLER, 2) |
+ FIELD_PREP(VE_MODE_DT_VER_TOLER, 2) |
+ FIELD_PREP(VE_MODE_DT_HOR_STABLE, 6) |
+ FIELD_PREP(VE_MODE_DT_VER_STABLE, 6) |
+ FIELD_PREP(VE_MODE_DT_EDG_THROD, 0x65));
aspeed_video_write(video, VE_BCD_CTRL, 0);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] media: aspeed: Fix incorrect resolution detected
2021-11-10 8:00 [PATCH v2 0/2] Fix incorrect resolution detected Jammy Huang
2021-11-10 8:00 ` [PATCH v2 1/2] media: aspeed: Add macro for the fields of the mode-detect registers Jammy Huang
@ 2021-11-10 8:00 ` Jammy Huang
1 sibling, 0 replies; 3+ messages in thread
From: Jammy Huang @ 2021-11-10 8:00 UTC (permalink / raw)
To: eajames, mchehab, joel, andrew, linux-media, openbmc,
linux-arm-kernel, linux-aspeed, linux-kernel
During successive timing-change, resolution detected could be incorrect,
for example. Using remote KVM to do Centos-8.2 installation, the timing
detected could be only 1920x471 for 1920x1200.
Increase min-required-count of stable signal to fix the problem.
Fixes: d2b4387f3bdf ("media: platform: Add Aspeed Video Engine driver")
Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
---
drivers/media/platform/aspeed-video.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c
index 996afbb87ee9..625a77ddb479 100644
--- a/drivers/media/platform/aspeed-video.c
+++ b/drivers/media/platform/aspeed-video.c
@@ -1208,8 +1208,8 @@ static void aspeed_video_init_regs(struct aspeed_video *video)
aspeed_video_write(video, VE_MODE_DETECT,
FIELD_PREP(VE_MODE_DT_HOR_TOLER, 2) |
FIELD_PREP(VE_MODE_DT_VER_TOLER, 2) |
- FIELD_PREP(VE_MODE_DT_HOR_STABLE, 6) |
- FIELD_PREP(VE_MODE_DT_VER_STABLE, 6) |
+ FIELD_PREP(VE_MODE_DT_HOR_STABLE, 10) |
+ FIELD_PREP(VE_MODE_DT_VER_STABLE, 10) |
FIELD_PREP(VE_MODE_DT_EDG_THROD, 0x65));
aspeed_video_write(video, VE_BCD_CTRL, 0);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-10 8:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-10 8:00 [PATCH v2 0/2] Fix incorrect resolution detected Jammy Huang
2021-11-10 8:00 ` [PATCH v2 1/2] media: aspeed: Add macro for the fields of the mode-detect registers Jammy Huang
2021-11-10 8:00 ` [PATCH v2 2/2] media: aspeed: Fix incorrect resolution detected Jammy Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).