From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,HTML_FONT_LOW_CONTRAST,HTML_MESSAGE, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D5A6C2D0A3 for ; Fri, 6 Nov 2020 05:47:14 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB09220867 for ; Fri, 6 Nov 2020 05:47:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="RWYscYUd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB09220867 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CS8Xs6JlMzDrFn for ; Fri, 6 Nov 2020 16:47:09 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.vnet.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=tomjose@linux.vnet.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=RWYscYUd; dkim-atps=neutral Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CS8W83RVczDrCG for ; Fri, 6 Nov 2020 16:45:38 +1100 (AEDT) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0A65WkDt084612 for ; Fri, 6 Nov 2020 00:45:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type; s=pp1; bh=ZOASP8VA55UNQpdfbDwb8vr77k/jcF9m4AfIU3fdVzo=; b=RWYscYUdslERwpkFlS4k3rAktu7m2aVq+MZ0fPbniEaIDvJLorfLR6CBlZG9HcuHyGhi YV3t/Rd1bz4pEsbKSIWg92Na825Z9P+Bwg/lKItd4NwPzYC8exs3XBT6nxCfRRTi8Wp9 r1/lCBXK4TV2vHjPUi/kE01zc2dzINB8pYCYg2LcDCdCBvXbuztEz6HSGi9hP//fvu1V BLkLfC1i3ma2IG1kLwIqLY7np2lIwgmsb4vWM/Z+pF7G+GfyUcWG8CMXCatBmm1qVJxm L/0bhjecSHArSiShpGwSREp5WdWr/gONAh6kDgsQa+0pDN/iaPlWjDQUUS3XIkMgQSPD vw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 34mhxk4318-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 06 Nov 2020 00:45:35 -0500 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0A65Wpre088180 for ; Fri, 6 Nov 2020 00:45:35 -0500 Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com with ESMTP id 34mhxk4305-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Nov 2020 00:45:35 -0500 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0A65hFHt025019; Fri, 6 Nov 2020 05:45:32 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma06ams.nl.ibm.com with ESMTP id 34h0fcx5qq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Nov 2020 05:45:32 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0A65jUxH58130696 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 6 Nov 2020 05:45:30 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 706A811C058; Fri, 6 Nov 2020 05:45:30 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5E45A11C04C; Fri, 6 Nov 2020 05:45:28 +0000 (GMT) Received: from [9.206.169.84] (unknown [9.206.169.84]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Fri, 6 Nov 2020 05:45:27 +0000 (GMT) Subject: Re: Firmware Version in ipmi mc info To: Shakeeb B K References: From: TOM JOSEPH Message-ID: <352ce958-186c-a26c-382f-d21ed26729ef@linux.vnet.ibm.com> Date: Fri, 6 Nov 2020 11:15:22 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------E0F01B8CA93ED9E96F4F25CC" Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-11-06_01:2020-11-05, 2020-11-06 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 mlxlogscore=999 clxscore=1015 adultscore=0 impostorscore=0 bulkscore=0 spamscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011060038 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: openbmc@lists.ozlabs.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" This is a multi-part message in MIME format. --------------E0F01B8CA93ED9E96F4F25CC Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Hello Shakeeb, Typically there is a D-Bus object for each version and that implements the xyz.openbmc_project.Software.Version interface. /xyz/openbmc_project/software doesn't implement the interface. busctl tree xyz.openbmc_project.Software.BMC.Updater └─/xyz   └─/xyz/openbmc_project     └─/xyz/openbmc_project/software       ├─/xyz/openbmc_project/software/6b6a7c53       └─/xyz/openbmc_project/software/76174d14 I guess the upstream implementation of this command is broken with the latest version format. We discussed this in the community, work is not done yet. https://lists.ozlabs.org/pipermail/openbmc/2020-August/022598.html Regards, Tom On 06-11-2020 09:38, Shakeeb B K wrote: > Hi Tom, Thanks for the reply. But it doesn't seem to work as expected. > I'm looking at... > This Message Is From an External Sender > This message came from outside your organization. > > Hi Tom, > > Thanks for the reply. > But it doesn't seem to work as expected. I'm looking at the > witherspoon-bmc on QEMU. > > root@witherspoon:~# systemctl status > xyz.openbmc_project.Software.BMC.Updater > * *xyz.openbmc_project.Software.BMC.Updater.service* - OpenBMC > Software Update Manager >      Loaded: loaded > (/lib/systemd/system/xyz.openbmc_project.Software.BMC.Updater.service; > enabled; vendor preset: enabled) >     Drop-In: > /lib/systemd/system/xyz.openbmc_project.Software.BMC.Updater.service.d >              `-software-bmc-updater.conf >      Active: *active (running)* since Thu 2020-11-05 14:10:57 UTC; 13h ago >    Main PID: 387 (phosphor-image-) >      CGroup: > /system.slice/xyz.openbmc_project.Software.BMC.Updater.service >              `-387 /usr/bin/phosphor-image-updater > > Nov 05 14:10:53 witherspoon systemd[1]: Starting OpenBMC Software > Update Manager... > Nov 05 14:10:57 witherspoon systemd[1]: Started OpenBMC Software > Update Manager. > > root@witherspoon:~# busctl get-property xyz.openbmc_project.State.BMC > /xyz/openbmc_project/state/bmc0 xyz.openbmc_project.State.BMC > CurrentBMCState > s "*xyz.openbmc_project.State.BMC.BMCState.Ready*" > > *root@witherspoon:~# busctl get-property > xyz.openbmc_project.Software.Version /xyz/openbmc_project/software > xyz.openbmc_project.Software.Version Version > Failed to get property Version on interface > xyz.openbmc_project.Software.Version: Unknown interface > xyz.openbmc_project.Software.Version or property Version.* > > root@witherspoon:~# busctl introspect --no-pager > xyz.openbmc_project.Software.Version /xyz/openbmc_project/software > NAME                                TYPE      SIGNATURE  RESULT/VALUE >  FLAGS > org.freedesktop.DBus.Introspectable interface -          -           - > .Introspect                         method    -          s           - > org.freedesktop.DBus.ObjectManager  interface -          -           - > .GetManagedObjects                  method    -  a{oa{sa{sv}}} - > .InterfacesAdded                    signal    oa{sa{sv}} -           - > .InterfacesRemoved                  signal    oas        -           - > org.freedesktop.DBus.Peer           interface -          -           - > .GetMachineId                       method    -          s           - > .Ping                               method    -          -           - > org.freedesktop.DBus.Properties     interface -          -           - > .Get                                method    ss         v           - > .GetAll                             method    s  a{sv}         - > .Set                                method    ssv        -           - > .PropertiesChanged                  signal    sa{sv}as   -           - > > > Thanks, > Shakeeb > > On Fri, Nov 6, 2020 at 8:37 AM TOM JOSEPH > wrote: > > Hey Shakeeb, > > The service implementing the xyz.openbmc_project.Software.Version > should be running in the case of a normal boot as well. In our > systems the service is xyz.openbmc_project.Software.BMC.Updater > and the Version property is populated when the BMCState is Ready. > > Regards, > Tom > > On 05-11-2020 20:02, Shakeeb B K wrote: >> Hi All, Currently the ipmi handler for "mc info" command >> depends on the "Version"... >> This Message Is From an External Sender >> This message came from outside your organization. >> >> Hi All, >> >> Currently the ipmi handler for "mc info" command depends on the >> "Version" property on >> interface xyz.openbmc_project.Software.Version. >> But this is getting populated only on the image update path by >> phosphor-bmc-code-mgmt. >> Shouldn't the version be set on a normal boot as well? Is this a >> gap in current implementation? >> >> Thanks, >> Shakeeb > --------------E0F01B8CA93ED9E96F4F25CC Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit

Hello Shakeeb,

Typically there is a D-Bus object for each version and that implements the xyz.openbmc_project.Software.Version interface. /xyz/openbmc_project/software doesn't implement the interface.

busctl tree xyz.openbmc_project.Software.BMC.Updater
└─/xyz
  └─/xyz/openbmc_project
    └─/xyz/openbmc_project/software
      ├─/xyz/openbmc_project/software/6b6a7c53
      └─/xyz/openbmc_project/software/76174d14

I guess the upstream implementation of this command is broken with the latest version format. We discussed this in the community, work is not done yet. https://lists.ozlabs.org/pipermail/openbmc/2020-August/022598.html

Regards,
Tom


On 06-11-2020 09:38, Shakeeb B K wrote:
This Message Is From an External Sender
This message came from outside your organization.
Hi Tom,

Thanks for the reply.
But it doesn't seem to work as expected. I'm looking at the witherspoon-bmc on QEMU.

root@witherspoon:~# systemctl status xyz.openbmc_project.Software.BMC.Updater
* xyz.openbmc_project.Software.BMC.Updater.service - OpenBMC Software Update Manager
     Loaded: loaded (/lib/systemd/system/xyz.openbmc_project.Software.BMC.Updater.service; enabled; vendor preset: enabled)
    Drop-In: /lib/systemd/system/xyz.openbmc_project.Software.BMC.Updater.service.d
             `-software-bmc-updater.conf
     Active: active (running) since Thu 2020-11-05 14:10:57 UTC; 13h ago
   Main PID: 387 (phosphor-image-)
     CGroup: /system.slice/xyz.openbmc_project.Software.BMC.Updater.service
             `-387 /usr/bin/phosphor-image-updater

Nov 05 14:10:53 witherspoon systemd[1]: Starting OpenBMC Software Update Manager...
Nov 05 14:10:57 witherspoon systemd[1]: Started OpenBMC Software Update Manager.

root@witherspoon:~# busctl get-property xyz.openbmc_project.State.BMC /xyz/openbmc_project/state/bmc0 xyz.openbmc_project.State.BMC CurrentBMCState
s "xyz.openbmc_project.State.BMC.BMCState.Ready"

root@witherspoon:~# busctl get-property xyz.openbmc_project.Software.Version /xyz/openbmc_project/software xyz.openbmc_project.Software.Version Version
Failed to get property Version on interface xyz.openbmc_project.Software.Version: Unknown interface xyz.openbmc_project.Software.Version or property Version.


root@witherspoon:~# busctl introspect --no-pager xyz.openbmc_project.Software.Version /xyz/openbmc_project/software
NAME                                TYPE      SIGNATURE  RESULT/VALUE  FLAGS
org.freedesktop.DBus.Introspectable interface -          -             -
.Introspect                         method    -          s             -
org.freedesktop.DBus.ObjectManager  interface -          -             -
.GetManagedObjects                  method    -          a{oa{sa{sv}}} -
.InterfacesAdded                    signal    oa{sa{sv}} -             -
.InterfacesRemoved                  signal    oas        -             -
org.freedesktop.DBus.Peer           interface -          -             -
.GetMachineId                       method    -          s             -
.Ping                               method    -          -             -
org.freedesktop.DBus.Properties     interface -          -             -
.Get                                method    ss         v             -
.GetAll                             method    s          a{sv}         -
.Set                                method    ssv        -             -
.PropertiesChanged                  signal    sa{sv}as   -             -



Thanks,
Shakeeb

On Fri, Nov 6, 2020 at 8:37 AM TOM JOSEPH <tomjose@linux.vnet.ibm.com> wrote:

Hey Shakeeb,

The service implementing the xyz.openbmc_project.Software.Version should be running in the case of a normal boot as well. In our systems the service is xyz.openbmc_project.Software.BMC.Updater and the Version property is populated when the BMCState is Ready.

Regards,
Tom

On 05-11-2020 20:02, Shakeeb B K wrote:
Hi All, Currently the ipmi handler for "mc info" command depends on the "Version"...                                                                                                                                                                                     
This Message Is From an External Sender
This message came from outside your organization.
Hi All,

Currently the ipmi handler for "mc info" command depends on the "Version" property on interface xyz.openbmc_project.Software.Version. 
But this is getting populated only on the image update path by phosphor-bmc-code-mgmt.
Shouldn't the version be set on a normal boot as well? Is this a gap in current implementation?

Thanks,
Shakeeb
--------------E0F01B8CA93ED9E96F4F25CC--