From: Eddie James <eajames@linux.ibm.com>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
Ryan Chen <ryan_chen@aspeedtech.com>,
linux-aspeed@lists.ozlabs.org, Andrew Jeffery <andrew@aj.id.au>,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v3] media: aspeed-video: ignore interrupts that aren't enabled
Date: Wed, 01 Sep 2021 10:07:24 -0500 [thread overview]
Message-ID: <46edf81d60a38747f7d2511f840253a1c6867652.camel@linux.ibm.com> (raw)
In-Reply-To: <20210617220229.7352-1-zev@bewilderbeest.net>
On Thu, 2021-06-17 at 17:02 -0500, Zev Weiss wrote:
> As partially addressed in commit 65d270acb2d6 ("media: aspeed: clear
> garbage interrupts"), the ASpeed video engine sometimes asserts
> interrupts that the driver hasn't enabled. In addition to the
> CAPTURE_COMPLETE and FRAME_COMPLETE interrupts dealt with in that
> patch, COMP_READY has also been observed. Instead of playing
> whack-a-mole with each one individually, we can instead just blanket
> ignore everything we haven't explicitly enabled.
Suspect this will fix an intermittent problem on AST2500 with
screensaver. Change looks good, thanks!
Reviewed-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
> ---
>
> Changes since v2 [1]:
> - minor commit message improvements
>
> Changes since v1 [0]:
> - dropped error message
> - switched to a blanket-ignore approach as suggested by Ryan
>
> [0]
> https://lore.kernel.org/linux-arm-kernel/20201215024542.18888-1-zev@bewilderbeest.net/
> [1]
> https://lore.kernel.org/openbmc/20210506234048.3214-1-zev@bewilderbeest.net/
>
> drivers/media/platform/aspeed-video.c | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/media/platform/aspeed-video.c
> b/drivers/media/platform/aspeed-video.c
> index 7bb6babdcade..77611c296a25 100644
> --- a/drivers/media/platform/aspeed-video.c
> +++ b/drivers/media/platform/aspeed-video.c
> @@ -563,6 +563,12 @@ static irqreturn_t aspeed_video_irq(int irq,
> void *arg)
> struct aspeed_video *video = arg;
> u32 sts = aspeed_video_read(video, VE_INTERRUPT_STATUS);
>
> + /*
> + * Hardware sometimes asserts interrupts that we haven't
> actually
> + * enabled; ignore them if so.
> + */
> + sts &= aspeed_video_read(video, VE_INTERRUPT_CTRL);
> +
> /*
> * Resolution changed or signal was lost; reset the engine and
> * re-initialize
> @@ -629,16 +635,6 @@ static irqreturn_t aspeed_video_irq(int irq,
> void *arg)
> aspeed_video_start_frame(video);
> }
>
> - /*
> - * CAPTURE_COMPLETE and FRAME_COMPLETE interrupts come even
> when these
> - * are disabled in the VE_INTERRUPT_CTRL register so clear them
> to
> - * prevent unnecessary interrupt calls.
> - */
> - if (sts & VE_INTERRUPT_CAPTURE_COMPLETE)
> - sts &= ~VE_INTERRUPT_CAPTURE_COMPLETE;
> - if (sts & VE_INTERRUPT_FRAME_COMPLETE)
> - sts &= ~VE_INTERRUPT_FRAME_COMPLETE;
> -
> return sts ? IRQ_NONE : IRQ_HANDLED;
> }
>
next prev parent reply other threads:[~2021-09-01 15:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 22:02 [PATCH v3] media: aspeed-video: ignore interrupts that aren't enabled Zev Weiss
2021-08-25 2:14 ` [Phishing Risk] [External] " Lei Yu
2021-09-01 15:07 ` Eddie James [this message]
2021-09-06 10:10 ` Ryan Chen
2021-09-06 11:47 ` Joel Stanley
2021-09-28 18:57 ` Zev Weiss
2021-10-08 4:43 ` Joel Stanley
2021-10-08 5:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46edf81d60a38747f7d2511f840253a1c6867652.camel@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=andrew@aj.id.au \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=ryan_chen@aspeedtech.com \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).