openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Joseph Reynolds <jrey@linux.ibm.com>
To: Ed Tanous <edtanous@google.com>, "Zhang, ShuoX" <shuox.zhang@intel.com>
Cc: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Re: OpenBmc Redfish support etag property error - sha512
Date: Tue, 31 Aug 2021 18:14:05 -0500	[thread overview]
Message-ID: <634db90d-2b60-ba14-1dc4-7146e5b5b457@linux.ibm.com> (raw)
In-Reply-To: <CAH2-KxBV8AaW0aftJDOB2z75HyQXEV1ct6gbR-BYS90VWd=7AA@mail.gmail.com>



On 8/31/21 12:17 PM, Ed Tanous wrote:
> On Tue, Aug 31, 2021 at 1:11 AM Zhang, ShuoX <shuox.zhang@intel.com> wrote:
>> hi,
>>
>>                Etag is to check whether the json string returned by the server has changed ,  I plan to use MD5 encryption to generate etag , can’t  find etag in http request header.
> That's because we don't currently implement etag.  If you're looking
> at adding it, keep in mind, implementation of etag is more than simply
> including the header, and likely has some changes that would need to
> be made to the internals of the system.
>
> PS, MD5 hasn't really been acceptable for hashing algorithms for a
> while now.  Please research what the current guidance is on what hash
> to use for this;  I suspect the guidance is still sha256.
>
>
...snip...

FWIW, OpenBMC Linux-PAM modules (pam_unix.so) use the SHA-512 secure 
hash algorithm.  OpenBMC gets this setting by default from 
Yocto/OpenEmbedded configuration.

For background reading, see 
https://en.wikipedia.org/wiki/Secure_Hash_Algorithms

- Joseph

      reply	other threads:[~2021-08-31 23:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31  8:09 OpenBmc Redfish support etag property error Zhang, ShuoX
2021-08-31 17:17 ` Ed Tanous
2021-08-31 23:14   ` Joseph Reynolds [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=634db90d-2b60-ba14-1dc4-7146e5b5b457@linux.ibm.com \
    --to=jrey@linux.ibm.com \
    --cc=edtanous@google.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=shuox.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).