openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Chris Chen (TPI)" <Chris.Chen3@flex.com>,
	"Bills, Jason M" <jason.m.bills@linux.intel.com>,
	"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Re: [x86-power-control]: press the power button for a long time that can't force turn off system power
Date: Tue, 17 Aug 2021 21:00:57 +0930	[thread overview]
Message-ID: <66823be3-bf61-4d1d-8dd8-6798f51dd701@www.fastmail.com> (raw)
In-Reply-To: <DM6PR08MB5514BD820BCA7BCD3B810BFDDCFE9@DM6PR08MB5514.namprd08.prod.outlook.com>

Hi Chris,

On Tue, 17 Aug 2021, at 20:47, Chris Chen (TPI) wrote:
> Hi Andrew,
> 
> That means I'm able to choose one of following 2 options to achieve 
> pass-through behavior when I using x86-power-control package, is my 
> understanding correct?
> 
> 1. Add code to re-enable GPIOP0 and GPIOP1 into a pass-through function 
> after they are requested as a GPIO function in the x86-power-control 
> package. (Or maybe to create a script with "devmem > 0x1e6e24BC 32 
> 0x0F000000" command that will be run automatically after system up to 
> change register directly.)

This is a hack and should be a last resort. Even then I'd avoid it.

Certainly you should avoid shipping with /dev/mem enabled.

> 
> 2. Modify pinctrl in Kernel that will not disable GPIOP0 and GPIOP1's 
> pass-through function if they already are configured as a pass-through 
> when they are requesting as a GPIO function.

Perhaps, though maybe you should follow up on whether you can drive 
GPIOP1 when it's in pass-through mode. My recollection is you cannot, 
at least for the AST2500 and earlier, in which case both P0 and P1 are 
effectively inputs for the purpose of the GPIO controller despite P1 
being a physical output. This behaviour is probably more confusing than 
it is helpful.

There's also option 3 which is to emulate the pass-through in software, 
as I outlined in my previous email.

Hope that helps,

Andrew

  reply	other threads:[~2021-08-17 11:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23 10:28 Chris Chen (TPI)
2021-07-23 20:36 ` Bills, Jason M
2021-07-24  3:04   ` 回覆: " Chris Chen (TPI)
2021-07-26 16:46     ` Bills, Jason M
2021-08-16  3:52       ` Chris Chen (TPI)
2021-08-16  6:30         ` Andrew Jeffery
2021-08-16 10:45           ` 回覆: " Chris Chen (TPI)
2021-08-17  1:57             ` Andrew Jeffery
2021-08-17 11:17               ` Chris Chen (TPI)
2021-08-17 11:30                 ` Andrew Jeffery [this message]
2021-08-17 19:04                   ` Bills, Jason M
2021-08-18 11:07                     ` 回覆: " Chris Chen (TPI)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66823be3-bf61-4d1d-8dd8-6798f51dd701@www.fastmail.com \
    --to=andrew@aj.id.au \
    --cc=Chris.Chen3@flex.com \
    --cc=jason.m.bills@linux.intel.com \
    --cc=openbmc@lists.ozlabs.org \
    --subject='Re: [x86-power-control]: press the power button for a long time that can'\''t force turn off system power' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).