From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E56EBC433EF for ; Wed, 9 Feb 2022 11:10:48 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Jtxxy6CGLz30Mf for ; Wed, 9 Feb 2022 22:10:46 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=aj.id.au header.i=@aj.id.au header.a=rsa-sha256 header.s=fm2 header.b=gnQF5KfA; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=ofonA0yN; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=aj.id.au (client-ip=66.111.4.25; helo=out1-smtp.messagingengine.com; envelope-from=andrew@aj.id.au; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=aj.id.au header.i=@aj.id.au header.a=rsa-sha256 header.s=fm2 header.b=gnQF5KfA; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=ofonA0yN; dkim-atps=neutral Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Jtxx65GvQz2xtp for ; Wed, 9 Feb 2022 22:10:02 +1100 (AEDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id F22305C00D7; Wed, 9 Feb 2022 06:09:57 -0500 (EST) Received: from imap50 ([10.202.2.100]) by compute3.internal (MEProxy); Wed, 09 Feb 2022 06:09:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=bWykmU5VmuX3v2wq8uHr4mhP9EAoUC3ZxrE+Yf c6LRY=; b=gnQF5KfAWvPrfY2K9T4/348CKKKkaa9QtLkgcyN79+AFwZWzZtDv0B r7ne+XpcmBHnmbNimIFAxYmVE9xC84aBOBXj953aCXosJt4YnMJu4CYnsKqzn8bS FIM2RVpaZh1mA4tmi1Bckep/SXSn3ECOnX+wPymf/gbhvW+rXRqcKRtF9mrbY42x nE/kOT/mZnaPBWwSwn3i3CuDNYmbz1A1OznQvnHUUh2Zzy5Kt4OOsGkx5Pa3T4Xp gT7Hm537Q3X0+fP/ktYg0Qq9bWbiJ8h8aQK3Y5xcL+8V83dtp++2vsC8oF3pdFE5 mwnqBFQSRut4dkbdbxObCuGAkb9Na34A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=bWykmU5VmuX3v2wq8 uHr4mhP9EAoUC3ZxrE+Yfc6LRY=; b=ofonA0yN5MzvKXEmLp+WLz4RoxLoAK2SY VSctIEZaBjOt2cNLvSzK6COQHYpKnlaZHo6sHznYCy/DmcK90cj9vybjr2vGLCW1 ehJt0W+K8RxQE+kg5T+PNHz/hd5U4JC609/9ZKcMUdztxdE4JgeIkrS8kol8tBnm c+ZGEmKJYfuqQqOkB1HkwCGydDU1WbpInsy+KGPZoW93iIieYdW0t2/m6cfbVuS5 SRyxT8ACZrvI8LRIquPpZSbDvLl8zDA+ju8ykA3K4OB5qZBx/dr7R3KJ5x2MI+FC bk1iu+YQW8MwEkUBQ/L4JYJ/eh1yDvib8/Po0uw6qlrh3WTUsNydw== X-ME-Sender:

X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrheelgddvfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedftehnughr vgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucggtffrrg htthgvrhhnpeehhfefkefgkeduveehffehieehudejfeejveejfedugfefuedtuedvhefh veeuffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvfiesrghjrdhiugdrrghu X-ME-Proxy:

Received: by mailuser.nyi.internal (Postfix, from userid 501) id 866991920084; Wed, 9 Feb 2022 06:09:57 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-4748-g31a5b5f50e-fm-cal2020-20220204.001-g31a5b5f5 Mime-Version: 1.0 Message-Id: <6706daf1-f289-41d4-980a-98a5b59b45fe@www.fastmail.com> In-Reply-To: <20220207150409.358888-1-andrew@aj.id.au> References: <20220207150409.358888-1-andrew@aj.id.au> Date: Wed, 09 Feb 2022 21:39:36 +1030 From: "Andrew Jeffery" To: qemu-devel@nongnu.org Subject: Re: [PATCH 0/3] hw: aspeed_gpio: Model new interface for the AST2600 Content-Type: text/plain X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , openbmc@lists.ozlabs.org, =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Tue, 8 Feb 2022, at 01:34, Andrew Jeffery wrote: > Hello, > > This series adds support for a new register interface supported by the > Aspeed GPIO controller, present in at least the AST2600. > > The new interface is a single register implementing an indirect command > protocol that allows us to manipulate up to (at least) 208 GPIOs. This > makes it possible to write very simple drivers for e.g. u-boot and > jettison the need for the tedious data model required to deal with the > old register layout. > > I've lightly tested the device consistency under Linux. The Linux > driver is implemented in terms of the old interface, so data model > consistency can be tested one way by poking the driver using the > libgpiod tools and then the other using devmem to drive the new > interface. > > Please review! Naturally further testing revealed some quirks that require further enhancements to the modelling. Hold off on doing anything with this series for the moment. Cheers, Andrew