openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] ARM: dts: aspeed: Add TPM GPIO names
@ 2021-07-27  3:33 Joel Stanley
  2021-07-27  3:33 ` [PATCH 1/2] ARM: dts: rainier, everest: Add TPM reset GPIO Joel Stanley
  2021-07-27  3:33 ` [PATCH 2/2] ARM: dts: aspeed: tacoma: " Joel Stanley
  0 siblings, 2 replies; 5+ messages in thread
From: Joel Stanley @ 2021-07-27  3:33 UTC (permalink / raw)
  To: openbmc, andrew; +Cc: linux-arm-kernel, linux-aspeed

These patches add GPIO line names for the TPM reset signals in the p10
bmc designs. The lines are documented in the tacoma, ingram and tola
schematics.

Joel Stanley (2):
  ARM: dts: rainier, everest: Add TPM reset GPIO
  ARM: dts: aspeed: tacoma: Add TPM reset GPIO

 arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts | 2 +-
 arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 2 +-
 arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.32.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] ARM: dts: rainier, everest: Add TPM reset GPIO
  2021-07-27  3:33 [PATCH 0/2] ARM: dts: aspeed: Add TPM GPIO names Joel Stanley
@ 2021-07-27  3:33 ` Joel Stanley
  2021-07-27  3:58   ` Andrew Jeffery
  2021-07-27  3:33 ` [PATCH 2/2] ARM: dts: aspeed: tacoma: " Joel Stanley
  1 sibling, 1 reply; 5+ messages in thread
From: Joel Stanley @ 2021-07-27  3:33 UTC (permalink / raw)
  To: openbmc, andrew; +Cc: linux-arm-kernel, linux-aspeed

The GPIO is used to place the BMC-connected TPM in reset. This state is
latched until the BMC is next reset, blocking access to the TPM for that
boot.

On both machines this net is called TPM_RESET_LATCH_B.

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts | 2 +-
 arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts
index aa24cac8e5be..4536cd538af9 100644
--- a/arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts
@@ -253,7 +253,7 @@ &gpio0 {
 	/*O0-O7*/	"","","","","","","","",
 	/*P0-P7*/	"","","","","led-pcieslot-power","","","",
 	/*Q0-Q7*/	"","","","","","","","",
-	/*R0-R7*/	"","","","","","I2C_FLASH_MICRO_N","","",
+	/*R0-R7*/	"bmc-tpm-reset","","","","","I2C_FLASH_MICRO_N","","",
 	/*S0-S7*/	"","","","","","","","",
 	/*T0-T7*/	"","","","","","","","",
 	/*U0-U7*/	"","","","","","","","",
diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
index 481d0ee1f85f..06b3d1573780 100644
--- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
@@ -271,7 +271,7 @@ &gpio0 {
 	/*O0-O7*/	"","","","usb-power","","","","",
 	/*P0-P7*/	"","","","","pcieslot-power","","","",
 	/*Q0-Q7*/	"cfam-reset","","","","","","","",
-	/*R0-R7*/	"","","","","","","","",
+	/*R0-R7*/	"bmc-tpm-reset","","","","","","","",
 	/*S0-S7*/	"presence-ps0","presence-ps1","presence-ps2","presence-ps3",
 				"","","","",
 	/*T0-T7*/	"","","","","","","","",
-- 
2.32.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] ARM: dts: aspeed: tacoma: Add TPM reset GPIO
  2021-07-27  3:33 [PATCH 0/2] ARM: dts: aspeed: Add TPM GPIO names Joel Stanley
  2021-07-27  3:33 ` [PATCH 1/2] ARM: dts: rainier, everest: Add TPM reset GPIO Joel Stanley
@ 2021-07-27  3:33 ` Joel Stanley
  2021-07-27  4:04   ` Andrew Jeffery
  1 sibling, 1 reply; 5+ messages in thread
From: Joel Stanley @ 2021-07-27  3:33 UTC (permalink / raw)
  To: openbmc, andrew; +Cc: linux-arm-kernel, linux-aspeed

The GPIO is used to place the BMC-connected TPM in reset.

The net is called BMC_TPM_RST_N on Tacoma.

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
index e33153dcaea8..e39f310d55eb 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
@@ -126,7 +126,7 @@ &gpio0 {
 	/*M0-M7*/	"","","","","","","","",
 	/*N0-N7*/	"","","","","","","","",
 	/*O0-O7*/	"led-rear-power","led-rear-id","","usb-power","","","","",
-	/*P0-P7*/	"","","","","","","","",
+	/*P0-P7*/	"","","","","","bmc-tpm-reset","","",
 	/*Q0-Q7*/	"cfam-reset","","","","","","","fsi-routing",
 	/*R0-R7*/	"","","","","","","","",
 	/*S0-S7*/	"","","","","","","","",
-- 
2.32.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ARM: dts: rainier, everest: Add TPM reset GPIO
  2021-07-27  3:33 ` [PATCH 1/2] ARM: dts: rainier, everest: Add TPM reset GPIO Joel Stanley
@ 2021-07-27  3:58   ` Andrew Jeffery
  0 siblings, 0 replies; 5+ messages in thread
From: Andrew Jeffery @ 2021-07-27  3:58 UTC (permalink / raw)
  To: Joel Stanley, openbmc, Andrew Geissler; +Cc: linux-aspeed, linux-arm-kernel



On Tue, 27 Jul 2021, at 13:03, Joel Stanley wrote:
> The GPIO is used to place the BMC-connected TPM in reset. This state is
> latched until the BMC is next reset, blocking access to the TPM for that
> boot.
> 
> On both machines this net is called TPM_RESET_LATCH_B.

Hmm, unless we have different schematics where this has been changed, 
it's TPM_RESET_LATCH_N for Rainier (Ingraham) but TPM_RESET_LATCH_B for 
Everest (Tola).

> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
>  arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts | 2 +-
>  arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts 
> b/arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts
> index aa24cac8e5be..4536cd538af9 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts
> @@ -253,7 +253,7 @@ &gpio0 {
>  	/*O0-O7*/	"","","","","","","","",
>  	/*P0-P7*/	"","","","","led-pcieslot-power","","","",
>  	/*Q0-Q7*/	"","","","","","","","",
> -	/*R0-R7*/	"","","","","","I2C_FLASH_MICRO_N","","",
> +	/*R0-R7*/	"bmc-tpm-reset","","","","","I2C_FLASH_MICRO_N","","",
>  	/*S0-S7*/	"","","","","","","","",
>  	/*T0-T7*/	"","","","","","","","",
>  	/*U0-U7*/	"","","","","","","","",
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts 
> b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> index 481d0ee1f85f..06b3d1573780 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> @@ -271,7 +271,7 @@ &gpio0 {
>  	/*O0-O7*/	"","","","usb-power","","","","",
>  	/*P0-P7*/	"","","","","pcieslot-power","","","",
>  	/*Q0-Q7*/	"cfam-reset","","","","","","","",
> -	/*R0-R7*/	"","","","","","","","",
> +	/*R0-R7*/	"bmc-tpm-reset","","","","","","","",

Andrew G (/ Joel): we should probably add a "*-reset" class of GPIOs to 
the documentation ([1]). bmc-tpm-reset seems fine to me.

We should probably resolve the net name issue, but other than that:

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>

[1] https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] ARM: dts: aspeed: tacoma: Add TPM reset GPIO
  2021-07-27  3:33 ` [PATCH 2/2] ARM: dts: aspeed: tacoma: " Joel Stanley
@ 2021-07-27  4:04   ` Andrew Jeffery
  0 siblings, 0 replies; 5+ messages in thread
From: Andrew Jeffery @ 2021-07-27  4:04 UTC (permalink / raw)
  To: Joel Stanley, openbmc; +Cc: linux-arm-kernel, linux-aspeed



On Tue, 27 Jul 2021, at 13:03, Joel Stanley wrote:
> The GPIO is used to place the BMC-connected TPM in reset.
> 
> The net is called BMC_TPM_RST_N on Tacoma.
> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts 
> b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
> index e33153dcaea8..e39f310d55eb 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
> @@ -126,7 +126,7 @@ &gpio0 {
>  	/*M0-M7*/	"","","","","","","","",
>  	/*N0-N7*/	"","","","","","","","",
>  	/*O0-O7*/	"led-rear-power","led-rear-id","","usb-power","","","","",
> -	/*P0-P7*/	"","","","","","","","",
> +	/*P0-P7*/	"","","","","","bmc-tpm-reset","","",

Needs the documentation update, but otherwise:

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-07-27  4:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-27  3:33 [PATCH 0/2] ARM: dts: aspeed: Add TPM GPIO names Joel Stanley
2021-07-27  3:33 ` [PATCH 1/2] ARM: dts: rainier, everest: Add TPM reset GPIO Joel Stanley
2021-07-27  3:58   ` Andrew Jeffery
2021-07-27  3:33 ` [PATCH 2/2] ARM: dts: aspeed: tacoma: " Joel Stanley
2021-07-27  4:04   ` Andrew Jeffery

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).