From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B224AC433DB for ; Mon, 22 Mar 2021 18:07:47 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37EF96198E for ; Mon, 22 Mar 2021 18:07:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37EF96198E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4F42Xd67rlz30BS for ; Tue, 23 Mar 2021 05:07:45 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=QjkEd3Vz; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.vnet.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=bruce.mitchell@linux.vnet.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=QjkEd3Vz; dkim-atps=neutral Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4F42X96btNz302v for ; Tue, 23 Mar 2021 05:07:21 +1100 (AEDT) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12MI2n3c074628; Mon, 22 Mar 2021 14:07:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : from : to : cc : references : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=vD80fTKfR53hEebwYlY0bT8fkb2aJdGP78ge/EwmS+c=; b=QjkEd3VzvzarDec3GfF//Y1ZYmrp72At0ZkOr5ZjXsze406nfuGr6sgUt2ncM4afov3j nyNZv8M7GTaempirQfrkYOM4qlxyLj9HSvTFa2eSLA3fKTAsFEgFv9dJfNDp+H+VLv2l EVOguApvuojT06niF0a02VtoVKPyGCcRe4McYt+Ax2RL6jqwKUb5qNwBsafMGaGBmtj8 aaCRorlqaNHkzLcXYh2xqi9dA3dmD4VDgJzNLBvC++3VdXvVxAc4RnMl+Px7OtQ85pTN 2T+/+uI8Vm+FTn2FgUiMIPudwM8l5M2L5E4AT8/2vy9bn4hcCEnO/MGCf7UlAXmBUZlj FA== Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com with ESMTP id 37dx4a95rc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Mar 2021 14:07:05 -0400 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 12MI2Txn001973; Mon, 22 Mar 2021 18:07:04 GMT Received: from b03cxnp07027.gho.boulder.ibm.com (b03cxnp07027.gho.boulder.ibm.com [9.17.130.14]) by ppma02dal.us.ibm.com with ESMTP id 37d9amc8af-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Mar 2021 18:07:04 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp07027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 12MI73DY28770602 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Mar 2021 18:07:03 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2F7C5C6055; Mon, 22 Mar 2021 18:07:03 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C401CC605D; Mon, 22 Mar 2021 18:07:02 +0000 (GMT) Received: from [9.211.32.185] (unknown [9.211.32.185]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Mon, 22 Mar 2021 18:07:02 +0000 (GMT) Subject: Re: [PATCH linux-next tag: next-20210322] ARM: aspeed: Add CPU hotplug callbacks for kexec support From: Bruce Mitchell To: Joel Stanley , openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210322155720.2161941-1-bruce.mitchell@linux.vnet.ibm.com> Message-ID: <7c8ca40f-3f73-d8ea-08e2-ee7c0b0b6ab1@linux.vnet.ibm.com> Date: Mon, 22 Mar 2021 11:07:02 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-22_10:2021-03-22, 2021-03-22 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 spamscore=0 suspectscore=0 mlxlogscore=999 priorityscore=1501 mlxscore=0 adultscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103220132 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery , Eddie James Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On 3/22/2021 09:40, Bruce Mitchell wrote: > On 3/22/2021 08:57, Bruce Mitchell wrote: >> These callbacks are required for kexec to function. The AST2600 does not >> expose any controls for powering down it's CPU cores, so we borrow the >> approach taken from socfpga and wait in the idle loop. >> >> Author: Joel Stanley >> >> Signed-off-by: Bruce Mitchell >> --- >> arch/arm/mach-aspeed/platsmp.c | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/arch/arm/mach-aspeed/platsmp.c >> b/arch/arm/mach-aspeed/platsmp.c >> index 2324becf7991..1ae3ff5a9701 100644 >> --- a/arch/arm/mach-aspeed/platsmp.c >> +++ b/arch/arm/mach-aspeed/platsmp.c >> @@ -7,6 +7,8 @@ >> #include >> #include >> >> +#include >> + >> #define BOOT_ADDR 0x00 >> #define BOOT_SIG 0x04 >> >> @@ -53,9 +55,27 @@ static void __init >> aspeed_g6_smp_prepare_cpus(unsigned int max_cpus) >> iounmap(base); >> } >> >> +#ifdef CONFIG_HOTPLUG_CPU >> +static void aspeed_g6_cpu_die(unsigned int cpu) >> +{ >> + /* Do WFI. If we wake up early, go back into WFI */ >> + while (1) >> + cpu_do_idle(); >> +} >> + >> +static int aspeed_g6_cpu_kill(unsigned int cpu) >> +{ >> + return 1; >> +} >> +#endif >> + >> static const struct smp_operations aspeed_smp_ops __initconst = { >> .smp_prepare_cpus = aspeed_g6_smp_prepare_cpus, >> .smp_boot_secondary = aspeed_g6_boot_secondary, >> +#ifdef CONFIG_HOTPLUG_CPU >> + .cpu_die = aspeed_g6_cpu_die, >> + .cpu_kill = aspeed_g6_cpu_kill, >> +#endif >> }; >> >> CPU_METHOD_OF_DECLARE(aspeed_smp, "aspeed,ast2600-smp", >> &aspeed_smp_ops); >> > > Adding Andrew Jeffery and Eddie James to the CC list. > Adding linux-kernel@vger.kernel.org and linux-arm-kernel@lists.infradead.org based feedback.