Lost the threshold redfish log when update phosphor-sel-logger.

Lost the threshold redfish log when update phosphor-sel-logger.

[Thu Nguyen OS]

[-- Attachment #1.1: Type: text/plain, Size: 741 bytes --]

Hi All,

After updating the base code of our openBmc source for Mt Jade platform to new version, I saw all of threshold warning/error of hwmon are losted.
Below is the sensor value and the configured thresholds.
[cid:image001.png@01D72A6A.FF772FA0]
Check in the web, the sensor value is bigger than warning threshold, but there are no log SEL entry in Redfish log.

After spending some time on debugging, I found that the below commit is the cause:
https://github.com/openbmc/phosphor-sel-logger/commit/25b26e162bd109b51aa09b16f26f9aa3d9d940fa

Remove this commit in phosphor-sel-logger, I can see the warning log in Redfish.
Do I need any configuration in phosphor-sel-logger to make this commit work?

Thanks.
Thu Nguyen.


[-- Attachment #1.2: Type: text/html, Size: 3472 bytes --]

[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 41932 bytes --]

Re: Lost the threshold redfish log when update phosphor-sel-logger.

[Thu Nguyen OS]

[-- Attachment #1.1: Type: text/plain, Size: 1184 bytes --]

Dear Zhikui Ren, Patrick Williams and Jason M. Bills,

Do you have any comment in this?

Dear Zhikui Ren,

Do you verify this commit with the sensors which added thru phosphor-hwmon?

Regards.
Thu Nguyen.



From: Thu Nguyen OS <thu@os.amperecomputing.com>
Date: Monday, 5 April 2021 at 22:28
To: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Lost the threshold redfish log when update phosphor-sel-logger.

Hi All,

After updating the base code of our openBmc source for Mt Jade platform to new version, I saw all of threshold warning/error of hwmon are losted.
Below is the sensor value and the configured thresholds.
[cid:image001.png@01D73074.73E33A50]
Check in the web, the sensor value is bigger than warning threshold, but there are no log SEL entry in Redfish log.

After spending some time on debugging, I found that the below commit is the cause:
https://github.com/openbmc/phosphor-sel-logger/commit/25b26e162bd109b51aa09b16f26f9aa3d9d940fa

Remove this commit in phosphor-sel-logger, I can see the warning log in Redfish.
Do I need any configuration in phosphor-sel-logger to make this commit work?

Thanks.
Thu Nguyen.


[-- Attachment #1.2: Type: text/html, Size: 5257 bytes --]

[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 41933 bytes --]

Re: Lost the threshold redfish log when update phosphor-sel-logger.

[Bills, Jason M]

On 4/13/2021 12:51 AM, Thu Nguyen OS wrote:
> Dear Zhikui Ren, Patrick Williams and Jason M. Bills,
> 
> Do you have any comment in this?
> 
> Dear Zhikui Ren,
> 
> Do you verify this commit with the sensors which added thru phosphor-hwmon?
This issue was recently discussed here: 
https://lore.kernel.org/openbmc/TY2PR04MB3712DCE11C578706F5F6401F88639@TY2PR04MB3712.apcprd04.prod.outlook.com/.

Since that discussion, this change to phosphor-dbus-interfaces was 
merged to add support for new threshold signals that contain the sensor 
value: 
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/39899.

I believe that corresponding changes can now be added to dbus-sensors, 
hwmon, and sel-logger to correctly handle these new signals to resolve 
the issue you see here.
> 
> Regards.
> 
> Thu Nguyen.
> 
> *From: *Thu Nguyen OS <thu@os.amperecomputing.com>
> *Date: *Monday, 5 April 2021 at 22:28
> *To: *"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
> *Subject: *Lost the threshold redfish log when update phosphor-sel-logger.
> 
> Hi All,
> 
> After updating the base code of our openBmc source for Mt Jade platform 
> to new version, I saw all of threshold warning/error of hwmon are losted.
> 
> Below is the sensor value and the configured thresholds.
> 
> Check in the web, the sensor value is bigger than warning threshold, but 
> there are no log SEL entry in Redfish log.
> 
> After spending some time on debugging, I found that the below commit is 
> the cause:
> 
> https://github.com/openbmc/phosphor-sel-logger/commit/25b26e162bd109b51aa09b16f26f9aa3d9d940fa
> 
> Remove this commit in phosphor-sel-logger, I can see the warning log in 
> Redfish.
> 
> Do I need any configuration in phosphor-sel-logger to make this commit work?
> 
> Thanks.
> 
> Thu Nguyen.
>