From: Quan Nguyen <quan@os.amperecomputing.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
Jean Delvare <jdelvare@suse.com>,
linux-aspeed@lists.ozlabs.org, Jonathan Corbet <corbet@lwn.net>,
Andrew Jeffery <andrew@aj.id.au>,
openbmc@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Thang Q . Nguyen" <thang@os.amperecomputing.com>,
Phong Vo <phong@os.amperecomputing.com>,
Rob Herring <robh+dt@kernel.org>,
Open Source Submission <patches@amperecomputing.com>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH v3 2/4] mfd: simple-mfd-i2c: Adds Ampere's Altra SMpro support
Date: Thu, 15 Apr 2021 11:15:48 +0700 [thread overview]
Message-ID: <94a8cf49-2de2-ead5-8134-d18a90a6ad57@os.amperecomputing.com> (raw)
In-Reply-To: <20210414122130.GA113503@roeck-us.net>
On 14/04/2021 19:21, Guenter Roeck wrote:
> On Fri, Apr 09, 2021 at 10:13:30AM +0700, Quan Nguyen wrote:
>> Adds an MFD driver for SMpro found on the Mt.Jade hardware reference
>> platform with Ampere's Altra processor family.
>>
>> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
>> Reported-by: kernel test robot <lkp@intel.com>
>> ---
>> drivers/mfd/Kconfig | 10 ++++++++++
>> drivers/mfd/simple-mfd-i2c.c | 6 ++++++
>> 2 files changed, 16 insertions(+)
>>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index d07e8cf93286..f7a6460f7aa0 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -77,6 +77,16 @@ config MFD_AS3711
>> help
>> Support for the AS3711 PMIC from AMS
>>
>> +config MFD_SMPRO
>> + tristate "Ampere Computing MFD SMpro core driver"
>> + select MFD_SIMPLE_MFD_I2C
>
> This is missing "depends on I2C".
>
Thanks Guenter to help pointing this out.
This fixes the issue reported by kernel test robot. Will include this in
next version.
>> + help
>> + Say yes here to enable SMpro driver support for Ampere's Altra
>> + processor family.
>> +
>> + Ampere's Altra SMpro exposes an I2C regmap interface that can
>> + be accessed by child devices.
>> +
>> config MFD_AS3722
>> tristate "ams AS3722 Power Management IC"
>> select MFD_CORE
>> diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
>> index 87f684cff9a1..9a44655f5592 100644
>> --- a/drivers/mfd/simple-mfd-i2c.c
>> +++ b/drivers/mfd/simple-mfd-i2c.c
>> @@ -21,6 +21,11 @@ static const struct regmap_config simple_regmap_config = {
>> .val_bits = 8,
>> };
>>
>> +static const struct regmap_config simple_word_regmap_config = {
>> + .reg_bits = 8,
>> + .val_bits = 16,
>> +};
>> +
>> static int simple_mfd_i2c_probe(struct i2c_client *i2c)
>> {
>> const struct regmap_config *config;
>> @@ -39,6 +44,7 @@ static int simple_mfd_i2c_probe(struct i2c_client *i2c)
>>
>> static const struct of_device_id simple_mfd_i2c_of_match[] = {
>> { .compatible = "kontron,sl28cpld" },
>> + { .compatible = "ampere,smpro", .data = &simple_word_regmap_config },
>> {}
>> };
>> MODULE_DEVICE_TABLE(of, simple_mfd_i2c_of_match);
next prev parent reply other threads:[~2021-04-15 4:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 3:13 [PATCH v3 0/4] Add Ampere's Altra SMPro hwmon driver Quan Nguyen
2021-04-09 3:13 ` [PATCH v3 1/4] dt-bindings: mfd: Add bindings for Ampere Altra SMPro drivers Quan Nguyen
2021-04-13 13:49 ` Rob Herring
2021-04-14 8:28 ` Quan Nguyen
2021-04-15 12:33 ` Quan Nguyen
2021-04-09 3:13 ` [PATCH v3 2/4] mfd: simple-mfd-i2c: Adds Ampere's Altra SMpro support Quan Nguyen
2021-04-14 12:21 ` Guenter Roeck
2021-04-15 4:15 ` Quan Nguyen [this message]
2021-04-09 3:13 ` [PATCH v3 3/4] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver Quan Nguyen
2021-04-14 12:33 ` Guenter Roeck
2021-04-15 4:13 ` Quan Nguyen
2021-04-09 3:13 ` [PATCH v3 4/4] docs: hwmon: (smpro-hwmon) Add documentation Quan Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a8cf49-2de2-ead5-8134-d18a90a6ad57@os.amperecomputing.com \
--to=quan@os.amperecomputing.com \
--cc=andrew@aj.id.au \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=robh+dt@kernel.org \
--cc=thang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).