Hi Brad/Andrew,

As we discussed, I will upgrade Chassis based on C++ & sdbusplus by 3 steps.
Now, the step 1 is almost ready (Patch got two +1), so we can move on the step 2 “upstream the chassis implementation”.
Can you help create a repo “chassis-manager” for chassis implementation?

More info attached:
[cid:image002.jpg@01D41E83.F326C3A0]

       [cid:image004.jpg@01D41E83.F326C3A0]
Thanks,
Kuiying.

From: Andrew Geissler (Code Review) [mailto:gerrit@openbmc-project.xyz]
Sent: Thursday, June 28, 2018 9:44 PM
To: Wang, Kuiying <kuiying.wang@intel.com<mailto:kuiying.wang@intel.com>>
Cc: Jenkins <openbmc-ci-admin@ozlabs.org<mailto:openbmc-ci-admin@ozlabs.org>>; Brad Bishop <bradleyb@fuzziesquirrel.com<mailto:bradleyb@fuzziesquirrel.com>>; Tom Joseph <tomjoseph@in.ibm.com<mailto:tomjoseph@in.ibm.com>>; Yong Li <yong.b.li@linux.intel.com<mailto:yong.b.li@linux.intel.com>>; Tanous, Ed <ed.tanous@intel.com<mailto:ed.tanous@intel.com>>; Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com<mailto:richard.marian.thomaiyar@linux.intel.com>>
Subject: Change in openbmc/phosphor-dbus-interfaces[master]: Upgrade D-Bus API about Chassis Power Control from “/org/openbmc” to ...


Andrew Geissler posted comments on this change.

View Change<https://gerrit.openbmc-project.xyz/11278>

Patch set 4:

ok, this is making more sense. I think what's a bit confusing is we'd pretty much completely deprecated pychassisctl with the new chassis and host state dbus interfaces I linked below. So if you want this review to go quicker, removing that aspect from this review would be best (i.e. just stick with the Buttons). Otherwise we can bang it out in the community call in a few weeks. Breaking it up into smaller, more specific reviews is better in general anyway I think. Thanks for refactoring these into C++ and defining their sdbusplus interfaces, it has always been on our TODO list but never made it to the top.

To view, visit change 11278<https://gerrit.openbmc-project.xyz/11278>. To unsubscribe, visit settings<https://gerrit.openbmc-project.xyz/settings>.
Gerrit-Project: openbmc/phosphor-dbus-interfaces
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf8990d19633d2df2beeb4b2c22f30f1abad6a45
Gerrit-Change-Number: 11278
Gerrit-PatchSet: 4
Gerrit-Owner: kuiying.wang@intel.com<mailto:kuiying.wang@intel.com>
Gerrit-Reviewer: Andrew Geissler <geissonator@yahoo.com<mailto:geissonator@yahoo.com>>
Gerrit-Reviewer: Brad Bishop <bradleyb@fuzziesquirrel.com<mailto:bradleyb@fuzziesquirrel.com>>
Gerrit-Reviewer: Ed Tanous <ed.tanous@intel.com<mailto:ed.tanous@intel.com>>
Gerrit-Reviewer: Jenkins <openbmc-ci-admin@ozlabs.org<mailto:openbmc-ci-admin@ozlabs.org>>
Gerrit-Reviewer: Jia, Chunhui
Gerrit-Reviewer: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com<mailto:richard.marian.thomaiyar@linux.intel.com>>
Gerrit-Reviewer: Tom Joseph <tomjoseph@in.ibm.com<mailto:tomjoseph@in.ibm.com>>
Gerrit-Reviewer: Yong Li <yong.b.li@linux.intel.com<mailto:yong.b.li@linux.intel.com>>
Gerrit-Reviewer: kuiying.wang@intel.com<mailto:kuiying.wang@intel.com>
Gerrit-Comment-Date: Thu, 28 Jun 2018 13:44:21 +0000
Gerrit-HasComments: No