RE: Need create a repo for chassis implementation.

["Wang, Kuiying" <kuiying.wang@intel.com>]

Hi Andrew,
I agree w/ you on " smaller, more specific repositories", to create " phosphor-buttons" for handling buttons and create different repo for power control for specific machine/company/hardware like "openpower-power-control" and " x86-power-control".

In a word, we need create 3 repos as following:
phosphor-buttons
openpower-power-control
x86-power-control  

Brad,
I will not send pictures and attachments to the mail list in the future.

Thanks,
Kuiying.


-----Original Message-----
From: bradleyb@bajor.fuzziesquirrel.com [mailto:bradleyb@bajor.fuzziesquirrel.com] On Behalf Of Brad Bishop
Sent: Wednesday, July 25, 2018 6:15 PM
To: Wang, Kuiying <kuiying.wang@intel.com>; 'openbmc@lists.ozlabs.org' <openbmc@lists.ozlabs.org>
Cc: 'geissonator@yahoo.com' <geissonator@yahoo.com>; Tanous, Ed <ed.tanous@intel.com>; 'yong.b.li@linux.intel.com' <yong.b.li@linux.intel.com>; 'richard.marian.thomaiyar@linux.intel.com' <richard.marian.thomaiyar@linux.intel.com>; 'tomjoseph@in.ibm.com' <tomjoseph@in.ibm.com>; 'openbmc-ci-admin@ozlabs.org' <openbmc-ci-admin@ozlabs.org>; 'adamliyi@msn.com' <adamliyi@msn.com>
Subject: Re: Need create a repo for chassis implementation.

On Wed, 2018-07-18 at 02:46 +0000, Wang, Kuiying wrote:
> Hi Brad/Andrew,
>  
> As we discussed, I will upgrade Chassis based on C++ & sdbusplus by 3 
> steps.
> Now, the step 1 is almost ready (Patch got two +1), so we can move on 
> the step 2 “upstream the chassis implementation”.
> Can you help create a repo “chassis-manager” for chassis 
> implementation?

Hi Kuiying

Andrew tried to reply to your note but it was bounced by the list for being too big.  In the future please don't send pictures or attachments to the list.  I'll insert Andrew's reply here.

thx - brad

Hi Kuiying, thanks for refactoring these skeleton repositories. Within openbmc, we try to have smaller, more specific repositories. So I'm wondering if instead we should create a repo specifically for handling buttons on openbmc machines:
phosphor-buttons

The pychassisctl function has all been deprecated by phosphor-state- manager interfaces (except the button event monitoring).  I'd vote we just put the button actions in the new phosphor-button repo (i.e.
calling the appropriate systemd targets)

The power control function is a bit more complicated.  It could be specific to a machine, specific to a company, or specific to the type of hardware.  The design there is to have a common dbus API and then a repo for different implementations.  The code in skeleton/op- pwrctl/power_control_obj.c was I believe attempted to be written in a generic way but based on your info below, seems like for now we need two new repositories?

openpower-power-control
x86-power-control  

Andrew

>  
> More info attached:
> 
>  
>        
> Thanks,
> Kuiying.